Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 26 Oct 2021 19:02:07 +0200
From:   David Heidelberg <david@ixit.cz>
Subject: Re: [PATCH v2] dt-bindings: net: qcom,ipa: IPA does support up to two
 iommus
To:     Alex Elder <elder@ieee.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Alex Elder <elder@kernel.org>, ~okias/devicetree@lists.sr.ht,
        linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Message-Id: <JNGL1R.U8OWUCOV58262@ixit.cz>
In-Reply-To: <2de53575-af6e-5bb9-e7ad-5d924656867d@ieee.org>
References: <20211026163240.131052-1-david@ixit.cz>
        <2de53575-af6e-5bb9-e7ad-5d924656867d@ieee.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Precedence: bulk

thanks, I'll try to work on my commit messages :)

David


On Tue, Oct 26 2021 at 11:47:46 -0500, Alex Elder <elder@ieee.org> 
wrote:
> On 10/26/21 11:32 AM, David Heidelberg wrote:
>> Fix warnings as:
>> arch/arm/boot/dts/qcom-sdx55-mtp.dt.yaml: ipa@1e40000: iommus: [[21, 
>> 1504, 0], [21, 1506, 0]] is too long
>> 	From schema: Documentation/devicetree/bindings/net/qcom,ipa.yaml
>> 
>> Signed-off-by: David Heidelberg <david@ixit.cz>
> 
> Looks good to me.  I'm not sure why the minItems is required,
> unless it's to indicate that it must be at least 1 and can't
> be missing.  But iommus is also stated to be required elsewhere
> in the binding.
> 
> In the future, it's helpful to indicate the command you
> used to produce the warning in your commit message.  And
> furthermore, describing the problem (and not just including
> the error message) is even more helpful.
> 
> Reviewed-by: Alex Elder <elder@linaro.org>
> 
>> ---
>>   Documentation/devicetree/bindings/net/qcom,ipa.yaml | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml 
>> b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
>> index b8a0b392b24e..b86edf67ce62 100644
>> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
>> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
>> @@ -64,7 +64,8 @@ properties:
>>         - const: gsi
>>       iommus:
>> -    maxItems: 1
>> +    minItems: 1
>> +    maxItems: 2
>>       clocks:
>>       maxItems: 1
>> 
>