Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Anup Patel <anup.patel@wdc.com>
To:     Palmer Dabbelt <palmer@dabbelt.com>,
        Palmer Dabbelt <palmerdabbelt@google.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Atish Patra <atish.patra@wdc.com>,
        Anup Patel <anup@brainfault.org>, kvm@vger.kernel.org,
        kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org, Anup Patel <anup.patel@wdc.com>,
        Ian Huang <ihuang@ventanamicro.com>
Subject: [PATCH 3/3] RISC-V: KVM: Fix GPA passed to __kvm_riscv_hfence_gvma_xyz() functions
Date:   Tue, 26 Oct 2021 22:31:36 +0530
Message-Id: <20211026170136.2147619-4-anup.patel@wdc.com>
In-Reply-To: <20211026170136.2147619-1-anup.patel@wdc.com>
References: <20211026170136.2147619-1-anup.patel@wdc.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
WDCIPOUTBOUND: EOP-TRUE
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?72l4vHc2Ty+x9Cb3lofzn26wrf6VbWdNACUyAzpTqskBj8NaNiLPL0XUw07R?=
 =?us-ascii?Q?DsKtlXApr8Wqj1XdyRLM4VQXGxjVtEOYWMsvNVRvxX+1WBSdRda+esHKQkj6?=
 =?us-ascii?Q?dAvlCyPhkHNCeKrxIzNUmHLzk67ysyqjCWdu4CTr62Y6Mi1I3NL+w0uaWPwp?=
 =?us-ascii?Q?u2rgbIt5YbWaTo+ld5jvCgrHesYtFbKm8A/TOq682TrzMproJoaqHBYPbdPU?=
 =?us-ascii?Q?65qLQLly7HPti16dl7e69nSo9e5McLYTNJz54s4sfPzo0lnqZHBHLDN2Oypd?=
 =?us-ascii?Q?I91lRsN11a6tonvqFR0dpkq7tdsh6zo0erzowwscGN1pO8r6Q0GWRw+SlIj3?=
 =?us-ascii?Q?Hfl4SmQ8GookpNmKZiV0B06AtKn78YDCvqyRJ/F32nZ8V6HRZAMgRbqR4PQs?=
 =?us-ascii?Q?C7RTZH4NWNGGkKbhFYWqBLS05/b4E3U7/mj595y7oKcum9Q0GYnmk9gzg3ne?=
 =?us-ascii?Q?DU8wltTgzqc+m5rOLFP61zcM1GJHxlEXdZXTlXcxHbG+gdo75MhKTFV4KamZ?=
 =?us-ascii?Q?D9zTmHzWWTRwsama0Kut3TZGmlyGNjbn5suGi410uBIL0qR+ELoVJKh7rvFp?=
 =?us-ascii?Q?ISeCR9Er8H0HMm/p19GDI6T15qC8C2CYuG8nOtqTKthohtApCglFeRISBvjJ?=
 =?us-ascii?Q?gW9zlg973mi3isLED1whXHqKFPzJMZAB3NY5laoXUeo0Plc5B0EYXuVZ+yPx?=
 =?us-ascii?Q?Zz39Nbh+AQnkDaRHdt/QPIKUA00/Z5hWa54hW9neLKjwBS9JZ9eDQgtvCd2O?=
 =?us-ascii?Q?qcD14QgSH1LLma1vrMA+kiYaFf7pyEIl2jO8sXwr1zoKSgS7alOgfpigP9A7?=
 =?us-ascii?Q?lWSXukEYmfdwPIaE/727MIdDnCuGo5creJv+tTnI4pMefJDzXWo99NO3Jm8l?=
 =?us-ascii?Q?NV8YbgtTiZhnbikEuJz1zJndty4Ek3zUulp/pSeK4Vjxc3ztHkfXSZEdMpnC?=
 =?us-ascii?Q?DLVVSNbTgxc80X1DrRL9/55JYiAobR+zzs+J/1IZgVfYNWMz9H6MRloTsKrH?=
 =?us-ascii?Q?Oh9yG48LjAaXCb8ErlM5Fd4VObRNqJ8OFNwELvzIpiEHdUOrWuPvHzqz0Tnb?=
 =?us-ascii?Q?RUwLbKKB/40M2rAS07oYG4Xuy9lSCG+REqoX09UqP+ahagpLFkEhTEvLTD5L?=
 =?us-ascii?Q?ps6EjHp9rc4knoebOS98D3shkeGiEk1bNNF5X18SiFEUwd/cHfIlpIjj7rGP?=
 =?us-ascii?Q?Oe42BN5SQXDeoUQw7Ow6gdPwxehit/46NAwv48RKk5sEYaA5JqQMxlQpK7WF?=
 =?us-ascii?Q?Ix/XN9Ggue1kp6FY4SkjJ5Px2tTB1cHQcKPTdtNwUr9EH9mBh+PQRuISBPMY?=
 =?us-ascii?Q?l9iWYU5W8vltRQmXM3LpGno0Jv+/Nl7yn5EEW7eADBtuANMAyrL2Y8hkTBgG?=
 =?us-ascii?Q?yQzCnRIuBUUZkWoCyqGMtrqBRpqdmpKaVVGObzVVeCRuqpaO3XO8fEIr2L/w?=
 =?us-ascii?Q?xQfL2jELppFNtU3WkcrYii8pnq9bbXTLs3cOjdpeg1azBrxGb0/MT2Fx3ZZq?=
 =?us-ascii?Q?CwvTN9vcBZ6sJRJSKA1iyQHzq6maZOn4Wx4nBH+qPQeNr7l3wNFeJgNt5XKX?=
 =?us-ascii?Q?PN3vaz2uaEkveuVQ9uNIYKuo3w2wimyJwRQApbvhEIj3ngJ3U6b+WmvTnwdr?=
 =?us-ascii?Q?m9f8q+0slkY1mSHiV3qkDn0=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2b459cbb-0bba-4478-edb1-08d998a27d8d
X-MS-Exchange-CrossTenant-AuthSource: CO6PR04MB7812.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 17:03:11.1200
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wzzsl04IxhQTt6eBDChz2j9Cl/j74L1tEes4KQRIaTXcd7dlHzZEIMxwA3/DCxOZHgaHvamRmjjPKnSvNbtgvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR04MB8314
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The parameter passed to HFENCE.GVMA instruction in rs1 register
is guest physical address right shifted by 2 (i.e. divided by 4).

Unfortunately, we overlooked the semantics of rs1 registers for
HFENCE.GVMA instruction and never right shifted guest physical
address by 2. This issue did not manifest for hypervisors till
now because:
  1) Currently, only __kvm_riscv_hfence_gvma_all() and SBI
     HFENCE calls are used to invalidate TLB.
  2) All H-extension implementations (such as QEMU, Spike,
     Rocket Core FPGA, etc) that we tried till now were
     conservatively flushing everything upon any HFENCE.GVMA
     instruction.

This patch fixes GPA passed to __kvm_riscv_hfence_gvma_vmid_gpa()
and __kvm_riscv_hfence_gvma_gpa() functions.

Fixes: fd7bb4a251df ("RISC-V: KVM: Implement VMID allocator")
Reported-by: Ian Huang <ihuang@ventanamicro.com>
Signed-off-by: Anup Patel <anup.patel@wdc.com>
---
 arch/riscv/include/asm/kvm_host.h | 5 +++--
 arch/riscv/kvm/tlb.S              | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/arch/riscv/include/asm/kvm_host.h b/arch/riscv/include/asm/kvm_host.h
index d27878d6adf9..25ba21f98504 100644
--- a/arch/riscv/include/asm/kvm_host.h
+++ b/arch/riscv/include/asm/kvm_host.h
@@ -214,9 +214,10 @@ static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {}
 
 #define KVM_ARCH_WANT_MMU_NOTIFIER
 
-void __kvm_riscv_hfence_gvma_vmid_gpa(unsigned long gpa, unsigned long vmid);
+void __kvm_riscv_hfence_gvma_vmid_gpa(unsigned long gpa_divby_4,
+				      unsigned long vmid);
 void __kvm_riscv_hfence_gvma_vmid(unsigned long vmid);
-void __kvm_riscv_hfence_gvma_gpa(unsigned long gpa);
+void __kvm_riscv_hfence_gvma_gpa(unsigned long gpa_divby_4);
 void __kvm_riscv_hfence_gvma_all(void);
 
 int kvm_riscv_stage2_map(struct kvm_vcpu *vcpu,
diff --git a/arch/riscv/kvm/tlb.S b/arch/riscv/kvm/tlb.S
index c858570f0856..899f75d60bad 100644
--- a/arch/riscv/kvm/tlb.S
+++ b/arch/riscv/kvm/tlb.S
@@ -31,7 +31,7 @@
 
 ENTRY(__kvm_riscv_hfence_gvma_vmid_gpa)
 	/*
-	 * rs1 = a0 (GPA)
+	 * rs1 = a0 (GPA >> 2)
 	 * rs2 = a1 (VMID)
 	 * HFENCE.GVMA a0, a1
 	 * 0110001 01011 01010 000 00000 1110011
@@ -53,7 +53,7 @@ ENDPROC(__kvm_riscv_hfence_gvma_vmid)
 
 ENTRY(__kvm_riscv_hfence_gvma_gpa)
 	/*
-	 * rs1 = a0 (GPA)
+	 * rs1 = a0 (GPA >> 2)
 	 * rs2 = zero
 	 * HFENCE.GVMA a0
 	 * 0110001 00000 01010 000 00000 1110011
-- 
2.25.1