Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211025163121.2189630-1-janusz.dziedzic@gmail.com> <39561c73-732e-bc38-e250-a0bdf51b09f9@linaro.org>
In-Reply-To: <39561c73-732e-bc38-e250-a0bdf51b09f9@linaro.org>
From:   Janusz Dziedzic <janusz.dziedzic@gmail.com>
Date:   Tue, 26 Oct 2021 20:11:05 +0200
Message-ID: <CAFED-jkGhX=z49T0UrgqsttXXLFJDFyh8JmftwpWmW9zH9aVaA@mail.gmail.com>
Subject: Re: [PATCH] soc: qcom: qmi: add a prompt to QCOM_QMI_HELPERS
To:     Alex Elder <elder@linaro.org>
Cc:     LKML <linux-kernel@vger.kernel.org>, linux-soc@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

wt., 26 pa=C5=BA 2021 o 15:43 Alex Elder <elder@linaro.org> napisa=C5=82(a)=
:
>
> On 10/25/21 11:31 AM, Janusz Dziedzic wrote:
> > From: Alex Elder <elder@linaro.org>
> >
> > Add a prompt to the "tristate" attribute in the Kconfig file in
> > which QCOM_QMI_HELPERS is defined; I find it doesn't get selected
> > without it.
>
> This was a *long* time ago!
>    https://lore.kernel.org/all/20180427140358.30839-1-elder@linaro.org/
>
> The discussion that followed indicated that the thing that needs
> QCOM_QMI_HELPERS should *select* it rather than *depend on it.
>
> Will this not work for you?
>
This don't work, we can't run select from backports.
Backports drivers - ath11k for this case - build out of the tree as a
separate modules.
Eg. Today we are using kernel 5.10
and backports generated from kernel 5.15.
So our kernel 5.10 don't check CONFIG_ATH11K
This is what I see from our kernel:

Selected by [n]:
ATH11K [=3Dn] && NETDEVICES [=3Dy] && WLAN [=3Dy] && WLAN_VENDOR_ATH [=3Dn]=
 &&
MAC80211 [=3Dn] && HAS_DMA [=3Dy] && CRYPTO_MICHAEL_MIC [=3Dn]

But we build backports/ath11k module which has:
depends on QCOM_QMI_HELPERS


To enable backports/ath11k build we need kernel that have
QCOM_QMI_HELPERS enabled.
Because of that we need this configurable.

BR
Janusz


>                                         -Alex
>
> > We need it in OpenWRT project, when using WiFi backports
> > and build ath11k driver. While ath11k driver depends on
> > QCOM_QMI_HELPERS we need way to enable this option in
> > our kernel.
> >
> > Signed-off-by: Alex Elder <elder@linaro.org>
> > Signed-off-by: Janusz Dziedzic <janusz.dziedzic@gmail.com>
> > ---
> >   drivers/soc/qcom/Kconfig | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> > index fe3c486ae32d..16fb8e286015 100644
> > --- a/drivers/soc/qcom/Kconfig
> > +++ b/drivers/soc/qcom/Kconfig
> > @@ -92,7 +92,7 @@ config QCOM_PDR_HELPERS
> >       select QCOM_QMI_HELPERS
> >
> >   config QCOM_QMI_HELPERS
> > -     tristate
> > +     tristate "Qualcomm QMI Helpers"
> >       depends on NET
> >
> >   config QCOM_RMTFS_MEM
> >
>


--=20
Janusz Dziedzic