Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] mm: move more expensive part of XA setup out of mapping
 check
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <49f67983-b802-8929-edab-d807f745c9ca@kernel.dk>
 <YXhEAZMf9Qrsev82@casper.infradead.org>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <6a9e41c1-0608-1ba8-788e-8aa402d8a0cb@kernel.dk>
Date:   Tue, 26 Oct 2021 12:11:18 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <YXhEAZMf9Qrsev82@casper.infradead.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/26/21 12:08 PM, Matthew Wilcox wrote:
> On Tue, Oct 26, 2021 at 10:01:20AM -0600, Jens Axboe wrote:
>> The fast path here is not needing any writeback, yet we spend time setting
>> up the xarray lookup data upfront. Move the part that actually needs to
>> iterate the address space mapping into a separate helper, saving ~30% of
>> the time here.
> 
> No objection to this patch, but it did remind me that I never saw an answer to
> https://lore.kernel.org/all/CAHk-=wg_-EwefQ_3Osz4iJxTrTk3tfrV53Z7-jaGg=tm9i5TXg@mail.gmail.com/
> (and nor did lore)

Totally missed that, and yes there could be cases where that lookup is
going to be way too slow. I'll take a look.

-- 
Jens Axboe