Date: Tue, 2 Jan 2007 22:45:59 +0000
From: Alan <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
       Alessandro Suardi <alessandro.suardi@gmail.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and
 v2.6.20-rc3 released))
Message-ID: <20070102224559.2089d28d@localhost.localdomain>
In-Reply-To: <459ACE9C.7020107@pobox.com>
References: <Pine.LNX.4.64.0612311710430.4473@woody.osdl.org>
	<5a4c581d0701010528y3ba05247nc39f2ef096f84afa@mail.gmail.com>
	<Pine.LNX.4.64.0701011209140.4473@woody.osdl.org>
	<459973F6.2090201@pobox.com>
	<20070102115834.1e7644b2@localhost.localdomain>
	<459AC808.1030807@pobox.com>
	<20070102212701.4b4535cf@localhost.localdomain>
	<459ACE9C.7020107@pobox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1192
Lines: 30

> > We use BAR5 on two devices in legacy mode. Both of those reserve all the
> > other resources.
> 
> Translation:  You want to hand-wave away an obvious regression that YOU 
> have created with your fix-to-a-fix.

It's not regressing anything.

> Why INTRODUCE these 2.6.20 Alan-isms, if they are going away in 2.6.21?

To fix the problem I introduced ? and because that patch to do so is
trivial and easy to test and verify. 

> * Prior to your patch, ata_piix in legacy mode calls 
> pci_request_regions() to intentionally reserve ALL regions on the PCI 
> device.

Actually it didn't reserve BAR1 and BAR3 in legacy mode precisely because
of the PCI resource mismanagement in the old tree. So you take your pick.
BAR1 and BAR3 were used on all devices and not reserved, BAR5 is used on
two. Neither case is actually a problem in the current tree and driver
set. Both will be fixed when the combined mode junk gets fired into
hyperspace.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/