Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp170885pxb; Wed, 27 Oct 2021 00:20:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYuj6u90nJ0CouXqsALNfMFrRVXcj9fWz3VM9r1unLTGD8pAhr1LLNwnxp3ZKGkzOSlFoZ X-Received: by 2002:a17:90b:1e4b:: with SMTP id pi11mr4010512pjb.179.1635319236270; Wed, 27 Oct 2021 00:20:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635319236; cv=none; d=google.com; s=arc-20160816; b=ASwu0xTGKo/NhDldpZCBnUfKKp/z+IOaizpZZSpRBZU3NOhmi1E5+zlyL2ZyYGRTqP Khx64p5p8rW96FJg0cB+l4jmmb5jefIbVbnoL0QTy+zADuUskkoQnnZYjLh5xFpH0l7y 7Eh6ZpRTR2zPips3M6eOrxRGLVzCP58lxNdDOV15bgOIpAYo+hRQAbXdMoB/+PdqWjEd lW48BAeK7iZxfT2aXDB9LQLeFyxkG7kN80Rcg0AIIILNF4sxFqCBJusVHO7CFvNpRVW7 gtKHeC7CyWNfITByLK3njBa7K1b8O3r9p+FJXIxDm5xDmMov8inmvFuNF9l13VkdEQJa /fQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=yYi76T57NpvL5/nXu1Mhl1GRuk0vaCGFlGARnQ7DQ08=; b=eydaDwKBhZalnvau96Jmy2LxAOKGcB1FGejaCREnTGcD+uYngftrV42qeSasdOfU3u SdUp27aQX4RCG+1H5r3/sVJ240Mdp+65S9q7EnfEzceOtJpDHVwYP0oXpqwFi523l9dt uLIzBfyeKrHWFif6Dp6RY1rfjP5kS0iCeHwe4pghsBSisah8SddlrXCantAlTF8AeUQd EAkM8B4VTPS+EPWxEzL+fmjM1DCjfIUqpE83/3hpC50nAzpgbp/lthwnphjSv+csuq4m 8VE6yfrPbocHu4/vj49FuoekB9ic0FncE3bXgw8X19/0yy0ILX3crydilaEcNEIEhydi u8JQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ugLxngwV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e9si11197961pls.415.2021.10.27.00.20.00; Wed, 27 Oct 2021 00:20:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ugLxngwV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238473AbhJZTFA (ORCPT + 99 others); Tue, 26 Oct 2021 15:05:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:43230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235216AbhJZTE7 (ORCPT ); Tue, 26 Oct 2021 15:04:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 73D976103C; Tue, 26 Oct 2021 19:02:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635274955; bh=5i6nLNgMCoqcL3SxcdUlVgyXJBpR3WqcaSdO2QGRI3U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ugLxngwVJuogTj7LaSS08D2iHidf1hIdLCR25TgHRDdSi7klTXn3bVWvoKMWNmwxU DneTpPMmo4z56euWMU0eex9GW0oq3qV9jjRBw7r+OvWMaAgi8Qxh5dv7hgHKuXxNZo VYpfbq5/iNYuxpPYG6DSniWYtLNXpfUnT02iA6aoyyTHlZu7P1wLu1IKkUklWVObAZ /j//RLw8N6JcoX87bZfC7ZNM42wqVHX+/t3PZnTAVl1kYUOmgjkdqr9CLo1FV/I7sI cmZlib592N1Se/aZwZauD0jIyuwiQwbyzMKDdMk0QJanuZxnb2LxK3e/wEsbysIGHM 2AZ3jz1NWnQdw== Date: Tue, 26 Oct 2021 12:02:34 -0700 From: Jakub Kicinski To: Leon Romanovsky Cc: Ido Schimmel , "David S . Miller" , Ido Schimmel , Jiri Pirko , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, syzbot+93d5accfaefceedf43c1@syzkaller.appspotmail.com Subject: Re: [PATCH net-next] netdevsim: Register and unregister devlink traps on probe/remove device Message-ID: <20211026120234.3408fbcc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <725e121f05362da4328dda08d5814211a0725dac.1635064599.git.leonro@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Oct 2021 19:14:58 +0300 Leon Romanovsky wrote: > > By now I have spent more time arguing with you than you spent testing > > your patches and it's clear this discussion is not going anywhere. > > > > Are you going to send a revert or I will? This is the fourth time I'm > > asking you. > > I understand your temptation to send revert, at the end it is the > easiest solution. However, I prefer to finish this discussion with > decision on how the end result in mlxsw will look like. > > Let's hear Jiri and Jakub before we are rushing to revert something that > is correct in my opinion. We have whole week till merge window, and > revert takes less than 5 minutes, so no need to rush and do it before > direction is clear. Having drivers in a broken state will not be conducive to calm discussions. Let's do a quick revert and unbreak the selftests. Speaking under correction, but the model of operation where we merge patches rather quickly necessarily must also mean we are quick to revert changes which broke stuff if the fix is not immediately obvious or disputed.