Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 26 Oct 2021 22:33:17 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc:     Linux ACPI <linux-acpi@vger.kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v1 0/2] ACPI: scan: Honor certain device identification
 rules
Message-ID: <YXhX/cTjH/H9UOnQ@smile.fi.intel.com>
References: <11860508.O9o76ZdvQC@kreacher>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <11860508.O9o76ZdvQC@kreacher>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Oct 26, 2021 at 08:51:49PM +0200, Rafael J. Wysocki wrote:
> Hi All,
> 
> There are some rules in the ACPI spec regarding which device identification
> objects can be used together etc., but they are not followed by the kernel
> code.
> 
> This series modifies the code to follow the spec more closely (see patch
> changelogs for details).

I understand the motivation, but afraid about consequences on the OEM cheap
devices that are not always follow letter of the specification.

As per Intel platforms I would look into Baytrail / Cherrytrail devices for
the past (I think Hans may help here a lot) and into Elkhart Lake in the
present (for the letter I mostly refer to CSRT + DSDT cooperation to get
GP DMA devices enumerated, so I _hope_ DSDT shouldn't have _ADR and _HID
together).

Hence, from the code perspective
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

From the practice I would wait for some tests. I will try to find any new
information about latest firmware tables on Elkhart Lake machines.

-- 
With Best Regards,
Andy Shevchenko