Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp334109pxb;
        Wed, 27 Oct 2021 03:57:33 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJy+gZ9OOZlOIs/v/8yB0P7dNtvCQzTesKCTOH/9s4Q8YflDxq0ETAtRjRmiq0aGRJpf4rm3
X-Received: by 2002:a63:7051:: with SMTP id a17mr21186243pgn.290.1635332252911;
        Wed, 27 Oct 2021 03:57:32 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1635332252; cv=none;
        d=google.com; s=arc-20160816;
        b=GyFNlP4TbIQ0WpypO7PHRcNvNXLMoWjjyR7noRuLW1dvFMVU1hBOOmCiL+ogKZX0k1
         cRvEWnND5hkvUmwmcxi/NJ2Fs9bYlqfC2+9Gxj1gM7K4Je5rhjaSf6h2GEK+Q0hkPZ6Y
         i7PyjwMWweRP7yMp91LESIc3nkNEnR4UE7gdllm934csKlnp6O/v4RZlS8HU5pxu7Z0F
         RjwAnZjXUH4kv7dxfOYGHaJQMVuS+SatagYoY5ERoUE672DZpCqDEEnh2T1b4CkqDF0k
         tfYMt8CFQVZ8ich57yDnIbrIFm2asuLjdmJ/LrppidVdRMNM6fefeB+fAFOL+YbMiHgG
         Yjfw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=+jmG9XO6hSfOulSZuaNDujGZZVWsPUvr+tpEmoemAp0=;
        b=OJmMJ/GurQZcIR59yx+xVAFtfkwm0CjGMAtRz0dyos5DKDNvQPI9aK7RaQyjvVxhLP
         R7utDZ6DVvjeiAKk55CAqvCk2bi8zrL2tHzxLveADgOhXr1UoT6K+2veDcplv9EFFTkC
         Wbja0Sp3yLvVK7HzAavfYPNB8elgap5xJfPnvQuMVgMVLv3kAHsw7DMNTkSsBEpWa9HV
         dlWemrH+yNfywKZ4m4Qw4r0kdIx0V7h8vKT41NlWZmKFCLLuWXJgw9WYgsV/i8k9IffE
         wWC/zPIkDD+X55YTJlVo+eN+GKYryVuuKsGL6n4uSsYG1dvtygI2vFO+WvDxwghNcNl1
         fBsA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=umfN9I7g;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id u190si16064621pgd.420.2021.10.27.03.57.18;
        Wed, 27 Oct 2021 03:57:32 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=umfN9I7g;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S239453AbhJZVPb (ORCPT <rfc822;sduhuangshuai@gmail.com>
        + 99 others); Tue, 26 Oct 2021 17:15:31 -0400
Received: from mail.kernel.org ([198.145.29.99]:49152 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S239448AbhJZVPa (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 26 Oct 2021 17:15:30 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 57D2460F6F;
        Tue, 26 Oct 2021 21:13:06 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1635282786;
        bh=+jmG9XO6hSfOulSZuaNDujGZZVWsPUvr+tpEmoemAp0=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=umfN9I7gEdn7q4XmNQOJ6M4RL8mqWpFGCDzmu/KLfvrGl079g9YLXS0y0dszJtoXl
         3tV+/iiop2fp7TpzGdpzld6fkUXOoxusKcy/SpDWHpmE+OzFkfx+qsHXKo0v/R6xH+
         GB/72UuW/wakivWzs5/zWl3hkbKMcXIXC3+OZ+9mH5kxFK6yDvlc0DsoDa8tZyQ+E5
         aCIoOTwtSXH8ilqR9qoUEgbXx0/7O/jtytNhw1FRJ8EIz5wQOAAC5JF3JPjVtO0iEr
         oKgFVzAGnMC7R7A7Ya2sqRmN0guscK0TsHZFBNevXcJHllR9GAnc1/uW5u5odUUs3q
         KEsQ2MkKVTUPA==
Date:   Tue, 26 Oct 2021 14:13:05 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Rakesh Babu <rsaladi2@marvell.com>
Cc:     <sgoutham@marvell.com>, <gakula@marvell.com>,
        <sbhatta@marvell.com>, <hkelam@marvell.com>, <davem@davemloft.net>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [net-next PATCH v2 1/3] octeontx2-af: debugfs: Minor changes.
Message-ID: <20211026141305.0739a59e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20211026121814.27036-2-rsaladi2@marvell.com>
References: <20211026121814.27036-1-rsaladi2@marvell.com>
        <20211026121814.27036-2-rsaladi2@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 26 Oct 2021 17:48:12 +0530 Rakesh Babu wrote:
> This patch also has the null pointer check in rvu_nix.c file.

You need to explain why, and why is that not a fix, just a cosmetic
change. Same for the ret < 0 check. And please break those out to
separate patches.