Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <46ffc66d-26da-7ac5-0f3f-e86594d2b60c@kernel.org>
Date:   Tue, 26 Oct 2021 21:50:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH V5 10/20] rtla/osnoise: Add osnoise top mode
Content-Language: en-US
To:     Tao Zhou <tao.zhou@linux.dev>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>,
        Tom Zanussi <zanussi@kernel.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Clark Williams <williams@redhat.com>,
        John Kacur <jkacur@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        linux-rt-users@vger.kernel.org, linux-trace-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <cover.1635181938.git.bristot@kernel.org>
 <6252864d71e1864f60c25c716bc773861929e3fb.1635181938.git.bristot@kernel.org>
 <YXgtnEPcT8vay1wI@geo.homenetwork>
From:   Daniel Bristot de Oliveira <bristot@kernel.org>
In-Reply-To: <YXgtnEPcT8vay1wI@geo.homenetwork>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/26/21 18:32, Tao Zhou wrote:
>> +	if (params->stop_us)
>> +		osnoise_set_stop_us(tool->context, params->stop_us);
> osnoise_set_stop_us() also need to check return value feels by me.
> 
>> +
>> +	if (params->stop_total_us)
>> +		osnoise_set_stop_total_us(tool->context, params->stop_total_us);
> The same here. Also need to check the return value.
> 
> PATCH 10 also has these two places(call the two functions) that not check
> the return value.
> 
> Or I am wrong.


You are right, reviewing that.

Thanks!
-- Daniel

> 
> 
> Thanks,
> Tao
>