Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp367298pxb; Wed, 27 Oct 2021 04:36:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4pgoy8ko0xvc/Hmt0a6hxnye7yvqgC6fwBoWuz+tkVfquK5XGzKqE0II/YyLQFqszlnig X-Received: by 2002:a63:7247:: with SMTP id c7mr23456741pgn.365.1635334563745; Wed, 27 Oct 2021 04:36:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635334563; cv=none; d=google.com; s=arc-20160816; b=CFzs+7rcb6CFc+TUsmcqzKUNA3RUFN3SCD/va0fm41s9nFmNFNH1LSWWbtBVjdjkMj v2qPQqUZ19ypcLfqxmL6iDHPM3ItB8NIGH+bLdYEvCUYjX5KPLWSImWTWshoBiSJX+H7 Mz2/ZjIeJQzO6FcwacB5HbLmV2tRAzmn1eXMFfCScWV7sdwWgNsjlwNbutDre0zOOqv5 lsEhjseoGavz02ctZqOyuW8cC3yNt+tsENPVqtgduo19FfdvxyiWV3veIg8QRdW/DLxi d+HGCD7OLrObuY4YNVitXHSto1Q/TGvVqkLY7c0kLsWg9awD5TjAkN9osoDd9qQqHSyw EG8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=yaCb0u7kHGCkaTa52y1zZ37iQuNRyZWxVB8xcOMfBL0=; b=veNNZq35X3SGaxsOHtjKIu7z6ZjxmR2vS16r8NX5YZyIzNrcAIigIp8R7fh6bBp1w9 Kv8kOZm5z762SyQrvSn9KzDxndZFTD3IW/QlcdlNRqZL7fxbcLB5HJyL9nA+HTszwu7X 0jnU4utkbovfczSf76kNnHDmrAXWVgb/aGx2U44z2Bs4ApPlKaufhkcHcI+8wp1NLFNr whikPbp1+PT+YbBqpFQoSNOjo6P4zBr+6wsGz8a0oLGkt5z8NW+tuuz/P71IifoLuPmm p0GUmjaijkwzzQX/glTrh57qAhwEeBRNiluurYuXI+VR3DuD9gjvOOQPdDIs/9s4LOoi L+dA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=znQj4CxL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k184si5094261pgd.436.2021.10.27.04.35.19; Wed, 27 Oct 2021 04:36:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=znQj4CxL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237654AbhJZWDW (ORCPT + 99 others); Tue, 26 Oct 2021 18:03:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236027AbhJZWDV (ORCPT ); Tue, 26 Oct 2021 18:03:21 -0400 Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A780C061570 for ; Tue, 26 Oct 2021 15:00:57 -0700 (PDT) Received: by mail-il1-x134.google.com with SMTP id j10so851009ilu.2 for ; Tue, 26 Oct 2021 15:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:cc:in-reply-to:references:subject:message-id:date :mime-version:content-transfer-encoding; bh=yaCb0u7kHGCkaTa52y1zZ37iQuNRyZWxVB8xcOMfBL0=; b=znQj4CxLFrfRLotnrL7NrFjxFc5hIT+jpYYUUKtsxtUv8ndD8HI7UlgkpUpwOmGMo8 leg9M4M742eCheZiZbLnFQlThSOgBU5ZUordW6tLqRYHy3f2dPGb7nRkvme4ML29wC/k Plvhi7nAYunGGqHWnAw7LClZbTirOL8gtXehQQQ6bQopja4wwkd9Tqmdc3gByWdI6XqR FQpfa8MoW9NFW0RqwAyYT98p7oYcWUPbMSAMrkQis/8n4YLbM9uyjzoLTP/ShsZydmMx OgKIj8zxGm2u5cdaFmEbcBUvRAFbT4TkIC+CvUhViTmoZrdcaSvdUkXnAp149MlD/Zn/ 4LXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=yaCb0u7kHGCkaTa52y1zZ37iQuNRyZWxVB8xcOMfBL0=; b=m1yiI45rAIJQOVb4AtASSDNRjkTDuciSGkX6AE54knkS5eBwFpCcqXqUjEFqZmUu+Z ztji5XBsohNrgjTNZMOZQGfk8LhSReBnsJyy9p6eis3HPe3FOlQ28hbJ+S4iRtxb0Q4B EbuoDzGjnj61JOu8Oq1+MGyJpvt8plwL+Iim2mlcibEYCMb47ZSOpc86V6WIliEWgftp FGz1O5rCNv/IolTd7o4HhGtpuB4h/sEI4tjUOSIgwlArXAVVHgE0uBOJLSEPcKgcMj0v wbXdT/Ya8xAzMwhXzugl3BmopOKKn4faGKOSHZb+O3ahl7glS3GRc2iMLddD3Bqn8D4u 5mTw== X-Gm-Message-State: AOAM531ixk5zeOz2G5+KAnsEEot9M+w9TawqUyAc6l1rmWfpalEwLgsG ObC5QqmE+TEX1Vx7doAyz/n4ZbRC0JylCQ== X-Received: by 2002:a05:6e02:188e:: with SMTP id o14mr10658855ilu.114.1635285656867; Tue, 26 Oct 2021 15:00:56 -0700 (PDT) Received: from [127.0.1.1] ([66.219.217.159]) by smtp.gmail.com with ESMTPSA id d10sm2191871iog.25.2021.10.26.15.00.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 15:00:56 -0700 (PDT) From: Jens Axboe To: Naohiro Aota Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Niklas Cassel In-Reply-To: <20211026165127.4151055-1-naohiro.aota@wdc.com> References: <20211026165127.4151055-1-naohiro.aota@wdc.com> Subject: Re: [PATCH v2] block: schedule queue restart after BLK_STS_ZONE_RESOURCE Message-Id: <163528565626.259196.4840508461738349119.b4-ty@kernel.dk> Date: Tue, 26 Oct 2021 16:00:56 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Oct 2021 01:51:27 +0900, Naohiro Aota wrote: > When dispatching a zone append write request to a SCSI zoned block device, > if the target zone of the request is already locked, the device driver will > return BLK_STS_ZONE_RESOURCE and the request will be pushed back to the > hctx dipatch queue. The queue will be marked as RESTART in > dd_finish_request() and restarted in __blk_mq_free_request(). However, this > restart applies to the hctx of the completed request. If the requeued > request is on a different hctx, dispatch will no be retried until another > request is submitted or the next periodic queue run triggers, leading to up > to 30 seconds latency for the requeued request. > > [...] Applied, thanks! [1/1] block: schedule queue restart after BLK_STS_ZONE_RESOURCE commit: 9586e67b911c95ba158fcc247b230e9c2d718623 Best regards, -- Jens Axboe