Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc:     Matthew Wilcox <willy@infradead.org>,
        Muchun Song <songmuchun@bytedance.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Pasha Tatashin <pasha.tatashin@soleen.com>
Subject: [PATCH] hugetlb: remove unnecessary set_page_count in prep_compound_gigantic_page
Date:   Tue, 26 Oct 2021 15:06:35 -0700
Message-Id: <20211026220635.35187-1-mike.kravetz@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?NUbMs2xwtUyWrZv9aBfN/NORurXXFLDxDDl27HDMYEVm2L4+sXi5y1t7brvL?=
 =?us-ascii?Q?4MpLeFfDOLZMO784Rhj1PHiKcU4jvmbSXGGr6vIXX95+ldeMHSwbEuPffH3f?=
 =?us-ascii?Q?s9lmBDZwNNcoTCB0u3+pOpRPoVNtgLmx6O2rQihdOM9HBRcUFZBcLkS6dfoi?=
 =?us-ascii?Q?DHlpckGNAWHDLA9DOBsZt0EV7PFhVa1xtSKM8IqUNAPw19vTmxC3pkuYCOau?=
 =?us-ascii?Q?UVUxM8G4LlICtmB2VvWY4pZyRTJayvVwzoCvIr7ZsUZq3TPk/L0ChOsRemTq?=
 =?us-ascii?Q?Qa8UhXdtOJnR+H0SyDqvdV7XSgEukbM/68ijkbZ/taj4uup2pz+sNMy1phtj?=
 =?us-ascii?Q?8eebLTNgw38dAiIieTKw9yxyRp+DpTYDynNReJcgUyTwsEsjJeXYiXF/SgbK?=
 =?us-ascii?Q?fADYFp9rz9FWwygrLmA1utEPRyruTmReoX5R/gl6hhejWq8Uam6sk73sMFzp?=
 =?us-ascii?Q?UHEb5t2RRRZCCr1tvcMrMm2e7vCoYPS4N2P6DkZb/DV3ugKraq8qVdHR6n8C?=
 =?us-ascii?Q?moXa68wUuP4eNaFXFpnHFp0dMPIlB96lm/KTwDkqlT1KbmFzBg2eJCLvePKJ?=
 =?us-ascii?Q?yoO8nqpqxhZajJrHaB2zewDC7LIyqeucA0HYwqJmRF9/yNv+PyO/uvIKHPqr?=
 =?us-ascii?Q?o8LMHfZCVTi6gVM1haZ83gswLrhx784/RmoMZ4F7zOU2NIkZsVNNQ9PgsAN9?=
 =?us-ascii?Q?wcqg2xpRuyfotck4YNc+JZoums37kNAUdl6DbogBZv+8dS6fGRibLR1jq5gu?=
 =?us-ascii?Q?/btH0iT93pBdN63v7tAPSujsPeE95SrzUBko+OaLBtW9VrKuNuZ41gMX0Nhp?=
 =?us-ascii?Q?o4U/unBxhjTNr/80QYK/Ezl03OERvCCL5jBSs2BEw/KCPGeX5B06SbOw0R5Q?=
 =?us-ascii?Q?vLT9fiDMwMOlhPA2DdlQzWfQjvR2TQwhZWBGgaWrJKdiBd17xPloUPzv/tXB?=
 =?us-ascii?Q?ImMKkg8GvMr8KteZyE3B4cY6Dbrk56BtZwWAeVZgdMElGqqBT0PvUPl7eqcQ?=
 =?us-ascii?Q?9sCw3v1gBF901ZHKmYhQ6a7qGsMFJJhY/p8q3SDRooR1PHdlgtzN2rMwwjxs?=
 =?us-ascii?Q?gBNA15uZKV563Ge4pYagF2Y1huIHtPKKKgK4fGaRb1gV3crQWu5731eKi/dw?=
 =?us-ascii?Q?/82BXBaxx8dPjl7J6l8DyFf1qkhhCwKqjuXP8nxynshTxYJYg/OUQmN337h9?=
 =?us-ascii?Q?bwdJ1YfvJ/dmfzxNIgMgeIdwpRuSgZvyVGdPivt6ckaZ57YtUjxPDcLfHdYi?=
 =?us-ascii?Q?h8c++/a9Hhk5fFm2Rk64XnSv/onrG9de0L7Li6jccV7SmeQxM06yYLBnYJ6x?=
 =?us-ascii?Q?aU9P9hkTYIOYk7Afu7I8DFa7H7cEczAs0fVwxpO/u0hq9TiEtaCzehuJk8Ka?=
 =?us-ascii?Q?uYFoSA8zoz+JbybYVqsDCFqiJg8tNZUGTzCvdtZ/BubWvoxH+VdURYhZQlu+?=
 =?us-ascii?Q?on/P9Ptl4HJ8fywvvwWLluWemUX4MLNruadLwlybArni7uZNXvMxU1qUThXD?=
 =?us-ascii?Q?t9op+ByjGz+L8sDCvOa7NsKWqhzCZcQH3NECmgNrb5OBvAnh6Nj6rXukRl03?=
 =?us-ascii?Q?7h98fmEk63K/BzKheP2Eef4L0TqpBf80urEdWhfPbhOEcoI8ce3RBGVlR/s+?=
 =?us-ascii?Q?FuaMGeoeAXjjXwMKB/eCxHE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 95d8d82f-4403-49fd-6066-08d998cce975
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2021 22:06:50.9370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Oo7NO9gVRo0nHgRAJD5x8e6B9zTwS6Opnm2eogoh3usI6qui03shoZAfjGAVM8wDQwwMf45fCUMzdBf/sYpc9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2614
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10149 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0
 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110260120
X-Proofpoint-GUID: H-6fUObRQT237FW62UftXAz4tetqxZ63
X-Proofpoint-ORIG-GUID: H-6fUObRQT237FW62UftXAz4tetqxZ63
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

In commit 7118fc2906e29 ("hugetlb: address ref count racing in
prep_compound_gigantic_page"), page_ref_freeze is used to atomically
zero the ref count of tail pages iff they are 1.  The unconditional
call to set_page_count(0) was left in the code.  This call is after
page_ref_freeze so it is really a noop.

Remove redundant and unnecessary set_page_count call.

Fixes: 7118fc2906e29 ("hugetlb: address ref count racing in prep_compound_gigantic_page")
Suggested-by: Pasha Tatashin <pasha.tatashin@soleen.com>
Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
---
 mm/hugetlb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 906fe8a3b93d..88047a367080 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -1795,7 +1795,6 @@ static bool __prep_compound_gigantic_page(struct page *page, unsigned int order,
 		} else {
 			VM_BUG_ON_PAGE(page_count(p), p);
 		}
-		set_page_count(p, 0);
 		set_compound_head(p, page);
 	}
 	atomic_set(compound_mapcount_ptr(page), -1);
-- 
2.31.1