Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Richard Zhu <hongxing.zhu@nxp.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
CC:     "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling
 unbalance when link never came up
Thread-Topic: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling
 unbalance when link never came up
Thread-Index: AQHXwY4ue+QOjCGA8ESB+dHo+5+VOqvUZ7iAgAAAjYCABY9dgIAEuu9QgAbaNACAAJLXMA==
Date:   Wed, 27 Oct 2021 01:29:23 +0000
Message-ID: <AS8PR04MB8676FB7F7B4F8C1E43C79DC58C859@AS8PR04MB8676.eurprd04.prod.outlook.com>
References: <AS8PR04MB867697359A6D51903D0098308C809@AS8PR04MB8676.eurprd04.prod.outlook.com>
 <20211026163844.GA145569@bhelgaas>
In-Reply-To: <20211026163844.GA145569@bhelgaas>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?V2lMRW8BliXv/5dYLJNxxk/Z5enhrHolVUdgTDEQzYoAALiGdkubARHvSdJr?=
 =?us-ascii?Q?k3UDQlBxzhuyhz3ryXgBnjys5js30kTpzTC/aNflDtiQ8E3RmxlJgnPSeEiW?=
 =?us-ascii?Q?/WEPWV87jWy4DHz8a5dRCpEr4jtndE6ZYSvRo3oEhgNf3YA+qWFtJKh5srzh?=
 =?us-ascii?Q?aFiHUCOhEwhbgI/vifivXp3eif/MjS/yYas3/mGn6kH0BmjQ7WZnia24bZfy?=
 =?us-ascii?Q?cq+4rLNKElTkKVoOvyV/K9gfooA1vx3lCy+1dl+K7gFPHXc5GJwCKScrSh/t?=
 =?us-ascii?Q?XOBANIvfbjXlfkH96VxifuN11270UkOMAjVlM2qzHPIXi8Bjfpz2bZSAi0vM?=
 =?us-ascii?Q?BFsmxxa6vO3NzzbD+v/j2eUK/1CxIyzK2hGz7w7j0yEp+wILcqMnu/NTkSlj?=
 =?us-ascii?Q?bLOnqZc0kyJhTkrcpPr/K973bNifE7kevxxbAvrRmYh+NFCdl3Ash20H6zmD?=
 =?us-ascii?Q?EIEdfUITLwxcGoByp+D078RKbtsZrmBVhzxjQQx8aAi5exyN3//tWCTfbH3Z?=
 =?us-ascii?Q?/E/lC3tqejZ/uLwBJ6XRd2LKsFFYgsjJPrwBBsm6h/Z8jU7GKLDhXnILRd06?=
 =?us-ascii?Q?ssplN1MyhWmr1vU8eilMFd7hxJXXcQk1XtVDdqk2pk1JJNfFeM/daxar7V3r?=
 =?us-ascii?Q?5bixP1mrszzP/eInvFTl4hPfK3CuyEnD3XLNI24dLCmVD6A+cGkg1PGSfJG1?=
 =?us-ascii?Q?4iOCUkw61gg6h5/KVbE8AYiIgu8anJvKKfENgNCraYvzVDCJr/R8x5i9QzqZ?=
 =?us-ascii?Q?T06Bd0GS/7Xfjo2GDNzLUa8O/BRHi5EgSq98OWUXN135eSW0VZG/tBUwRHCY?=
 =?us-ascii?Q?ICHpAMm1YUaK2JSpzdo2YoMiBgb4P7YaTI55agm8e5d2zmbDmz08LMS1E0NH?=
 =?us-ascii?Q?JIyKTjO76LMWEivVvsbzQv84faZzJxh5Fzx7noVVy0q9ypW07P/KrSRTn9ac?=
 =?us-ascii?Q?sQeJOoLQM42Rl7cePIPWLRcRRFHvPixKI4WWtLOJh3buOCPp04YIA63qCKQk?=
 =?us-ascii?Q?CNuI6jyzhCo4nZWkNKFUNueK6jCOvr4G4RvWiGwJzx1gDafKDe/Gy5jRIWdc?=
 =?us-ascii?Q?etiQhRz3cjpAHeO2T43hFygx0exb2qnK3g/ku/qJGZKTg5tJsmW/qyjWgNT/?=
 =?us-ascii?Q?rrnBCFXalWUvFDTVD9XBMdlAjqBr48kyo823y2lpy7BiRmJr9sK9nhqg43n7?=
 =?us-ascii?Q?PHuyz8Ugqme+h59jcSply42eYFatxMj1A58cRcDaOuxVLG0csrmdDWU5Xde3?=
 =?us-ascii?Q?4bzgvQbyCIzCUnAfaGzkkR74LKwHUW+Ip/CvskKoO/eYGD1ZpszmcrPo9dfc?=
 =?us-ascii?Q?0MTAWEOW5dPwL3szhJqeXYdXPi8hTEhDGK2SF9+7O1M2x/dOu6fxMcUliklm?=
 =?us-ascii?Q?jFpLFZbBCY2xSMwEfVlKnnnpeQvaeL9n1LzwiUh2IGbxcq4QrrLKOZbvVOAR?=
 =?us-ascii?Q?1pQIooVVmROaxDzlK6h3Vje8QiSfwoiZKxHZBVRsRl+up7ngtyZgTqLDHe48?=
 =?us-ascii?Q?WqgH8rGz5F6idMgTYJCieC6gDjObygbUH+HtoXonX8vslFUaap5C7yoJdgsV?=
 =?us-ascii?Q?hea/iAdhCAZoESFAj5AA/OswiY4nIQU0IyjhxqKSgEyy26Pigyb4uoti0gs4?=
 =?us-ascii?Q?+w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8676.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a1df0a0-66e5-48a1-7d86-08d998e93542
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 01:29:23.7031
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: U+JpOV6huCuaebOUiVP38QSPXDVgqRdAz3ibmskUNbfPvgDNjXmhsCbXI+9fPH3jedVjdNRp/8Pwh2+JFobmiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8962
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Bjorn Helgaas <helgaas@kernel.org>
> Sent: Wednesday, October 27, 2021 12:39 AM
> To: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: l.stach@pengutronix.de; bhelgaas@google.com;
> lorenzo.pieralisi@arm.com; linux-pci@vger.kernel.org; dl-linux-imx
> <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; kernel@pengutronix.de
> Subject: Re: [RESEND v2 4/5] PCI: imx6: Fix the clock reference handling
> unbalance when link never came up
>=20
> On Fri, Oct 22, 2021 at 08:02:17AM +0000, Richard Zhu wrote:
> > <snipped ...>
> > > >
> > > > > > -static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie)=
 -{
> > > > > > -	clk_disable_unprepare(imx6_pcie->pcie);
> > > > > > -	clk_disable_unprepare(imx6_pcie->pcie_phy);
> > > > > > -	clk_disable_unprepare(imx6_pcie->pcie_bus);
> > > > > > -
> > > > > > -	switch (imx6_pcie->drvdata->variant) {
> > > > > > -	case IMX6SX:
> > > > > > -		clk_disable_unprepare(imx6_pcie->pcie_inbound_axi);
> > > > > > -		break;
> > > > > > -	case IMX7D:
> > > > > > -		regmap_update_bits(imx6_pcie->iomuxc_gpr,
> > > IOMUXC_GPR12,
> > > > > > -				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL,
> > > > > > -				   IMX7D_GPR12_PCIE_PHY_REFCLK_SEL);
> > > > > > -		break;
> > > > > > -	case IMX8MQ:
> > > > > > -		clk_disable_unprepare(imx6_pcie->pcie_aux);
> > > > > > -		break;
> > > > > > -	default:
> > > > > > -		break;
> > > >
> > > > While you're at it, this "default: break;" thing is pointless.
> > > > Normally it's better to just *move* something without changing it
> > > > at all, but this is such a simple thing I think you could drop
> > > > this at the same time as the move.
> > > >
> > > [Richard Zhu] Okay, got that. Would remove the "default:break" later.
> Thanks.
> > [Richard Zhu] I figure out that the default:break is required by
> > IMX6Q/IMX6QP.  So I just don't drop them in v3 patch-set.
>=20
> That makes no sense.  The code is:
>=20
>   +static void imx6_pcie_clk_disable(struct imx6_pcie *imx6_pcie)
>   +{
>   +       clk_disable_unprepare(imx6_pcie->pcie);
>   +       clk_disable_unprepare(imx6_pcie->pcie_phy);
>   +       clk_disable_unprepare(imx6_pcie->pcie_bus);
>   +
>   +       switch (imx6_pcie->drvdata->variant) {
>   +       case IMX6SX:
>   +               clk_disable_unprepare(imx6_pcie->pcie_inbound_axi);
>   +               break;
>   +       case IMX7D:
>   +               regmap_update_bits(imx6_pcie->iomuxc_gpr,
> IOMUXC_GPR12,
>   +
> IMX7D_GPR12_PCIE_PHY_REFCLK_SEL,
>   +
> IMX7D_GPR12_PCIE_PHY_REFCLK_SEL);
>   +               break;
>   +       case IMX8MQ:
>   +               clk_disable_unprepare(imx6_pcie->pcie_aux);
>   +               break;
>   +       default:
>   +               break;
>   +       }
>   +}
>=20
> Why do you think it makes a difference to remove the
> "default: break;"?  There is no executable code after it.
> I don't see how IMX6Q/IMX6QP could depend on the default case.
>=20
> BTW, I feel like a broken record, but your v3 posting still has inconsist=
ent
> subject line capitalization:
>=20
>   PCI: imx6: move the clock disable function to a proper place
>   PCI: dwc: add a new callback host exit function into host ops
>=20
> It would be nice if they were consistent and contained more specific
> information, e.g.,
>=20
>   PCI: imx6: Move imx6_pcie_clk_disable() earlier
>   PCI: dwc: Add dw_pcie_host_ops.host_exit() callback
[Richard Zhu] Got that, would change to be consistent and more specific inf=
ormation. Thanks a lot.

BR
Richard
>=20
> Bjorn