Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp567722pxb; Wed, 27 Oct 2021 08:15:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkQ5goCWk22IZ8uE5jYGSBRwiK93HgfnLiezyROUz7oDkDH74oLfCvTpMLSjHrsw3+KfHf X-Received: by 2002:a17:902:be0f:b0:13a:19b6:6870 with SMTP id r15-20020a170902be0f00b0013a19b66870mr29284930pls.64.1635347703140; Wed, 27 Oct 2021 08:15:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635347703; cv=none; d=google.com; s=arc-20160816; b=zraaQzNDNONC5EcoHZUijaKlFsyTfpv5tvx7ZWbv4iZ0zAgmiBR3JLQMDAbCFHV0dN PogHmDHcIWuOg2zn9DNQsvlIA631zABU6fyroXZjbouYJ9AiRKqxX09v2/awpHFqPr1f 8b80R2uKNNYCqhBb1SRI1trE1l4ZCevWi7hNcNviOMz5HFW9pLVvQGNf3paGwuekL1E9 BRAo+G3bHbawmZAMo9Cq+DPwHPaz3jLaiDYft2lswwYESqpIWG/Gr4b9WLfNgMxEQPZL ZoYK26CUlIhAcjOqsKjpisOFo3lxiuYEiDxqlsmF9TxM7Z6N73LZriT/uFytf8JnWIQk f5hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=mRZIULQTVpfWrdp8Uq4dI5NvJfRTMnh/7wjuYGzhzms=; b=i2I1NYd7/YULjqt56EGY3Jf3Crr9q+LbhS9MounZtiasViKo5REwcZvOdYZdJPuvmd 3fSMz7ZLCvauIFQNwqaBz3zEmK407nndeWnim7l4uGDXCmkA2wbMhbk/SnHyOwl2jP27 Z2LnvXLXW4PyZG9WTwo1DKQsCjKQQVv2EvBgkbwZRshsECFFkkdaF9UcZSmmhPdV3dnt 4rrsVBnuoTKHSaCK0D4WYuPSaABRkmP2EWiEzLJr0Ygk7dFjvxT/p38SVl9yPANA68Bi PqB5ieDEL6AhDpuy3ZL/fGyp0+kkH2+7SKR9lvqE6rRObSl5dYqeB5iXgMmjlTLT+rHR AE5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=C1nH96Ez; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k4si160774plk.419.2021.10.27.08.14.35; Wed, 27 Oct 2021 08:15:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=C1nH96Ez; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237587AbhJ0Blh (ORCPT + 99 others); Tue, 26 Oct 2021 21:41:37 -0400 Received: from out0.migadu.com ([94.23.1.103]:48474 "EHLO out0.migadu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232003AbhJ0Blg (ORCPT ); Tue, 26 Oct 2021 21:41:36 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1635298750; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=mRZIULQTVpfWrdp8Uq4dI5NvJfRTMnh/7wjuYGzhzms=; b=C1nH96Ez3/9CFNNNB5mqCJCzMnqYk/kdCDE5BB8Uil0iy3AfHT639oQlCSU9xad99Nfqbs sFCGVrT8+JcwPnLdrW+3wX75W+EkGSXJEkOnkhAaGUys1FHKw/WrmTel7TwsMYlmAdVhS6 YvvjR7ULfPfaw4i6Ep1tqUImkykcZx8= From: Yajun Deng To: ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, kuba@kernel.org, hawk@kernel.org, john.fastabend@gmail.com Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Yajun Deng Subject: [PATCH net-next] xdp: Remove redundant warning Date: Wed, 27 Oct 2021 09:38:56 +0800 Message-Id: <20211027013856.1866-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: yajun.deng@linux.dev Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a warning in xdp_rxq_info_unreg_mem_model() when reg_state isn't equal to REG_STATE_REGISTERED, so the warning in xdp_rxq_info_unreg() is redundant. Signed-off-by: Yajun Deng --- net/core/xdp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/core/xdp.c b/net/core/xdp.c index cc92ccb38432..5ddc29f29bad 100644 --- a/net/core/xdp.c +++ b/net/core/xdp.c @@ -143,8 +143,6 @@ void xdp_rxq_info_unreg(struct xdp_rxq_info *xdp_rxq) if (xdp_rxq->reg_state == REG_STATE_UNUSED) return; - WARN(!(xdp_rxq->reg_state == REG_STATE_REGISTERED), "Driver BUG"); - xdp_rxq_info_unreg_mem_model(xdp_rxq); xdp_rxq->reg_state = REG_STATE_UNREGISTERED; -- 2.32.0