Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 27 Oct 2021 12:34:55 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Qian Cai <quic_qiancai@quicinc.com>
Cc:     Yury Norov <yury.norov@gmail.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bitmap: simplify GENMASK(size - 1, 0) lines
Message-ID: <YXkdP/Rr+m30Hh72@smile.fi.intel.com>
References: <20211026144108.35373-1-quic_qiancai@quicinc.com>
 <YXhOEEOSG+fgEy+t@yury-ThinkPad>
 <YXhVVvG9keoVWJyK@smile.fi.intel.com>
 <397751ea-536b-af3c-752d-c4b1045e6e56@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <397751ea-536b-af3c-752d-c4b1045e6e56@quicinc.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Oct 26, 2021 at 03:33:48PM -0400, Qian Cai wrote:
> On 10/26/21 3:21 PM, Andy Shevchenko wrote:
> > Can you explain to me how it is supposed to work?
> > 
> > For example,
> > 
> >     x = 0xaa55;
> >     size = 5;
> > 
> >     printf("%lu\n", find_first_bit(&x, size));
> > 
> > In the resulting code we will always have 5 as the result,
> > but is it correct one?
> 
> Sorry, my bad. GENMASK(size - 1, 0) would just become __GENMASK(size -
> 1, 0) instead of 0. Let me revisit it and run some tests first.

And we do not want to have __GENMASK() in the code.
Btw, I found one lurking around. Will fix it.

-- 
With Best Regards,
Andy Shevchenko