Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Schwab <schwab@linux-m68k.org>
To:     Alexandre Ghiti <alexandre.ghiti@canonical.com>
Cc:     Palmer Dabbelt <palmer@dabbelt.com>, alex@ghiti.fr,
        Paul Walmsley <paul.walmsley@sifive.com>,
        aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org, kernel-team@android.com,
        Palmer Dabbelt <palmerdabbelt@google.com>
Subject: Re: [PATCH] RISC-V: Make CONFIG_RELOCATABLE user selectable
References: <20211026212847.43108-1-palmer@dabbelt.com>
        <87mtmuaodc.fsf@igel.home>
        <CA+zEjCuRuKtZAhkS_RFyby6UhLvYmg=4BdnXEwUdaCdtbB7ZAA@mail.gmail.com>
Date:   Wed, 27 Oct 2021 11:45:27 +0200
In-Reply-To: <CA+zEjCuRuKtZAhkS_RFyby6UhLvYmg=4BdnXEwUdaCdtbB7ZAA@mail.gmail.com>
        (Alexandre Ghiti's message of "Wed, 27 Oct 2021 10:58:44 +0200")
Message-ID: <87ee86ajig.fsf@igel.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Okt 27 2021, Alexandre Ghiti wrote:

> On Wed, Oct 27, 2021 at 10:03 AM Andreas Schwab <schwab@linux-m68k.org> wrote:
>>
>> On Okt 26 2021, Palmer Dabbelt wrote:
>>
>> > +config RELOCATABLE
>> > +     bool "Build a relocatable kernel"
>> > +     depends on MMU && 64BIT && !XIP_KERNEL
>> > +     help
>> > +          This builds a kernel as a Position Independent Executable (PIE),
>> > +          which retains all relocation metadata required to relocate the
>> > +          kernel binary at runtime to a different virtual address than the
>> > +          address it was linked at.
>> > +          Since RISCV uses the RELA relocation format, this requires a
>> > +          relocation pass at runtime even if the kernel is loaded at the
>> > +          same address it was linked at.
>>
>> When in doubt, do what?
>
> Then do not enable.

Please add that to the help string.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."