Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 27 Oct 2021 13:52:11 +0200
From:   Michal Hocko <mhocko@suse.com>
To:     Zhaoyang Huang <huangzhaoyang@gmail.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        Zhaoyang Huang <zhaoyang.huang@unisoc.com>,
        "open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] mm: have kswapd only reclaiming use min protection
 on memcg
Message-ID: <YXk9a3X62vNTyvGE@dhcp22.suse.cz>
References: <1635318110-1905-1-git-send-email-huangzhaoyang@gmail.com>
 <YXj9w+8Bwlkz5PRy@dhcp22.suse.cz>
 <CAGWkznHVHVBrQEiO32p2uX_5BDUMc1fE64KuV34WJfpwC_23Pw@mail.gmail.com>
 <YXkNJjD4axYlmqQ5@dhcp22.suse.cz>
 <CAGWkznHrZ=Y3kG5j5aYdTV2294QGrQbM6251zcdGphzCGUP6dw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGWkznHrZ=Y3kG5j5aYdTV2294QGrQbM6251zcdGphzCGUP6dw@mail.gmail.com>
Precedence: bulk

On Wed 27-10-21 17:19:56, Zhaoyang Huang wrote:
> On Wed, Oct 27, 2021 at 4:26 PM Michal Hocko <mhocko@suse.com> wrote:
> >
> > On Wed 27-10-21 15:46:19, Zhaoyang Huang wrote:
> > > On Wed, Oct 27, 2021 at 3:20 PM Michal Hocko <mhocko@suse.com> wrote:
> > > >
> > > > On Wed 27-10-21 15:01:50, Huangzhaoyang wrote:
> > > > > From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> > > > >
> > > > > For the kswapd only reclaiming, there is no chance to try again on
> > > > > this group while direct reclaim has. fix it by judging gfp flag.
> > > >
> > > > There is no problem description (same as in your last submissions. Have
> > > > you looked at the patch submission documentation as recommended
> > > > previously?).
> > > >
> > > > Also this patch doesn't make any sense. Both direct reclaim and kswapd
> > > > use a gfp mask which contains __GFP_DIRECT_RECLAIM (see balance_pgdat
> > > > for the kswapd part)..
> > > ok, but how does the reclaiming try with memcg's min protection on the
> > > alloc without __GFP_DIRECT_RECLAIM?
> >
> > I do not follow. There is no need to protect memcg if the allocation
> > request doesn't have __GFP_DIRECT_RECLAIM because that would fail the
> > charge if a hard limit is reached, see try_charge_memcg and
> > gfpflags_allow_blocking check.
> >
> > Background reclaim, on the other hand never breaches reclaim protection.
> >
> > What is the actual problem you want to solve?
> Imagine there is an allocation with gfp_mask & ~GFP_DIRECT_RECLAIM and
> all processes are under cgroups. Kswapd is the only hope here which
> however has a low efficiency of get_scan_count. I would like to have
> kswapd work as direct reclaim in 2nd round which will have
> protection=memory.min.

Do you have an example where this would be a practical problem? Atomic
allocations should be rather rare.

-- 
Michal Hocko
SUSE Labs