Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <f9db2b8f-c4b7-95b3-856c-ebf5231d6bf8@oracle.com>
Date:   Wed, 27 Oct 2021 09:18:13 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.2.1
Subject: Re: [PATCH -next] xen-pciback: Fix return in pm_ctrl_init()
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>,
        YueHaibing <yuehaibing@huawei.com>, sstabellini@kernel.org
Cc:     xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
References: <20211008074417.8260-1-yuehaibing@huawei.com>
 <6644d095-92da-261e-87aa-284dcfcde19a@suse.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <6644d095-92da-261e-87aa-284dcfcde19a@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnQ1NGdIQ09uOGlMMzVDeGF2a2tMd3F6ZWlERmtNdEVGZTJ6Z2lvY2lxaERP?=
 =?utf-8?B?MktVaXJDRks5WWYzRGtjNUF1Z3d6djY5eHMzcnZ6cVZ4VVp6b21qbmpwYW94?=
 =?utf-8?B?eUFMRE0wbkVQYnY5dThreWlybEZtVktQQm0ra3FnWFVGdCtXd3RYejBETGJ2?=
 =?utf-8?B?N0FGODJGQ2QyMmlDb3FuSXoyR3EydW0zeC84MFAwbnVYYjlReHAyYTBXVnBy?=
 =?utf-8?B?U2lqNTdjTVlXRm80bmMydDBOeWZUZkVjQ3ZZV2ZnNFNpMW5uRFNZY1R1TzNH?=
 =?utf-8?B?aGVGWDBPa3piNW1ZNUxxRzNjZXhsYktCZDByVTd2ZGh0ZUR0TUE1VkZtZUgz?=
 =?utf-8?B?cWVBdTVLbHkrVURob2k2MEtvamNkcUEvcXhsZVgxRHF5SGdOSGI5NVZGeXdP?=
 =?utf-8?B?YWZoTE9HUjVqdGdhcTc5TExiUFRHcG5nVXFYTVErWXp2UG1oK04zeGYyTVE0?=
 =?utf-8?B?T1pMcU9vcEhJYzdSYksyTE1FYlE4elFXQzRrWUkwUDA3a0hFUHhXTDdMV3Vv?=
 =?utf-8?B?WUdoRThkdFZRcXczemYxMkpZYlpOSXJyTmtwMDRqbE5WczF5eFBZUFAyd1VW?=
 =?utf-8?B?MHdjdnZuakhjc2FNcGtPNGpyQkVtNGs5dG0vZVZoV0JJWHhUUk5IejFKN25K?=
 =?utf-8?B?ZEFxVi9YSzgxYi9iMnZxUmhMWDNFbEJBRFlnMzkxNzNId29WcmZIQlMzS0V0?=
 =?utf-8?B?Rk1lYjlxYTlpOUt3MDgzY0IvR3o3Q1FDcUNhN0hTaFpaZTFEZmlzUndxNkI4?=
 =?utf-8?B?L051RUk0dWVyTEgyWUt6WXNlMk0rNm5lWk50UHpseFJuLzBQUlpHK1JhOXo1?=
 =?utf-8?B?RGpYdDgra1g1akFvU0s2WUUvYVpEY3M5NG9RdXdWRDZFR2FwREZLaG1DVmtn?=
 =?utf-8?B?S0tNMUNGYkRBeVlsZlQvTXpQYjhJRGE1M1FVMUozN2p5Ly80QmppRy8xb1BO?=
 =?utf-8?B?UmJxY2R5cTFHUlFGbm5NRERPd1lqTlhzS2JHKzRZOHZRKzBacWFCRWFJSUpW?=
 =?utf-8?B?QVdBVDZkbGI4cjBpSmFxbEZhaUlLeHc3Rm5uamoxL3RLSWkydXVQUFRSSncv?=
 =?utf-8?B?d2E0ZjNUVTlZZkJWMFpEeDROcXk5RVZHV1N6SWtUSUIyQjlNamRFR21lZUcx?=
 =?utf-8?B?WlMwSTZoSFJhN2tPOSsxWFpycWpOOWJGZU5MV0ppVnM3a2JtZnZ3UmhqQlZZ?=
 =?utf-8?B?NGZvcCs5aGROc2VwMENhZUxFZFUzTEhyNFlqd3dlMGRMdllISkMxTWcyOXdi?=
 =?utf-8?B?K2M4T0s2VDNQa21KV2RRM2owUGlFTyt2ZUVXRGdJSEM1cWVsTUljZ0hZTzdX?=
 =?utf-8?B?WHV6Zy9mL3NGdExZR2xKeW02RndZa1RaMTJpeStpU1NaVTNpWHlIRWsxQXhL?=
 =?utf-8?B?R24wUGgybys1MTNLVHRNckZGNW5MN3puWFMyMFhZWk81c0JMaEMrM3VaNUZ0?=
 =?utf-8?B?NFBGdmY5SWIweWNlRDZIOVZhYW5tZ3lGb1lFQ2kycVpEQms2MFBiK0Y0U2Jt?=
 =?utf-8?B?REdEUHlhSzVnenU3Z2xHeXQ3V0h1d1NzWk5IZW05RXlOMFdpWkdNdDJCUlRk?=
 =?utf-8?B?S05uenlWb3d6aURySzlBYjJ1UnZIb2t2L3dBY1gyK3RiMi9ucXFFYUVZSVM3?=
 =?utf-8?B?MzNNRjF2Sk04NU1MVjcvMDdNWlhtanFEV2phZXFLRHFibWdLc2dCaUFFVEh2?=
 =?utf-8?B?WHYrS24xaUYrYlE3VGo0VXRkSG04eEZXZ0tTUmVrZXErSDJPR29XSzJrYitH?=
 =?utf-8?B?ODV4U3RDeTZVUEhsQzh6Zy9KTmNhWlFrVFFYekYxaFpGdDlzR3FjaHQzQmdC?=
 =?utf-8?B?d0RWend0VGRTblBoMVMyQThwQ2sxekppdTkxN29qcUI5YU1TMnQxOWhSaFZa?=
 =?utf-8?B?ZkZlcTBsdlhMVkt6UUdiR040K2tuUHJRdTY0SmlCNEpWOU9xNjJ5MkFRQVVq?=
 =?utf-8?B?Rm43TUJpYm9EYkV1bjlIcHo1dk9JTjBKMGwvK2Q2b0QwNEY2azJ1cFBJdWxj?=
 =?utf-8?B?ajlxcVdUVU41WkY3WjJ3ZExuakhYcTlOc2JKbmdnQWZHU0RjMHYwQjEzVXpt?=
 =?utf-8?B?eFFZVko1dllSVmN3Mm45QzUvbHM4WFdMWWFQZnQ5YUZVNjVnTGU4bmtoaEdJ?=
 =?utf-8?B?UkMrTERucW5EcmdRY3NhYndGTmk5OUlMNHpvUzdselI5MjZIaTE3eEYwbjJl?=
 =?utf-8?B?d2ZFNHd0QnlhanplWEdYZ3ovNlluWHRmeEM1elB5enR4cG85NVY2NEJmNmFW?=
 =?utf-8?Q?NUTx52dO7ykUJFbG8AkDzHTYH+MyW7Twd3q7unW0iM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26eecf02-b001-491a-1dfb-08d9994c3dcd
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 13:18:18.5243
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mkPP8sTdc5T5cZP6MRdBnqn/oda+wV8GfmBW0aI6aLjSLPK1akCauD8MYp++DkdOsG6wCRi6gdAFlLZzCwKXDeR58beZtcL+ZsE1Uo/s2F8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5251
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10149 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0
 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110270081
X-Proofpoint-ORIG-GUID: PHVel80CkDtcDBJSeEFu0PT_UpwjL2ir
X-Proofpoint-GUID: PHVel80CkDtcDBJSeEFu0PT_UpwjL2ir
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/8/21 11:01 AM, Juergen Gross wrote:
> On 08.10.21 09:44, YueHaibing wrote:
>> Return NULL instead of passing to ERR_PTR while err is zero,
>> this fix smatch warnings:
>> drivers/xen/xen-pciback/conf_space_capability.c:163
>>   pm_ctrl_init() warn: passing zero to 'ERR_PTR'
>>
>> Fixes: a92336a1176b ("xen/pciback: Drop two backends, squash and cleanup some code.")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
>


Applied to for-linux-5.16.


-boris