Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] bitmap: simplify GENMASK(size - 1, 0) lines
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     Yury Norov <yury.norov@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        <linux-kernel@vger.kernel.org>
References: <20211026144108.35373-1-quic_qiancai@quicinc.com>
 <YXhOEEOSG+fgEy+t@yury-ThinkPad> <YXhVVvG9keoVWJyK@smile.fi.intel.com>
 <YXhW8K7DxadyVgx3@yury-ThinkPad> <YXhaMVTymVNzOlGT@smile.fi.intel.com>
 <031fe271-7fc3-0d95-3547-edbe0c975cbb@quicinc.com>
 <YXkfaGlmbkXXJGih@smile.fi.intel.com>
From:   Qian Cai <quic_qiancai@quicinc.com>
Message-ID: <4afd7242-a8f9-6d41-e1a8-e6cfbe3cea6e@quicinc.com>
Date:   Wed, 27 Oct 2021 11:06:53 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <YXkfaGlmbkXXJGih@smile.fi.intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/27/21 5:44 AM, Andy Shevchenko wrote:
> Agree, but you see a problem here, W=2, for example, is high due to
> a lot of non-sense (or very little sense) noise. The warning you got
> is hidden on purpose. On top of that, the code has not been thought
> through at all, despite missed test run. This is easy to catch.
> 
> What I expect from "a stranger" who is in doubt (obviously) how this
> code works to ask and then decide how to act.
> 
> And on top of all these, we used to have UMN case which makes me
> first think of bad experiments on the community (I really haven't
> believed that this patch was sent consciously).
> 
> So, please be careful next time and better ask first before acting,
> if in doubt.

Yes, I am an idiot. My brain was short-circled for a moment to be
totally mistaken with "GENMASK() == 0" instead GENMASK_INPUT_CHECK(). I
am not sure how to avoid those short-circles again in the future though
apart from thinking about going to an office in the near future, so kids
at home would drive my less crazy. Of course, I knew the trick for
lib_test.c now which should help me in this subsystem in the future.
Thanks for your time, Andy.