Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Nick Alcock <nick.alcock@oracle.com>
To:     jeyu@kernel.org, masahiroy@kernel.org
Cc:     linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        arnd@arndb.de, eugene.loh@oracle.com, kris.van.hees@oracle.com
Subject: [PATCH v5 1/7] kbuild: bring back tristate.conf
Date:   Wed, 27 Oct 2021 18:47:00 +0100
Message-Id: <20211027174706.31010-2-nick.alcock@oracle.com>
In-Reply-To: <20211027174706.31010-1-nick.alcock@oracle.com>
References: <20210929215154.300692-1-nick.alcock@oracle.com>
 <20211027174706.31010-1-nick.alcock@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Odzlwc1lSjj6LF//UW5zKvEXsT2r39yFUnILNerwzWQhQN1Sh88SljToRhNG?=
 =?us-ascii?Q?T9b+L0hpi3WmJcXtgF6GClPNNaeLqf5qlnv+j3Q40Mot07VXaTo9KHosBOuy?=
 =?us-ascii?Q?a/BDXegqwqWPfz7qWnt3vBNmNF8pXtQYjrxQhCzRUt0HahNhQE5uDaE2+X3T?=
 =?us-ascii?Q?AYJxo99+Ouji0hXD+jQ4hGoKORiCyq61vAOIS7klFPWFNi1r7fOokHP0UPVn?=
 =?us-ascii?Q?Vztgp2D5S7vhvH5OQl4IuaYIXL1ean9fTMslUhZAfiOwDvVNEeOu5/N91Tnk?=
 =?us-ascii?Q?hYMMqbweYbfvYUCCZ2zm/E1/NjgwQGQWFBTVJ6FGAp6KclqXGFTScOJxU8tA?=
 =?us-ascii?Q?hwjEk6eGOe55WexPY+Xci3a+hCOeOiTJZDGUJulWgdq4N3rpjV4VklD519MD?=
 =?us-ascii?Q?NzTPRGwOTpdBqeAJ0xr3Ce8t2HfcnvZJlqizNMR7ZwpxuAzfAnn9n4fuvw8q?=
 =?us-ascii?Q?okTbh5nhp4L8Hlm8GCoyuMkaAPzVIQUSZFgDeSaIOsIwKHu0E1epoZ67iu5p?=
 =?us-ascii?Q?eteK8kEXAZRf9GrbETHBwsG5iaWLU54jEHKZQoufijF8oH5/s3dudLJL12Rh?=
 =?us-ascii?Q?8WWXc8Yzz6v1fRIeK5jTxdTeIpsZYfjwOOfOhn5tcwNKwmhrfnUj1Qe0RLIJ?=
 =?us-ascii?Q?pb9342P1MVL0vbAKB2/4BOGCjLF98q5lojU9RPcwzIzK3I2BS9xKtPMeJEHb?=
 =?us-ascii?Q?DfQ4GviH3samRp1j66B2NlqmXphd0TtOH8TINKjjV5utrJHy1ctvKrJarttK?=
 =?us-ascii?Q?nYTTz5AUB2Yh2ZJXNWdLnwQJX1hQGBJ9nmx8wZGaXeIcRwauupOdP2PBK8+U?=
 =?us-ascii?Q?W4w3QuPnlCjtJ37lVLcS8pILQ61I7h8Yzqhhv1fKuohGeeMeINM4hpdJ5Py2?=
 =?us-ascii?Q?V0+cdh4Hs04Lp9DxBASZ6pjGdQeOOERo1UvD0mKZ5vyv/yf2NEL9NKJhoRAL?=
 =?us-ascii?Q?v8sghQm4c8ODxsjql60QxA9BVYUQJ9LLYl55qLzLxxfqJUkv+SCvzVVQXOgo?=
 =?us-ascii?Q?4UOssKJO9iylt7R3fnmJUtxFN6dpO+Yi6WF46ssYFk8o9DmpfJVl3+1NW39a?=
 =?us-ascii?Q?EwaE/gO8QPWSh1VVRAuPOziBwbTkGHYYOeKDirN9bG58VIEeYAmd9lC0NpY+?=
 =?us-ascii?Q?FCSFYIeHOab25JcJfWHHFL73vG6aJpw9cWZfQ0C1xs09aRA6ZztIM2bPZUEM?=
 =?us-ascii?Q?qyR/X6CYrWsPB0TdonaQXjx1tCFloI6iJ/NOVTKV66CK6APJ/uc4PO3CnATL?=
 =?us-ascii?Q?Q81siYT6/edOHd/owmcgJZD4Ue0tJd6VFliYMLXiQa/wyaZjwmL0nZ3IweGF?=
 =?us-ascii?Q?O9KKKpLs9fcvS1NbBt/Iyj/Si+iHm/+cuVb+wy+SSXvGgV3zo3LgjKKnx95J?=
 =?us-ascii?Q?N52lP+STs7ceJXDhLm6i0UJAK7lyspsfCeJfSd/WDGeHZ3tWsv+x7Nsd59IB?=
 =?us-ascii?Q?dwGctwrpL0/aZbzQ1ly+KJK94FiXOJQJOwwTc+MWYmbzN1zv1fNZewhCuOBK?=
 =?us-ascii?Q?6dZ2D9x15fFtbRKfO5UM7SxZZEkVMBEDZYPfB0+5OBfGTYZ4rw6PwYEJiXm7?=
 =?us-ascii?Q?Y/5Zvfvt1KG9zi41go9Qobn9e4oUJztlM1CM1jhehZAOltkv5L46cVwGMysJ?=
 =?us-ascii?Q?CD/38Y5uyr9UxkTHxhxfrRFl7rlIw29PAGtmXEHHbyll?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f25ab43e-c5cd-461b-4faa-08d99971d7e6
X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4715.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 17:47:28.6555
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e9JmqEZVP6jSF+HhddCzW2n9Ro5mvdKYCuciD9v2VaLMBWhX48HDAdY3jKiWlx9zHyzeH+EzhgqbVO9R167nmw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB2925
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10150 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000
 definitions=main-2110270099
X-Proofpoint-GUID: 0iV0RnlfvAHWDKY4F7NFY8JTDByuUZwO
X-Proofpoint-ORIG-GUID: 0iV0RnlfvAHWDKY4F7NFY8JTDByuUZwO
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tristate.conf was dropped because it is not needed to build a
modules.builtin (although dropping it introduces a few false positives
into modules.builtin support), and doing so avoids one round of
recursion through the build tree to build it.  But kallmodsyms support
requires building a mapping from object file name to built-in module
name for all builtin modules: this seems to me impossible to accomplish
without parsing all makefiles under the influence of tristate.conf,
since the makefiles are the only place this mapping is recorded.

So bring it back for this purpose.

This partially reverts commit 8b41fc4454e36fbfdbb23f940d023d4dece2de29.

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
---
 Makefile                   |  2 +-
 scripts/kconfig/confdata.c | 41 ++++++++++++++++++++++++++++++++++++--
 2 files changed, 40 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 437ccc66a1c2..77062b44a4b5 100644
--- a/Makefile
+++ b/Makefile
@@ -724,7 +724,7 @@ $(KCONFIG_CONFIG):
 #
 # Do not use $(call cmd,...) here. That would suppress prompts from syncconfig,
 # so you cannot notice that Kconfig is waiting for the user input.
-%/config/auto.conf %/config/auto.conf.cmd %/generated/autoconf.h: $(KCONFIG_CONFIG)
+%/config/auto.conf %/config/auto.conf.cmd %/generated/autoconf.h %/tristate.conf: $(KCONFIG_CONFIG)
 	$(Q)$(kecho) "  SYNC    $@"
 	$(Q)$(MAKE) -f $(srctree)/Makefile syncconfig
 else # !may-sync-config
diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index cf72680cd769..8f4f1b373dd6 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -725,6 +725,25 @@ static struct conf_printer header_printer_cb =
 	.print_comment = header_print_comment,
 };
 
+/*
+ * Tristate printer
+ *
+ * This printer is used when generating the `include/config/tristate.conf' file.
+ */
+static void
+tristate_print_symbol(FILE *fp, struct symbol *sym, const char *value, void *arg)
+{
+
+       if (sym->type == S_TRISTATE && *value != 'n')
+	       fprintf(fp, "%s%s=%c\n", CONFIG_, sym->name, (char)toupper(*value));
+}
+
+static struct conf_printer tristate_printer_cb =
+{
+       .print_symbol = tristate_print_symbol,
+       .print_comment = kconfig_print_comment,
+};
+
 static void conf_write_symbol(FILE *fp, struct symbol *sym,
 			      struct conf_printer *printer, void *printer_arg)
 {
@@ -1058,7 +1077,7 @@ int conf_write_autoconf(int overwrite)
 	struct symbol *sym;
 	const char *name;
 	const char *autoconf_name = conf_get_autoconfig_name();
-	FILE *out, *out_h;
+	FILE *out, *tristate, *out_h;
 	int i;
 
 	if (!overwrite && is_present(autoconf_name))
@@ -1073,6 +1092,13 @@ int conf_write_autoconf(int overwrite)
 	if (!out)
 		return 1;
 
+	tristate = fopen(".tmpconfig_tristate", "w");
+	if (!tristate) {
+		fclose(out);
+		fclose(tristate);
+		return 1;
+	}
+
 	out_h = fopen(".tmpconfig.h", "w");
 	if (!out_h) {
 		fclose(out);
@@ -1080,6 +1106,7 @@ int conf_write_autoconf(int overwrite)
 	}
 
 	conf_write_heading(out, &kconfig_printer_cb, NULL);
+	conf_write_heading(tristate, &tristate_printer_cb, NULL);
 	conf_write_heading(out_h, &header_printer_cb, NULL);
 
 	for_all_symbols(i, sym) {
@@ -1087,11 +1114,13 @@ int conf_write_autoconf(int overwrite)
 		if (!(sym->flags & SYMBOL_WRITE) || !sym->name)
 			continue;
 
-		/* write symbols to auto.conf and autoconf.h */
+		/* write symbols to auto.conf, tristate and autoconf.h */
 		conf_write_symbol(out, sym, &kconfig_printer_cb, (void *)1);
+		conf_write_symbol(tristate, sym, &tristate_printer_cb, (void *)1);
 		conf_write_symbol(out_h, sym, &header_printer_cb, NULL);
 	}
 	fclose(out);
+	fclose(tristate);
 	fclose(out_h);
 
 	name = getenv("KCONFIG_AUTOHEADER");
@@ -1102,6 +1131,14 @@ int conf_write_autoconf(int overwrite)
 	if (rename(".tmpconfig.h", name))
 		return 1;
 
+	name = getenv("KCONFIG_TRISTATE");
+	if (!name)
+		name = "include/config/tristate.conf";
+	if (make_parent_dir(name))
+		return 1;
+	if (rename(".tmpconfig_tristate", name))
+		return 1;
+
 	if (make_parent_dir(autoconf_name))
 		return 1;
 	/*
-- 
2.33.0.256.gb827f06fa9