Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754870AbXACHgw (ORCPT ); Wed, 3 Jan 2007 02:36:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754896AbXACHgw (ORCPT ); Wed, 3 Jan 2007 02:36:52 -0500 Received: from pasmtpa.tele.dk ([80.160.77.114]:50068 "EHLO pasmtpA.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754870AbXACHgv (ORCPT ); Wed, 3 Jan 2007 02:36:51 -0500 Date: Wed, 3 Jan 2007 08:36:37 +0100 From: Sam Ravnborg To: Andres Salomon Cc: Dmitry Torokhov , Andres Salomon , linux-kernel@vger.kernel.org, vojtech@suse.cz, warp@aehallh.com Subject: Re: [PATCH] psmouse split [01/03] Message-ID: <20070103073637.GA26825@uranus.ravnborg.org> References: <457F822E.4040404@debian.org> <200612130108.19447.dtor@insightbb.com> <457FAA01.9010807@debian.org> <45802D98.7030608@debian.org> <459B51C4.8040906@queued.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <459B51C4.8040906@queued.net> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1518 Lines: 50 Hi Andres. > diff --git a/drivers/input/mouse/Makefile b/drivers/input/mouse/Makefile > index 21a1de6..e7c7fbb 100644 > --- a/drivers/input/mouse/Makefile > +++ b/drivers/input/mouse/Makefile > @@ -14,4 +14,24 @@ obj-$(CONFIG_MOUSE_SERIAL) += sermouse.o > obj-$(CONFIG_MOUSE_HIL) += hil_ptr.o > obj-$(CONFIG_MOUSE_VSXXXAA) += vsxxxaa.o > > -psmouse-objs := psmouse-base.o alps.o logips2pp.o synaptics.o lifebook.o trackpoint.o > +psmouse-objs := psmouse-base.o > + > +ifeq ($(CONFIG_MOUSE_PS2_ALPS),y) > +psmouse-objs += alps.o > +endif > + > +ifeq ($(CONFIG_MOUSE_PS2_LOGIPS2PP),y) > +psmouse-objs += logips2pp.o > +endif > + > +ifeq ($(CONFIG_MOUSE_PS2_SYNAPTICS),y) > +psmouse-objs += synaptics.o > +endif > + > +ifeq ($(CONFIG_MOUSE_PS2_LIFEBOOK),y) > +psmouse-objs += lifebook.o > +endif > + > +ifeq ($(CONFIG_MOUSE_PS2_TRACKPOINT),y) > +psmouse-objs += trackpoint.o > +endif The above code should be redone to use list based assignement. Something like this: psmouse-y := psmouse-base.o psmouse-$(CONFIG_MOUSE_PS2_ALPS) += alps.o psmouse-$(CONFIG_MOUSE_PS2_LOGIPS2PP) += logips2pp.o psmouse-$(CONFIG_MOUSE_PS2_SYNAPTICS) += synaptics.o psmouse-$(CONFIG_MOUSE_PS2_LIFEBOOK) += lifebook.o psmouse-$(CONFIG_MOUSE_PS2_TRACKPOINT) += trackpoint.o Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/