Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211025170925.3096444-1-bjorn.andersson@linaro.org> <65243a98-61b9-3311-f41d-fa4782448baa@kali.org>
In-Reply-To: <65243a98-61b9-3311-f41d-fa4782448baa@kali.org>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Wed, 27 Oct 2021 17:06:02 +0200
Message-ID: <CAG3jFytmcFcA5W3vmcpWTWrc36-YFMPZ1wAB8gAJfiHHLWmaCA@mail.gmail.com>
Subject: Re: [PATCH v7 1/3] pwm: Introduce single-PWM of_xlate function
To:     Steev Klimaszewski <steev@kali.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, Lee Jones <lee.jones@linaro.org>,
        linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, 26 Oct 2021 at 19:21, Steev Klimaszewski <steev@kali.org> wrote:
>
>
> On 10/25/21 12:09 PM, Bjorn Andersson wrote:
> > The existing pxa driver and the upcoming addition of PWM support in the
> > TI sn565dsi86 DSI/eDP bridge driver both has a single PWM channel and
> > thereby a need for a of_xlate function with the period as its single
> > argument.
> >
> > Introduce a common helper function in the core that can be used as
> > of_xlate by such drivers and migrate the pxa driver to use this.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Acked-by: Uwe Kleine-K=C3=B6nig <u.kleine-koenig@pengutronix.de>
> > Tested-by: Steev Klimaszewski <steev@kali.org>
> > ---
> >
> > Changes since v6:
> > - None
> >
> >   drivers/pwm/core.c    | 26 ++++++++++++++++++++++++++
> >   drivers/pwm/pwm-pxa.c | 16 +---------------
> >   include/linux/pwm.h   |  2 ++
> >   3 files changed, 29 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
> > index 4527f09a5c50..2c6b155002a2 100644
> > --- a/drivers/pwm/core.c
> > +++ b/drivers/pwm/core.c
> > @@ -152,6 +152,32 @@ of_pwm_xlate_with_flags(struct pwm_chip *pc, const=
 struct of_phandle_args *args)
> >   }
> >   EXPORT_SYMBOL_GPL(of_pwm_xlate_with_flags);
> >
> > +struct pwm_device *
> > +of_pwm_single_xlate(struct pwm_chip *pc, const struct of_phandle_args =
*args)
> > +{
> > +     struct pwm_device *pwm;
> > +
> > +     if (pc->of_pwm_n_cells < 1)
> > +             return ERR_PTR(-EINVAL);
> > +
> > +     /* validate that one cell is specified, optionally with flags */
> > +     if (args->args_count !=3D 1 && args->args_count !=3D 2)
> > +             return ERR_PTR(-EINVAL);
> > +
> > +     pwm =3D pwm_request_from_chip(pc, 0, NULL);
> > +     if (IS_ERR(pwm))
> > +             return pwm;
> > +
> > +     pwm->args.period =3D args->args[0];
> > +     pwm->args.polarity =3D PWM_POLARITY_NORMAL;
> > +
> > +     if (args->args_count =3D=3D 2 && args->args[2] & PWM_POLARITY_INV=
ERTED)
> > +             pwm->args.polarity =3D PWM_POLARITY_INVERSED;
> > +
> > +     return pwm;
> > +}
> > +EXPORT_SYMBOL_GPL(of_pwm_single_xlate);
> > +
> >   static void of_pwmchip_add(struct pwm_chip *chip)
> >   {
> >       if (!chip->dev || !chip->dev->of_node)
> > diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c
> > index a9efdcf839ae..238ec88c130b 100644
> > --- a/drivers/pwm/pwm-pxa.c
> > +++ b/drivers/pwm/pwm-pxa.c
> > @@ -148,20 +148,6 @@ static const struct platform_device_id *pxa_pwm_ge=
t_id_dt(struct device *dev)
> >       return id ? id->data : NULL;
> >   }
> >
> > -static struct pwm_device *
> > -pxa_pwm_of_xlate(struct pwm_chip *pc, const struct of_phandle_args *ar=
gs)
> > -{
> > -     struct pwm_device *pwm;
> > -
> > -     pwm =3D pwm_request_from_chip(pc, 0, NULL);
> > -     if (IS_ERR(pwm))
> > -             return pwm;
> > -
> > -     pwm->args.period =3D args->args[0];
> > -
> > -     return pwm;
> > -}
> > -
> >   static int pwm_probe(struct platform_device *pdev)
> >   {
> >       const struct platform_device_id *id =3D platform_get_device_id(pd=
ev);
> > @@ -187,7 +173,7 @@ static int pwm_probe(struct platform_device *pdev)
> >       pc->chip.npwm =3D (id->driver_data & HAS_SECONDARY_PWM) ? 2 : 1;
> >
> >       if (IS_ENABLED(CONFIG_OF)) {
> > -             pc->chip.of_xlate =3D pxa_pwm_of_xlate;
> > +             pc->chip.of_xlate =3D of_pwm_single_xlate;
> >               pc->chip.of_pwm_n_cells =3D 1;
> >       }
> >
> > diff --git a/include/linux/pwm.h b/include/linux/pwm.h
> > index 725c9b784e60..dd51d4931fdc 100644
> > --- a/include/linux/pwm.h
> > +++ b/include/linux/pwm.h
> > @@ -414,6 +414,8 @@ struct pwm_device *pwm_request_from_chip(struct pwm=
_chip *chip,
> >
> >   struct pwm_device *of_pwm_xlate_with_flags(struct pwm_chip *pc,
> >               const struct of_phandle_args *args);
> > +struct pwm_device *of_pwm_single_xlate(struct pwm_chip *pc,
> > +                                    const struct of_phandle_args *args=
);
> >
> >   struct pwm_device *pwm_get(struct device *dev, const char *con_id);
> >   struct pwm_device *of_pwm_get(struct device *dev, struct device_node =
*np,
>
> v7 of the series is tested by me on the Lenovo Yoga C630
>
> Tested-By: Steev Klimaszewski <steev@kali.org>
>

Applied to drm-misc-next.