Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <da656ae0-eec3-88ea-9ed2-41740608c691@oracle.com>
Date:   Wed, 27 Oct 2021 15:12:39 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH] vhost: Make use of the helper macro kthread_run()
Content-Language: en-US
To:     "Michael S. Tsirkin" <mst@redhat.com>,
        Cai Huoqing <caihuoqing@baidu.com>
Cc:     Jason Wang <jasowang@redhat.com>, kvm@vger.kernel.org,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20211021084406.2660-1-caihuoqing@baidu.com>
 <20211027160010-mutt-send-email-mst@kernel.org>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20211027160010-mutt-send-email-mst@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V09WRkMzNVRZdjBwYTdjNmlVeGtBRVNXcmpoOWJ4SzJhUEV5ZWlkdEMwd0NX?=
 =?utf-8?B?R2pVbHZMWHIxc1VKYkhHeUZPT0EyUHVuaFhEYnFzTGcwNkhZa2hPRS9SVGtt?=
 =?utf-8?B?S3BzVENhai9GeDhHdjdCK3VLYm1hNVFVOXJsSW9ld2l4SmZrNkN6RzVtbkJm?=
 =?utf-8?B?MzM3TVlFQnU4NGFlR2VxbDRUK3JzSDRjMzRwNXlUZ2FTSUtQRTBsdk9EbWhO?=
 =?utf-8?B?R0w1bk0zYlJTZDNJN253MTFkc0w3VC9vTjVBaHBaV01GQmtxbm1YS1FUalFD?=
 =?utf-8?B?aUV3enVMaG5UV1VsWE5RTGZHaCtaYWU5Yml3R2FtWkhVYjYzY3RRNytKRUoz?=
 =?utf-8?B?ZjBRNlVPalB6TGs5N04yR3A5NE04dVRxRG5MZWp4dHYzOG5pbDQ0M1FxeEhM?=
 =?utf-8?B?SjBMcEd0VlNnejBaZi9Hb2gvWnQrSXpXR1JZT2VBQWRXdXAvNVpmRGdmY2FM?=
 =?utf-8?B?MWVvSSthWnRwcG1mTlZuY0tuR2lwK2xUcjRhandOa0o1TmxiZVlYWlZaMkdq?=
 =?utf-8?B?NlFuS1IzTC9YTS90bFdqM056RlB0RERwN2puOFIrK0xSSHUxNi9yYmZ2RUVl?=
 =?utf-8?B?clB6NTl1dXNPbk1od2dRUjBsM2FoUmN2d1M3WlQxM2dPQndmVnFMTDRYYm9p?=
 =?utf-8?B?UFlBaU4wN3pFZHU5QjQ3YThQYzNCMnZTaDB2ZWJsT2xncStZQm9NTDRmOTZE?=
 =?utf-8?B?bXc2UTNKWGd4NVlHZWFUNGRwQ2h4d1JCQ3M0cUhUUGxKenRhU055Zk9aNUN3?=
 =?utf-8?B?VW4xUmNIbjgxTEJiUi8yS0l6K2ZOaGoxVU1TNVNxUnpJcElzTG96d016aXBG?=
 =?utf-8?B?VElRbzhsbkk4OHZMNG9MSnRCaGQ3NlFoZHozS244a09SY0pLb3p1dUFVUTFt?=
 =?utf-8?B?Smx2dkJpbUplVy9jNXVGbkRZUVByQ1ZkMm5XRnpBODYvYTAreDQ4YnlOOHYy?=
 =?utf-8?B?RVNFbmpZTXViaHYvTXI3c00veUZJbHRBQ2FzOXpja3M1UXo3OUtCTCtaNUFn?=
 =?utf-8?B?cXRDQjRDZ1dwUFZoM0RJcjZwcnRkYTEwR2lDNEVyMGNMbE5HRG9PLzVKZVlo?=
 =?utf-8?B?TUpOa2JBeTFMbUptM2FWWDZQYU1kR3ZZckh4N1JSdXNlTTJCejhMRmlrVkll?=
 =?utf-8?B?U0JKclI4RGl0MmQzSjhDVGJvTHJnemg4UElGNFlTRkQ3RTZGYkZoaExzb2Qx?=
 =?utf-8?B?eWFLa3FHaEIraWhRbWVrZWJmVEdkMHZVbFBuRnV5YzViV0t6Sm9Mc1ZmZkw5?=
 =?utf-8?B?SjRlUlltdFVIWDM3NjkrMFg3UFRvbDdoUEpxZGRCd0VCVEMybkpSRFE4elR4?=
 =?utf-8?B?SU1qZDNnejU0bktMR29ZK2FrUVNWNXZUbStKaFpzYnRYdHQxemFVZDB3eGRM?=
 =?utf-8?B?TFRyZE8xTC9nYjhYUTZxbkVCbHBPcmkzRWZaSlc2MnNtMXgybUdaZjI4R1FM?=
 =?utf-8?B?T1pVemZJV3NSL21ScU04NmJlK2doL0Iwd25wOXRkM3NMcXRBV01WUHplMFBt?=
 =?utf-8?B?NVF2OFh1ZkZWMHlkMkZZZXZzaG9zL3dtQ0h3T3VlbFhQY3E5S2N0UlNRYlZH?=
 =?utf-8?B?eVh4VkFEemNBc25QdFNxSjIyZWMwSVp5cnMySytEejIzcnBsZTRuZ29GUG1t?=
 =?utf-8?B?aHhVQUdGbnBNLzhVek9DZXl5aGJxTUxGR2tNeUJxbDFVNC9xRGNGM0ZRcThi?=
 =?utf-8?B?OWNUVmxZRjNzcjRYMmtJRzNIbTFHOVZZRzZ3UTh5Kzh6cnh5QVQzMVdNVzVI?=
 =?utf-8?B?cm9Id0xQSWJoMGZkdHNGbFNsakZZOUpTSzV0OGVaNTVyRU1CZFdVM0VSdlB1?=
 =?utf-8?B?ajM3UTFpK0dDT0lnVnlCNXlPaFpMc0Yrc0MrNGRWaUJKaTRjdjl6NlZ1NUUx?=
 =?utf-8?B?V2Z4bnBXc3ZYVmNERzQ1SDV6ZDY1MFhMRGRlS1lMakpRQmMvUCt2TWllclhm?=
 =?utf-8?B?dXdCMHFXTUVMVThXMVNuRzVTYWx3dC9ES21kbVl4SHdzUGJRcFN6czBzYzFs?=
 =?utf-8?B?aklnSXI4OUNiQ2twaWxkTFBKWHpucGxwaFhXVllCbUZMSGVYS3JwSFNjOXR3?=
 =?utf-8?B?T0tSdXFMSEtaWVZaOC96OHF1bUNBaEtjbWc1eUEwa042Qm5nL3J3ZEhLKy9Q?=
 =?utf-8?B?dEp6NUVpY1daVkUxcXBsMmNtcVBkblhxMVdJQSswTUdVdzZ2NjFjeVQwT2k4?=
 =?utf-8?B?YTZmUUZxb0FzMnBWZXVsM01xM3ZGV1BoOXRtWG1oRFMyTnNOM1FJN2Y4QnRk?=
 =?utf-8?B?ZzdmUlAvVG8xdXQyQ1NORUlFaVFBPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 567454e5-59bb-445a-ef70-08d99986216e
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 20:12:41.6431
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: B+3uZfFs6QP7/5rJEho4o68bS9o0Dzz4WvOQSHlkyxZXYTywVK719nKbJ1HIYxNcTQuxy6dqJ63ggBdmS+I4xbDji51yd4a3HZtmOwDju5o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4345
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10150 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 adultscore=0 suspectscore=0 bulkscore=0 mlxscore=0 spamscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110270115
X-Proofpoint-GUID: GIuE4L3ceFqamNQJhHvMzVwNJUODYVr9
X-Proofpoint-ORIG-GUID: GIuE4L3ceFqamNQJhHvMzVwNJUODYVr9
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/27/21 3:02 PM, Michael S. Tsirkin wrote:
> On Thu, Oct 21, 2021 at 04:44:06PM +0800, Cai Huoqing wrote:
>> Repalce kthread_create/wake_up_process() with kthread_run()
>> to simplify the code.
>>
>> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> 
> Pls check how this interacts with Mike Christie's patches.
> Pls fix up the typo in the commit log.
> 

Hi Cai,

We probably don't need this patch since it's an API cleanup and
not fixing a bug. I'm replacing this code with the kernel_worker API
with this patch

https://lore.kernel.org/all/20211007214448.6282-9-michael.christie@oracle.com/

in this patchset;

https://lore.kernel.org/all/20211007214448.6282-1-michael.christie@oracle.com/

so the issue of using kthread_create + wake_up_process will be
gone shortly either way.