Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <bbc73df5-acda-5577-2cfd-ee8c8e1018c3@gmx.de>
Date:   Wed, 27 Oct 2021 20:27:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.2
Subject: Re: [PATCH 1/1] include/linux/byteorder/generic.h: fix index
 variables
Content-Language: en-US
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <20210523204958.64575-1-xypron.glpk@gmx.de>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        Heinrich Schuchardt <xypron.glpk@gmx.de>
From:   Heinrich Schuchardt <xypron.glpk@gmx.de>
In-Reply-To: <20210523204958.64575-1-xypron.glpk@gmx.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 5/23/21 22:49, Heinrich Schuchardt wrote:
> In cpu_to_be32_array() and be32_to_cpu_array() the length of the array i=
s
> given by variable len of type size_t. An index variable of type int is u=
sed
> to iterate over the array. This is bound to fail for len > INT_MAX and
> lets GCC add instructions for sign extension.
>
> Correct the type of the index variable.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>   include/linux/byteorder/generic.h | 4 ++--

Dear Greg,

This file is not assigned to any maintainer. Could you handle the patch?

Best regards

Heinrich

>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/byteorder/generic.h b/include/linux/byteorder=
/generic.h
> index 4b13e0a3e15b..c9a4c96c9943 100644
> --- a/include/linux/byteorder/generic.h
> +++ b/include/linux/byteorder/generic.h
> @@ -190,7 +190,7 @@ static inline void be64_add_cpu(__be64 *var, u64 val=
)
>
>   static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size=
_t len)
>   {
> -	int i;
> +	size_t i;
>
>   	for (i =3D 0; i < len; i++)
>   		dst[i] =3D cpu_to_be32(src[i]);
> @@ -198,7 +198,7 @@ static inline void cpu_to_be32_array(__be32 *dst, co=
nst u32 *src, size_t len)
>
>   static inline void be32_to_cpu_array(u32 *dst, const __be32 *src, size=
_t len)
>   {
> -	int i;
> +	size_t i;
>
>   	for (i =3D 0; i < len; i++)
>   		dst[i] =3D be32_to_cpu(src[i]);
> --
> 2.30.2
>
>