Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp890766pxb; Wed, 27 Oct 2021 14:33:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzULzllGzv1OYTWdu0IcGuoruzIylOiuLNDUgXsRGLyMA2n+4/8ljd1qHbffhd5JyzZWRT X-Received: by 2002:a17:902:f693:b0:141:7400:a476 with SMTP id l19-20020a170902f69300b001417400a476mr71567plg.17.1635370434138; Wed, 27 Oct 2021 14:33:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635370434; cv=none; d=google.com; s=arc-20160816; b=zIGA2It5cwc5L/Vwc4rh16S6sopd780MSWhBSa/X0p0Whty/JKfzdSfeSJxxzRsCKE 12CHgs7hwr7kcpvK3jlMLHfCgd2jsq1SZVbsoy+bvHutfZ56ReijE2ecHL1GWhaFD3oL K0jAjws2MSqiPhihMKDCUvDn7AIiaaB0IzuDeg6IZWC2/wqEwKWUg07ut+uxahcLUnsu 5kULLO6EO/Ts6fcV3aJEi4K7Op1yIj+O1y4+CBsZK/IfOdLZoKpx72WcceWFQRA0WvsU Y5R/XXkESqPG0KIj5kiPXh08fgCDeaQJOzSYxMtRuS/RrBlWgwRdHKvf4OiYTD0ksph8 l9AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=2GLf2oMkquNYleTApCKNLiOK1qbjb/73MA2bgF6t+os=; b=OQtjD+DwgR7vtKelAe81Ri/+92ZqZCFAwtv57uqmCZLgUgxDuFlIR/LWt34X10fbcD VyA1MIiBEBKQVxKCZ3Toco0uSLKQ6yp3K742+xiFnjbwgxnczOAOUxBu52mAtOOjUmyu S0qmiaQoUVH3OVoYKtEgKbRIVlSOlPnKQb+FMLv1+mYByhCsuRxN9UUI1nN3DatoiBM3 7M6S99HZCAjYmo8w3HIiRL1UhFSoaqOGwhEh2zAoY9uSFOn9kqR1S8VZT83l/jBiHoRA ZNFaiPDvP5V5XWqKX85mLyzhxiBWYi8L1iiDCcE3wCOe0cOpKUZADoPn075MWRdBU4ns +XNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kk7si3830143pjb.33.2021.10.27.14.33.41; Wed, 27 Oct 2021 14:33:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237250AbhJ0URF (ORCPT + 97 others); Wed, 27 Oct 2021 16:17:05 -0400 Received: from netrider.rowland.org ([192.131.102.5]:60193 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S235577AbhJ0URF (ORCPT ); Wed, 27 Oct 2021 16:17:05 -0400 Received: (qmail 1331371 invoked by uid 1000); 27 Oct 2021 16:14:38 -0400 Date: Wed, 27 Oct 2021 16:14:38 -0400 From: Alan Stern To: Wesley Cheng Cc: balbi@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, jackp@codeaurora.org Subject: Re: [PATCH v3 0/2] Disable mass storage endpoints during disconnect Message-ID: <20211027201438.GB1326060@rowland.harvard.edu> References: <1635365407-31337-1-git-send-email-quic_wcheng@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1635365407-31337-1-git-send-email-quic_wcheng@quicinc.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 27, 2021 at 01:10:05PM -0700, Wesley Cheng wrote: > Changes in v3: > - Modify statement for usb_ep_enable(). > - Add explicit statement mentioning that APIs can be called in atomic context. > > Changes in v2: > - Revised comments for usb_ep_disable() as it should be safe to be > executed in atomic contexts as well. Other FDs are currently > calling ep disable during the disconnect event as well. > > This series calls the usb_ep_disable() API directly from fsg_disable() > as there is a possibility that UDCs that support runtime PM may > already be in a suspended state, leading to HW access while resources > are disabled. > > Wesley Cheng (2): > usb: gadget: udc: core: Revise comments for USB ep enable/disable > usb: gadget: f_mass_storage: Disable eps during disconnect > > drivers/usb/gadget/function/f_mass_storage.c | 10 ++++++++++ > drivers/usb/gadget/udc/core.c | 4 ++-- > 2 files changed, 12 insertions(+), 2 deletions(-) For both patches: Acked-by: Alan Stern