Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 27 Oct 2021 22:32:36 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Naveen Krishna Chatradhi <nchatrad@amd.com>
Cc:     linux-edac@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, bp@alien8.de, mingo@redhat.com,
        mchehab@kernel.org, Muralidhara M K <muralimk@amd.com>
Subject: Re: [PATCH v5 5/5] EDAC/amd64: Enumerate memory on Aldebaran GPU
 nodes
Message-ID: <YXnThJnUuWP6Ou/D@yaz-ubuntu>
References: <20211025145018.29985-1-nchatrad@amd.com>
 <20211025145018.29985-6-nchatrad@amd.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211025145018.29985-6-nchatrad@amd.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Wzt4uEcJxZHHp/mnpzSfPqEgTAHRepJIS43xU8CPnJ76TKLsH9acY6PegMGm?=
 =?us-ascii?Q?p4HFOKF4MBMerdQXgSS9he3HKIOSUyjTDngTq3n/t/4TPNwI+ZJ6x4tK+i5B?=
 =?us-ascii?Q?P7fYfmK46r1YHKubDLMjxmVICkyWaZZxkSc0ewJTtd4iFf2tMB5+jCG2mYx+?=
 =?us-ascii?Q?86Dj31FWHE3NV7tJRy8NU/Ftxqo7oy+bdS5xHUFpBHHGZSE1HU1CIvZeU9DQ?=
 =?us-ascii?Q?msQQern2+66l48hOPnpBcEpesQqqz3OYtkhJkmBx0/5UdYiuCN7OdGln4Egw?=
 =?us-ascii?Q?Vp6kGXhSDs55va1orBiizyCOKoZr/bdgUnZT3eo3ungePD57r+FcJ2zpbUyg?=
 =?us-ascii?Q?na2iJSrT9sHnPqldvDzDWuf+XqemuoUWhXMllKJNcm0tzaMPXL07uevMb3gq?=
 =?us-ascii?Q?4xKq3o998X+6rvIzOtMfLGVj9559g8AADqCaR2rDuOIeUhMkXMBrPFDaQAZc?=
 =?us-ascii?Q?88OC+XzAHhsmrAT0pJLh0tkdavi05mz3cYoMrDdbIOOc/LFChDKcvNG9GdDP?=
 =?us-ascii?Q?XekWa4VNDXR1cfRLWn8hSfJdZ9uWk4bK7KvsqNKcO2XXCMBVwM4rxlB5IAtu?=
 =?us-ascii?Q?IjUijkh1Sxxlo5bFfK+ShICBNfVRr9jEbFWS5J5A+nmA/dXh4OuFqsBUdhcp?=
 =?us-ascii?Q?w2KlD+VQNqbR8imzXYBXdA5R8pHMYb1KIwFDAXoYKYO70mquGmUiMB/qsfV+?=
 =?us-ascii?Q?Zo9GiZ7lmmKpXnZK4ptanUOvzvNFL9ND58K2NGC5R0mX+/DlrsZuoPxSq75E?=
 =?us-ascii?Q?7S2+ixXMRJ5WCseR9DqPw6cCjGNYoeQOOJVvNX/cSDo/BnW0lEfOwiIIu17y?=
 =?us-ascii?Q?nXx1nWSQLDYCAQN6YFAcQwujNnNS1q0hbyG46auAQ0Njz8RbDTHT4F3RA7Rv?=
 =?us-ascii?Q?aKkmWOZ3A4S7jP58Jh3+BmnbQp2fEQyaKgyUcJeJmJ4WIw1eaaYx0r++dDny?=
 =?us-ascii?Q?zA2nc6P3CqZ2n/hcPXa1FLqW4iFmZnFGRkBqH9nuZ9b4pfR74hzM15F1Ol2c?=
 =?us-ascii?Q?RgijZ9hv+VQ67SQbow37v+eJ9zw1JhFqctbWjTOQxsD4+OWwze5su5brLVoJ?=
 =?us-ascii?Q?Yqp7OwPxuacwGjAnPf/QO6lRWwim30LtKiZpXRUaNLGIfK15hUOrtDJiyXnW?=
 =?us-ascii?Q?9v7wCCn4retsCUt3A/3v4ZS16/3TpQgZtaSL6jfoo5hwjilbhmGMtDKS6C29?=
 =?us-ascii?Q?ztKVOeC+dbcNm5Ku8cnMHOsKFG6QxsiDKLlAKAGq3k5T09j3e1VPnI1vN72M?=
 =?us-ascii?Q?36/0A0Jar6GRUn+iPl4jAn0aquNoSyhvDe7GUGiuGuX2jpTCssih9ty/GJzJ?=
 =?us-ascii?Q?tFm11Uy9p0qsifeInUaeBxXvBBG1yxLeFe8BukEFJLiPRujqmF4ddOzZ6YCU?=
 =?us-ascii?Q?c88L1ixD+TOe2UbuDqI54iKDE0ZkT6PyvQOdG/NKU8ZvhrmOWa8VS6J7jgDV?=
 =?us-ascii?Q?zzw0E5tiV/fq2U36pNW6LJ9dSt2OaV6pGiJhno8tkhH5XBdK1wCw35g1vZyd?=
 =?us-ascii?Q?AwjQ6PuHSgW41qcwqYpqlZ+V4MfhyMa1qbgO1rDIueb2XXJLBMnJJo3s0ccB?=
 =?us-ascii?Q?EtWZ2QnHouKkF5mZdVOFP08/pIRI0fjEfvoTAcQpDYVgenEFGuWYRsmp+LR3?=
 =?us-ascii?Q?QAkxWp5HLWpDeaBG0/AQosg=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72f68215-4258-444d-da21-08d99999b244
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2021 22:32:45.1597
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MAmYOHuWD9r8gCpkEpNlRii+w4ptVrs4/fhBny/wV1okC1xghD2kdLUdqpHZyGASNtx9qe8HqRoox/mlQ+hZEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1314
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 25, 2021 at 08:20:18PM +0530, Naveen Krishna Chatradhi wrote:
...
> @@ -3726,10 +3944,21 @@ static struct amd64_family_type *per_family_init(struct amd64_pvt *pvt)
>  			pvt->ops = &family_types[F17_M70H_CPUS].ops;
>  			pvt->fam_type->ctl_name = "F19h_M20h";
>  			break;
> +		} else if (pvt->model >= 0x30 && pvt->model <= 0x3f) {
> +			if (pvt->mc_node_id >= amd_cpu_node_count()) {
> +				pvt->fam_type = &family_types[ALDEBARAN_GPUS];
> +				pvt->ops = &family_types[ALDEBARAN_GPUS].ops;
> +				pvt->is_gpu = true;
> +			} else {
> +				pvt->fam_type = &family_types[F19_CPUS];
> +				pvt->ops = &family_types[F19_CPUS].ops;
> +				family_types[F19_CPUS].ctl_name = "F19h_M30h";
> +			}
> +		} else {
> +			pvt->fam_type	= &family_types[F19_CPUS];
> +			pvt->ops	= &family_types[F19_CPUS].ops;
> +			family_types[F19_CPUS].ctl_name = "F19h";
>  		}
> -		pvt->fam_type	= &family_types[F19_CPUS];
> -		pvt->ops	= &family_types[F19_CPUS].ops;
> -		family_types[F19_CPUS].ctl_name = "F19h";
>  		break;
>  

Why move these lines into the else clause above?

Thanks,
Yazen