Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211026224354.GA13009@raspberrypi> <f675255eae2bc97bc571f7e798a952ea3d24e4d6.camel@linux.ibm.com>
In-Reply-To: <f675255eae2bc97bc571f7e798a952ea3d24e4d6.camel@linux.ibm.com>
From:   Austin Kim <austindh.kim@gmail.com>
Date:   Thu, 28 Oct 2021 10:48:46 +0900
Message-ID: <CADLLry7fhBazjgBJovqAwxyVdvUPLifLRxgwZwSAifQY6HGThg@mail.gmail.com>
Subject: Re: [PATCH] ima/evm: mark evm_fixmode as __ro_after_init
To:     Mimi Zohar <zohar@linux.ibm.com>
Cc:     James Morris <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        linux-integrity@vger.kernel.org,
        linux-security-module <linux-security-module@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?6rmA64+Z7ZiE?= <austin.kim@lge.com>,
        kernel-team@lge.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello Mimi,

2021=EB=85=84 10=EC=9B=94 28=EC=9D=BC (=EB=AA=A9) =EC=98=A4=EC=A0=84 9:27, =
Mimi Zohar <zohar@linux.ibm.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> Hi Austin,
>
> The subject line should be just "evm:".
>
> On Tue, 2021-10-26 at 23:43 +0100, Austin Kim wrote:
> > From: Austin Kim <austin.kim@lge.com>
> >
> > evm_fixmode global variable is never modified
> > outside initcalls, so declaring it with __ro_after_init is better.
>
> Please properly format the text.  From
> Documentation/process/submitting-patches.rst:
>
>   - The body of the explanation, line wrapped at 75 columns, which will
>     be copied to the permanent changelog to describe this patch.

Thanks for feedback.
let me resend the patch after updating "subject line" and checking text-for=
mat.

BR,
Austin Kim

>
> >
> > Signed-off-by: Austin Kim <austin.kim@lge.com>
>
> Otherwise,
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
>