Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 28 Oct 2021 16:59:12 +0900
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     David Lechner <david@lechnology.com>
Cc:     linux-iio@vger.kernel.org, Robert Nelson <robertcnelson@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/8] docs: counter: add unit timer sysfs attributes
Message-ID: <YXpYUIUIQe+oxwXK@shinobu>
References: <20211017013343.3385923-1-david@lechnology.com>
 <20211017013343.3385923-5-david@lechnology.com>
 <YXj1xc6DdeOrUKjW@shinobu>
 <6e96cdd9-d1f1-6861-59eb-c4e6b9a2ffb9@lechnology.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="79xH+X/itCG/Y5or"
Content-Disposition: inline
In-Reply-To: <6e96cdd9-d1f1-6861-59eb-c4e6b9a2ffb9@lechnology.com>
Precedence: bulk


--79xH+X/itCG/Y5or
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 27, 2021 at 10:30:36AM -0500, David Lechner wrote:
> On 10/27/21 1:46 AM, William Breathitt Gray wrote:
> > On Sat, Oct 16, 2021 at 08:33:39PM -0500, David Lechner wrote:
> >> This documents new unit timer sysfs attributes for the counter
> >> subsystem.
> >>
> >> Signed-off-by: David Lechner <david@lechnology.com>
> >=20
> > Hello David,
> >=20
> > The unit timer is effectively a Count in its own right, so instead of
> > introducing new sysfs attributes you can just implement it as another
> > Count in the driver. Count 0 is "QPOSCNT", so set the name of this new
> > Count 1 as "Unit Timer" (or the datasheet naming if more apt) to
> > differentiate the Counts. You can then provide the "unit_timer_enable",
> > "unit_timer_period", and "unit_timer_time" functionalities as respective
> > Count 1 extensions ("enable" and "period") and Count 1 "count".

Actually if the counter function here is COUNTER_FUNCTION_DECREASE, then
instead of introducing a new "period" extension, define this as a
"ceiling" extension; that's what ceiling represents in the Counter
interface: "the upper limit for the respective counter", which is the
period of a timer counting down to a timeout.

William Breathitt Gray

> >=20
> > If you believe it appropriate, you can provide the raw timer ticks via
> > the Count 1 "count" while a nanoseconds interface is provided via a
> > Count 1 extension "timeout" (or something similar).
> >=20
>=20
> Sounds reasonable.
>=20

--79xH+X/itCG/Y5or
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmF6WFAACgkQhvpINdm7
VJJGaw/9FMQQqedX6WSzBBOZ4Rdrp6CWG/0QpTwrcCh//QK6p6xnOKWl/E0ra83Z
HALAoo6k5KN+8Cq+6mYd/XGuKKacpeXREtnE9dy/Sbsa2RNHmYwODVKB+gQiC0BR
QD6b+8eFEfW3h9x3vW7lvzwjV9UmCO83uqeHsZu2KU0jRUHjcxIiWeoWaMhaTNRx
qltz1gGLi4BHoXNiA66AnqUc7QZUhmEjUU7N0fQ65hBC4NQEUNzSN1l+o6SrdBxu
8MKipszR4Kz1SlPAMU4h/LZKUgOPuth1x/ptd1GpiSqrd2OaKT3seRnGUC4/Zkl7
U03EZkzrJvodq75KeTq+ITansSDYABz1DcB7VYt2JdBIcjC4O8GBV/phivybeYHs
Gopj2A4JmfjUbibQItFZiezEmTOkJ2icpZ+YNPnZRQMPKmpdNqtWS1PoPXLCzAYi
yV49oUPD/BPISA7LrMU/cMyKrdkptrsek74ECa3N79eCWFbYzm6tLaTzI/mVjK/D
crQbceWAAGftLPCVtYEIYdLwB24/vPW+CtcvulRXfnbJy/vo3Ouu7P5uXrYVISz/
4CHqfneiC0UNdf/xtnMe+H5YRUGZpAvdGOcb95xFz0nJWIkeEpl/Nb5QKw9bhp1f
ZLyvfvEvaz+lmbyWqZ5p/+0fiZdtzvZijfIdAaUPUPJrHNUav5w=
=izg9
-----END PGP SIGNATURE-----

--79xH+X/itCG/Y5or--