Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750787AbXACPCS (ORCPT ); Wed, 3 Jan 2007 10:02:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750828AbXACPCR (ORCPT ); Wed, 3 Jan 2007 10:02:17 -0500 Received: from dev.mellanox.co.il ([194.90.237.44]:36493 "EHLO dev.mellanox.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbXACPCQ (ORCPT ); Wed, 3 Jan 2007 10:02:16 -0500 Date: Wed, 3 Jan 2007 17:00:13 +0200 From: "Michael S. Tsirkin" To: Steve Wise Cc: Roland Dreier , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, openib-general@openib.org Subject: Re: [PATCH v4 01/13] Linux RDMA Core Changes Message-ID: <20070103150013.GO6019@mellanox.co.il> Reply-To: "Michael S. Tsirkin" References: <1167836172.4187.9.camel@stevo-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1167836172.4187.9.camel@stevo-desktop> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1042 Lines: 31 > > > > No, it won't need 2 transitions - just an extra function call, > > so it won't hurt performance - it would improve performance. > > > > ib_uverbs_req_notify_cq would call > > > > ib_uverbs_req_notify_cq() > > { > > ib_set_cq_udata(cq, udata) > > ib_req_notify_cq(cq, cmd.solicited_only ? > > IB_CQ_SOLICITED : IB_CQ_NEXT_COMP); > > } > > > > ib_set_cq_udata() would transition into the kernel to pass in the > consumer's index. In addition, ib_req_notify_cq would also transition > into the kernel since its not a bypass function for chelsio. We misunderstand each other. ib_uverbs_req_notify_cq is in drivers/infiniband/core/uverbs_cmd.c - all this code runs inside the IB_USER_VERBS_CMD_REQ_NOTIFY_CQ command, so there is a single user to kernel transition. -- MST - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/