Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: yty8zBVIjgtCtz9mlh4VOpVaraBtaIwXR43SXtqVi4Z2aTxe5IeCShX5JgUlGtfCL0p8NG5/B4
 WAmFTQytlmG3zIIt4OstqR6SuscnqgoSpaCcIHapXJlBtPO1NpT43z04jXR0ryh7xjwjnHwh3I
 siW5OEQAOd5ixyb/RRcctAbvbJh3c7mA5jvkqng+8RznHnn5GQ9Tmlo5qO7btwqVy1FPN2bFG0
 q6QF3vDgAeC7e6TYgHYlxY7x9BpkOFl6ZSGEkpYb1YZa3ZeFMQlaxRFRhcZixtL6PJD6FXRsA2
 WxCAhz2RtNc8RCDok0IKhoqp
Date:   Thu, 28 Oct 2021 10:57:47 +0200
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Vinod Koul <vkoul@kernel.org>
CC:     Alexandre Belloni <alexandre.belloni@bootlin.com>, <kishon@ti.com>,
        <robh+dt@kernel.org>, <andrew@lunn.ch>,
        <linux-phy@lists.infradead.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] phy: Add lan966x ethernet serdes PHY driver
Message-ID: <20211028085747.hhpbcfaevmt4wrl2@soft-dev3-1.localhost>
References: <20211015123920.176782-1-horatiu.vultur@microchip.com>
 <20211015123920.176782-4-horatiu.vultur@microchip.com>
 <YW8HIHTCVgB+URJ5@matsya>
 <20211020091733.fxph2pq3xa3byvry@soft-dev3-1.localhost>
 <YXA3VVUGEjUR4HDC@matsya>
 <YXA6lZBTeA6aNxVD@piout.net>
 <YXEEcJHuEdFLPyCU@matsya>
 <20211021091032.ffaoncg5jjdwdeyg@soft-dev3-1.localhost>
 <YXGoGtbFeKa+TVk2@matsya>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <YXGoGtbFeKa+TVk2@matsya>
Precedence: bulk

The 10/21/2021 23:19, Vinod Koul wrote:
> 
> On 21-10-21, 11:10, Horatiu Vultur wrote:
> > The 10/21/2021 11:40, Vinod Koul wrote:
> > >
> > > On 20-10-21, 17:49, Alexandre Belloni wrote:
> > > > On 20/10/2021 21:05:49+0530, Vinod Koul wrote:
> > > > > > > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > > > > > >
> > > > > > > Any reason why this is dual licensed, why not GPL only?
> > > > > >
> > > > > > No reason, I think I copy this from a different file.
> > > > >
> > > > > Please have a chat with your lawyers on the correct license this should
> > > > > have!
> > > > Dual GPL and MIT was Microsemi's policy, I'm not sure it carried over to
> > > > Microchip.
> > >
> > > That is why they need to talk to someone and decide what license
> > > applies :)
> >
> > I have changed it to be the same as the one on sparx5 because also
> > sparx5 is a Microchip product. On sparx5 we used:
> > 'SPDX-License-Identifier: GPL-2.0-or-later'
> 
> Has the code been copied/derived from somewhere/auto generated from
> scripts/tools or entirely written by you?

Sorry for late reply, but I was out of office without access to the
emails.

The register file 'lan966x_serdes_regs.h' was autogenerated from some
internal scripts. Which takes the info from here [1] and generates these
header files. The reason why we generate them is that is more error proof
that writting them manually. We are doing the same for sparx5
registers[2]

The other file 'lan966x_serdes.c' was entirely written by me.

[1] https://github.com/microchip-ung/lan9668_reginfo
[2] https://elixir.bootlin.com/linux/latest/source/drivers/phy/microchip/sparx5_serdes_regs.h

> 
> --
> ~Vinod

-- 
/Horatiu