Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\))
Subject: Re: [RFC] mmc: core: transplant ti,wl1251 quirks from to be retired
 omap_hsmmc
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
In-Reply-To: <1EF25CD6-7801-4C15-AB4C-5F499948A653@goldelico.com>
Date:   Thu, 28 Oct 2021 11:43:43 +0200
Cc:     Ulf Hansson <ulf.hansson@linaro.org>,
        Avri Altman <avri.altman@wdc.com>,
        Shawn Lin <shawn.lin@rock-chips.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bean Huo <beanhuo@micron.com>, linux-mmc@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Discussions about the Letux Kernel 
        <letux-kernel@openphoenux.org>, kernel@pyra-handheld.com,
        Tony Lindgren <tony@atomide.com>,
        Linux-OMAP <linux-omap@vger.kernel.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <920CFF1F-475C-4403-B563-DDD144F7E52D@goldelico.com>
References: <8ecc5c79c1dd0627d570ede31e18c860786cacca.1633519499.git.hns@goldelico.com>
 <CAPDyKFp47sAXhM2s5HOqV2wLf-kYRhdqSdzcn7a62ZW23SSPdg@mail.gmail.com>
 <470A96FD-DB24-4C32-BC9F-AE2F617FBF2D@goldelico.com>
 <2013308.OSlt1BDEiP@pc-42>
 <1EF25CD6-7801-4C15-AB4C-5F499948A653@goldelico.com>
To:     =?utf-8?B?SsOpcsO0bWUgUG91aWxsZXI=?= <jerome.pouiller@silabs.com>
Precedence: bulk


> Am 28.10.2021 um 11:40 schrieb H. Nikolaus Schaller =
<hns@goldelico.com>:
>=20
> Hi J=C3=A9r=C3=B4me,
>=20
>> Am 28.10.2021 um 10:59 schrieb J=C3=A9r=C3=B4me Pouiller =
<jerome.pouiller@silabs.com>:
>>=20
>> Hi Nikolaus,
>>=20
>> On Thursday 28 October 2021 09:08:50 CEST H. Nikolaus Schaller wrote:
>>=20
>>>> Let me have a closer look - and for sure, I am willing to help if =
needed.
>>=20
>> I confirm it does not have the expected behavior. =
!mmc_fixup_of_compatible_match()
>> should be mmc_fixup_of_compatible_match(), sorry.
>=20
> Ok, I see.
>=20
> One more question: how can I specify "ti,wl1251" in some struct =
mmc_fixup table?
> Does it need another macro like MMC_FIXUP() or SDIO_FIXUP() to set the =
.name
> field?
>=20
>>>=20
>>> Combining your suggestions we could do roughly:
>>>=20
>>> in mmc_sdio_init_card():
>>>=20
>>>       if (host->ops->init_card)
>>>               host->ops->init_card(host, card);
>>>       else
>>>               mmc_fixup_device(host, sdio_prepare_fixups_methods);
>>=20
>> I think I mostly agree, but why you don't call mmc_fixup_device() if
>> init_card is defined? (BTW, mmc_fixup_device() takes a card as
>> first parameter)
>=20
> Because I want to get rid of init_card. It is host specific and not =
client
> specific.

Ah, on a second though we can do that independently. Either there is
some init_card - or something in the fixup tables. Why not both...
So the else clause is not needed.

And you are right, the first parameter should be card`.

>=20
>>=20
>>=20
>>> Next we need a location for the sdio_prepare_fixups_methods table =
and functions.
>>>=20
>>> For "ti,wl1251" we would then provide the entry in the table and a =
function doing
>>> the setup. But where should these be defined? Likely not in a header =
file like
>>> quirks.h? But there is no quirks.c.
>>=20
>> I think you can place your function in drivers/mmc/core/card.h. There =
are
>> already add_quirk(), add_limit_rate_quirk(), add_quirk_mmc(), etc...
>=20
> Ok. Would be some add_wl1251_quirk() then.
>=20
> BR and thanks,
> Nikolaus
>=20