Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 28 Oct 2021 08:17:38 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     John Garry <john.garry@huawei.com>
Cc:     Jiri Olsa <jolsa@redhat.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "irogers@google.com" <irogers@google.com>,
        "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kjain@linux.ibm.com" <kjain@linux.ibm.com>,
        "james.clark@arm.com" <james.clark@arm.com>
Subject: Re: [PATCH v2 2/2] perf jevents: Enable warnings through HOSTCFLAGS
Message-ID: <YXqG0jb4qg4+x5DE@kernel.org>
References: <1634807805-40093-1-git-send-email-john.garry@huawei.com>
 <1634807805-40093-3-git-send-email-john.garry@huawei.com>
 <YXFhr2YoVp9GPsDM@krava>
 <86aee893-0b6b-bce3-d1aa-3b66365592d1@huawei.com>
 <YXaXvGgvs4gr8Cgi@krava>
 <YXbZa8SaQta9pzHS@kernel.org>
 <32d98804-7e56-e73b-4c66-8776dbf58ddf@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <32d98804-7e56-e73b-4c66-8776dbf58ddf@huawei.com>
Precedence: bulk

Em Thu, Oct 28, 2021 at 09:23:58AM +0100, John Garry escreveu:
> On 25/10/2021 17:20, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Oct 25, 2021 at 01:40:44PM +0200, Jiri Olsa escreveu:
> > > On Fri, Oct 22, 2021 at 10:42:11AM +0100, John Garry wrote:
> > > > On 21/10/2021 13:48, Jiri Olsa wrote:
> > > > ok, so IIRC, then the rule for building .o from .c in
> > > > tools/build/Makefile.build will pick up HOSTCFLAGS through this variable, so
> > > > we then don't need to explicitly mention it in the per-target rule, so can
> > > > have this as before in pmu-events/Build

> > > > HOSTCFLAGS_jevents.o	= -I$(srctree)/tools/include

> > > > right?

> > > > (Indeed I guess that we can get rid of -I$(srctree)/tools/include as well)

> > > hm, the -I.. should stay no? I don't see that
> > > it's being added soem other way

> > Probably this change from KBUILD_HOSTCFLAGS back to HOSTCFLAGS should
> > come with this;

> > Cc: Laura Abbott <labbott@redhat.com>
> > Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> > Fixes: 96f14fe738b69dd9 ("kbuild: Rename HOSTCFLAGS to KBUILD_HOSTCFLAGS")

> > Right?
 
> Maybe, but then renaming back from KBUILD_HOSTCFLAGS -> HOSTCFLAGS seems odd
> as a fix
 
> Anyway, now that this original series is in perf/core,

Nope, just this one landed:

commit 342cb7ebf5e29fff4dc09ab2c8f37d710f8f5206
Author: John Garry <john.garry@huawei.com>
Date:   Thu Oct 21 17:16:44 2021 +0800

    perf jevents: Fix some would-be warnings

---

The one you asked to wait for further discussion wasn't merged.

- Arnaldo

> I'll send patches on top with this change, cc'ing Laura and Masahiro