Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 28 Oct 2021 14:30:39 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     "huangguangbin (A)" <huangguangbin2@huawei.com>
Cc:     davem@davemloft.net, kuba@kernel.org, wangjie125@huawei.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        lipeng321@huawei.com, chenhao288@hisilicon.com
Subject: Re: [PATCH net 1/7] net: hns3: fix pause config problem after
 autoneg disabled
Message-ID: <YXqX7z2GljD6bxTr@lunn.ch>
References: <20211027121149.45897-1-huangguangbin2@huawei.com>
 <20211027121149.45897-2-huangguangbin2@huawei.com>
 <YXmLA4AbY83UV00f@lunn.ch>
 <09eda9fe-196b-006b-6f01-f54e75715961@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <09eda9fe-196b-006b-6f01-f54e75715961@huawei.com>
Precedence: bulk

> Hi Andrew, thanks very much for your guidance on how to use pause autoneg,
> it confuses me before because PHY registers actually have no separate setting
> bit of pause autoneg.
> 
> So, summarize what you mean:
> 1. If pause autoneg is on, driver should always use the autoneg result to program
>    the MAC. Eventhough general autoneg is off now and link state is no changed then
>    driver just needs to keep the last configuration for the MAC, if link state is
>    changed and phy goes down and up then driver needs to program the MAC according
>    to the autoneg result in the link_adjust callback.
> 2. If pause autoneg is off, driver should directly configure the MAC with tx pause
>    and rx pause. Eventhough general autoneg is on, driver should ignore the autoneg
>    result.
> 
> Do I understand right?

Yes, that fits my understanding of ethtool, etc.

phylink tried to clear up some of these problems by fully implementing
the call within phylink. All the MAC driver needs to provide is a
method to configure the MAC pause settings. Take a look at
phylink_ethtool_set_pauseparam() and the commit messages related to
that.

	Andrew