Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH RESEND] ASoC: fix unmet dependencies on GPIOLIB for
 SND_SOC_DMIC
To:     Julian Braha <julianbraha@gmail.com>, broonie@kernel.org,
        perex@perex.cz, tiwai@suse.com,
        pierre-louis.bossart@linux.intel.com
Cc:     linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        fazilyildiran@gmail.com
References: <20211027184835.112916-1-julianbraha@gmail.com>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
Message-ID: <6ff76018-309d-349e-691a-f504ca29420e@amd.com>
Date:   Thu, 28 Oct 2021 18:09:40 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.13.0
In-Reply-To: <20211027184835.112916-1-julianbraha@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGE0OVRud2pmY2VsMDNFVGN3YmM2amZhdGVwSTFLajh0d1JlaVNFM1lMOEpZ?=
 =?utf-8?B?bXZzSDU5SDA5MWg3Z0ZueTBKenU2bHl4Q3A2b0o0d2hrZ2owaGxwYmszZ3dj?=
 =?utf-8?B?VERJcVJXaUo5dmVOZk8rRDN2QjdWM013SFB3dG45Uml2MjNmV1hmbzlaclpL?=
 =?utf-8?B?WkdhSWhJNVd4Tk5kY1pJZllhOGp6RTdKYmlZNlVHSk9jbVB6WnZIM1d0S2FZ?=
 =?utf-8?B?UGlrL1dZak9uZm1uZnh4V25zVWovYU16SjJHRHRGRDcxREZBUFY1L1pqbmNW?=
 =?utf-8?B?a09zZWRwam0vTTRDdlBpSXJRdTJUdzRoOEgrUHRjK2xSeUJGMjJjRnBwcVFz?=
 =?utf-8?B?U0JSdi9yRFcyS2tqSXVFUERkRldXUWFoVkFqUGYxMjhMRU5mYWFOL3BqQ1Vv?=
 =?utf-8?B?Y2tUbjQrZ1IyYjM3clBmQTVEZ2kxRGpBY0RJZVVlQ2lYbUlpZ21XTWxCTUM3?=
 =?utf-8?B?Uk1mYUFWemtvL2N3UzhUdllabEx4K0VMcXZOdGszS3JqeGhyaVB5emUzYjZs?=
 =?utf-8?B?SWtQeGJIV3NMemgraUJLVTcrSW1lNTJZL0dhY2FzeXY0QUE1MWdwOFJiVlla?=
 =?utf-8?B?Qm5VYzg4Z3pRM2QxY0R1Nk1leDZZTGhPT0xralNXclQ2b1d3ejA2UUZNMk1N?=
 =?utf-8?B?VVQzc2pXY1FpQTFjRCtDa3RicEZtZTdWUVFnV1JLMDV1Y0FxVy9EY2pLS25G?=
 =?utf-8?B?S2x0WDVIck5QOS9SNCsxUXFranE5RENoaDl3QTAxbk9TbkpGVCsvS0NxVmNY?=
 =?utf-8?B?MTVRaVdZS1M0S0VpVzg0RXlPb01tUHY3bGIvTnRhUmVkdjNLYTRuTGpMbmdz?=
 =?utf-8?B?Tm1hS240ODN0VFcwclVuMTJUSm05Zk5KbGhjWkVXdVBWNnNpUlRRazB6NHNr?=
 =?utf-8?B?eWxvN3ZTUXVuZWRpNUQ1aHFiaXVzQWpLRDFOK2hkSXNpZyt3em4vaG5zdG1W?=
 =?utf-8?B?K2hTUk9mQUNnWmlJc3g4VWp0cVJkc1F6OU9BZzFzNWF2OWR3aU9xUU9CMjln?=
 =?utf-8?B?NlByMGtrMmk1T2JqLzRzelQxZzdFSE1EQ25BZ0NseSsvdmJKc2dzZ0FGK0FR?=
 =?utf-8?B?MUM4M1hxNlA4cldnVjkzYjd0Z0NMYlIzREN0Y1BEWXgvTkt2V0tpblMxT3gx?=
 =?utf-8?B?WmxoZFFLUFpla21lYWlTQ1JPMnF1dGpySkJ3UkptSUVjeUZwYVErNGlSOUhq?=
 =?utf-8?B?ak14MzhvUEs1eDdYNUJSRkM0VzF2bWhtWXdYL3ZES0hQTnBXcFNKbmg5bkly?=
 =?utf-8?B?VGhMdlQwdWdFRGxXZTFUZUxCTnFyVFgxbTJKdUYzVmNiem1SeHU3STFqUFdP?=
 =?utf-8?B?K3RQTlV0MjBDeUpORHdSYWRobFpFZlRWa1hiRlVaS1NNU1ZYSVF1N3hnRnBO?=
 =?utf-8?B?QVJUL1FtWUpYeXNWNHI0NENCa1E5dkVRcXVTdSt6dHV4UXN5RG4zVEh4OFc0?=
 =?utf-8?B?TllLeHoyM1orRHlhTW8yWmR4OGFPcmtyOXpIQzVVTGZFdldsTVF6b1F6SGYr?=
 =?utf-8?B?ZjRnekZvTlNZWGZrRVZNZnppaFc5K0tTcGNiV0JyaXpobmJFOEFKNW9uWkIw?=
 =?utf-8?B?REVNSjhpOHJXbC96Nm93VlhoNFVyQzU1MFZsNzg4aXVmOWZvaWlYcnduWmhk?=
 =?utf-8?B?S0IyYnBsbHZTZVcrZGRzbHo1SDNVWEdYRkpleHQ0dmt3UThlejlQMTNvSjBv?=
 =?utf-8?B?aFdYUXlNbWI1d2w5RCtJQ0dkdmtGbzJ3UW9RQisrVmJSTkQwemdIRkdEUU16?=
 =?utf-8?B?OG1yU2hVTnk2UVU3Z2RQT1MxcVAxV0c5QytnZjRqWEJLTXB6Z1dlSFZVWllw?=
 =?utf-8?B?STI0MlRPKzcwMlZYRm96NSthY1IvbytjcmxzWTRtdHRyVkszZDBlTEM3WjVO?=
 =?utf-8?B?b3N5SHVBVEx3aTlZQ0VLRE9qK1ZTQ0JzUUwzZERGOElRQXAzRHpPQmxma0xp?=
 =?utf-8?B?V0lnMXVsYnlMQlZicVdGOFoxVWd0UmRkTnRubDBpOW1vWmQ3cjFUREoza0R0?=
 =?utf-8?B?V05rRUxVQ0M2ZUNlSU9Wb1RJRERxSzdINVViZGU2Y0IycU9KamRjcEV6c0pU?=
 =?utf-8?B?QU0zK1VGNTh2UG5vdTNVOHFGcXovRUxiOC9xRnYzcnY1R2ZXTW1RMnZGQnVW?=
 =?utf-8?B?ZUYzRU1tY1lkalVJK05ZK3BmL1pqdnZQZDVjVVhHWUFHK3NKMnhTUG5USU1C?=
 =?utf-8?Q?ujnK4jAB4gdzqOivF1fvnlI=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5042aca9-cae7-4126-7838-08d99a100c8e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 12:39:57.2006
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2TAXE6enNUUcklLTYxm9CCYmZWOK2ekQEMFYmlL2ODhtJcK2RTxFoPJD53vPNfZtrptXRk0uKk6TneZ0oDem7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4465
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/28/21 12:18 AM, Julian Braha wrote:
> When SND_SOC_AMD_RENOIR_MACH or SND_SOC_AMD_RV_RT5682_MACH
> are selected, and GPIOLIB is not selected, Kbuild gives
> the following warnings, respectively:
> 
> WARNING: unmet direct dependencies detected for SND_SOC_DMIC
>   Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
>   Selected by [y]:
>   - SND_SOC_AMD_RENOIR_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AMD_RENOIR [=y]
> 
> and
> 
> WARNING: unmet direct dependencies detected for SND_SOC_MAX98357A
>   Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
>   Selected by [y]:
>   - SND_SOC_AMD_RV_RT5682_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AMD_ACP3x [=y] && I2C [=y] && CROS_EC [=y]
> 
> This is because SND_SOC_DMIC and SND_SOC_MAX98357A are
> selected by SND_SOC_AMD_RV_RT5682_MACH and SND_SOC_AMD_RENOIR_MACH,
> respectively. However, neither of the selectors depend on or select GPIOLIB,
> despite their selectees depending on GPIOLIB.
> 
> These unmet dependency bugs were detected by Kismet,
> a static analysis tool for Kconfig. Please advise if this
> is not the appropriate solution.
> 
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
>  sound/soc/amd/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index 56e7c079deac..2c6af3f8f296 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -38,7 +38,7 @@ config SND_SOC_AMD_RV_RT5682_MACH
>  	select I2C_CROS_EC_TUNNEL
>  	select SND_SOC_RT1015
>  	select SND_SOC_RT1015P
> -	depends on SND_SOC_AMD_ACP3x && I2C && CROS_EC
> +	depends on SND_SOC_AMD_ACP3x && I2C && CROS_EC && GPIOLIB
>  	help
>  	 This option enables machine driver for RT5682 and MAX9835.
> 
> @@ -51,7 +51,7 @@ config SND_SOC_AMD_RENOIR
>  config SND_SOC_AMD_RENOIR_MACH
>  	tristate "AMD Renoir support for DMIC"
>  	select SND_SOC_DMIC
> -	depends on SND_SOC_AMD_RENOIR
> +	depends on SND_SOC_AMD_RENOIR && GPIOLIB
For Renoir platform, DMIC driver selected for registering codec dai with
ASOC. No additional functionality handled related to GPIO.
Do you still see necessity adding GPIOLIB dependency?

>  	help
>  	 This option enables machine driver for DMIC
> 
> --
> 2.30.2
>