Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 28 Oct 2021 13:49:22 +0100 (BST)
From:   "Maciej W. Rozycki" <macro@orcam.me.uk>
To:     Johan Hovold <johan@kernel.org>
cc:     cgel.zte@gmail.com,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        jirislaby@kernel.org, fancer.lancer@gmail.com, andrew@aj.id.au,
        pali@kernel.org, linux-serial@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jing Yao <yao.jing2@zte.com.cn>,
        Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] drivers: tty: replace snprintf in show functions with
 sysfs_emit
In-Reply-To: <YXqV9V0eWhqFTc+i@hovoldconsulting.com>
Message-ID: <alpine.DEB.2.21.2110281342290.61663@angie.orcam.me.uk>
References: <20211028101350.14172-1-yao.jing2@zte.com.cn> <YXqV9V0eWhqFTc+i@hovoldconsulting.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 28 Oct 2021, Johan Hovold wrote:

> Where's the commit message?

 Or to put it explicitly: please always include a full description of any 
change submitted, where you explain what your change is needed for and why 
you have made it like this.

 Please refer to Documentation/process/submitting-patches.rst in the 
source tree for a full recipe for submitting patches, which says, among 
others:

"[...] The text should be written in such detail so that when read
weeks, months or even years later, it can give the reader the needed
details to grasp the reasoning for **why** the patch was created."

 Thanks,

  Maciej