Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 28 Oct 2021 13:51:59 +0100
From:   Mauro Carvalho Chehab <mchehab@kernel.org>
To:     Tsuchiya Yuto <kitakar@gmail.com>
Cc:     Hans de Goede <hdegoede@redhat.com>,
        Patrik Gfeller <patrik.gfeller@gmail.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Hans Verkuil <hverkuil-cisco@xs4all.nl>,
        Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>,
        Dinghao Liu <dinghao.liu@zju.edu.cn>,
        Alan <alan@linux.intel.com>, linux-media@vger.kernel.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/17] various fixes for atomisp to make it work
Message-ID: <20211028135159.7ac3f263@sal.lan>
In-Reply-To: <20211017161958.44351-1-kitakar@gmail.com>
References: <20211017161958.44351-1-kitakar@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

Em Mon, 18 Oct 2021 01:19:40 +0900
Tsuchiya Yuto <kitakar@gmail.com> escreveu:

> Hi all,
> 
> This patch series contains fixes for atomisp to work (again). Tested on
> Microsoft Surface 3 (Windows) and Xiaomi Mi Pad 2 (Android model) with
> v5.15-rc5. Both are Cherry Trail (ISP2401) devices.
> 
After testing this series, I'm opting to merge most patches at the media 
stage tree:

	https://git.linuxtv.org/media_stage.git/log/

That would allow more people to test the changes.

It is probably too late to merge it for 5.16, so I'll likely postpone
merging it at media_tree to happen after 5.16-rc1.

Regards,
Mauro

---

I tested it on an Asus T101HA with:
	https://github.com/intel/nvt

compiled with -m64, and with the enclosed script:


#!/bin/bash
set -e

FRAMES=10

FORMAT=NV12
WIDTH=1600
HEIGHT=1200

#FORMAT=NV12
#WIDTH=1920
#HEIGHT=1080


./v4l2n -o testimage_@.raw \
                 --device /dev/video2 \
                 --input 0 \
                 --exposure=30000,30000,30000,30000 \
                 --parm type=1,capturemode=CI_MODE_PREVIEW \
                 --fmt type=1,width=$WIDTH,height=$HEIGHT,pixelformat=$FORMAT \
                 --reqbufs count=2,memory=USERPTR \
                 --parameters=wb_config.r=32768,wb_config.gr=21043,wb_config.gb=21043,wb_config.b=30863 \
                 --capture=$FRAMES

for i in $(seq 0 $(($FRAMES - 1))); do
	name="testimage_$(printf "%03i" $i)"

	./raw2pnm -x$WIDTH -y$HEIGHT -f$FORMAT $name.raw $name.pnm

	rm $name.raw
done