Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211026225527.3460520-1-robh@kernel.org> <361311a6-5818-6fc8-56d9-1a0ab8eaa74b@gmail.com>
In-Reply-To: <361311a6-5818-6fc8-56d9-1a0ab8eaa74b@gmail.com>
From:   Rob Herring <robh@kernel.org>
Date:   Thu, 28 Oct 2021 07:54:33 -0500
Message-ID: <CAL_JsqK2MDBoLqREsV9MBxvEs4Pxtg87r4LgCMHoUrgu_1yLLw@mail.gmail.com>
Subject: Re: [PATCH] of/unittest: Disable new dtc node_name_vs_property_name
 and interrupt_map warnings
To:     Frank Rowand <frowand.list@gmail.com>
Cc:     devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Oct 27, 2021 at 7:05 PM Frank Rowand <frowand.list@gmail.com> wrote:
>
> On 10/26/21 5:55 PM, Rob Herring wrote:
> > The unittest dtbs have various intentional errors which cause warnings.
> > With the latest dtc sync to v1.6.1-19-g0a3a9d3449c8, we need to disable
> > some new checks: node_name_vs_property_name and interrupt_map warnings.
> >
> > These warnings are also generated for static_base_1.dtb, so let's just
> > disable the problematic warnings for all unittest dtbs instead of just
> > testcases.dtb.
> >
> > Fixes: e76187b9792e ("scripts/dtc: Update to upstream version v1.6.1-19-g0a3a9d3449c8")
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Cc: Frank Rowand <frowand.list@gmail.com>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >  drivers/of/unittest-data/Makefile | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/of/unittest-data/Makefile b/drivers/of/unittest-data/Makefile
> > index a5d2d9254b2c..7e1a25ad4e5c 100644
> > --- a/drivers/of/unittest-data/Makefile
> > +++ b/drivers/of/unittest-data/Makefile
> > @@ -37,7 +37,9 @@ DTC_FLAGS_overlay_base += -@
> >  DTC_FLAGS_testcases += -@
> >
> >  # suppress warnings about intentional errors
> > -DTC_FLAGS_testcases += -Wno-interrupts_property
> > +DTC_FLAGS += -Wno-interrupts_property \
> > +     -Wno-node_name_vs_property_name \
> > +     -Wno-interrupt_map
> >
> >  # Apply overlays statically with fdtoverlay.  This is a build time test that
> >  # the overlays can be applied successfully by fdtoverlay.  This does not
> >
>
> Before applying this commit, I am not seeing the warning that -Wno-interrupt_map
> suppresses.  I've tried with (1) CONFIG_OF_DYNAMIC and (2) with both
> CONFIG_OF_DYNAMIC and CONFIG_OF_OVERLAY, and I don't see the warning.
>
> Where are you seeing the interrupt_map warning?

I should have noted that that is dependent on re-enabling the
interrupt_provider warning which was dependent on the dtc changes.
I've already submitted dts fixes for that and plan to enable soon:

diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 56d50eb0cd80..d435db2222ab 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -305,7 +305,6 @@ quiet_cmd_gzip = GZIP    $@
 # DTC
 # ---------------------------------------------------------------------------
 DTC ?= $(objtree)/scripts/dtc/dtc
-DTC_FLAGS += -Wno-interrupt_provider

 # Disable noisy checks by default
 ifeq ($(findstring 1,$(KBUILD_EXTRA_WARN)),)
@@ -319,8 +318,7 @@ endif

 ifneq ($(findstring 2,$(KBUILD_EXTRA_WARN)),)
 DTC_FLAGS += -Wnode_name_chars_strict \
-       -Wproperty_name_chars_strict \
-       -Winterrupt_provider
+       -Wproperty_name_chars_strict
 endif

 DTC_FLAGS += $(DTC_FLAGS_$(basetarget))

(I just noticed that dtc doesn't seem to handle overriding options
such as: '-Wno-interrupt_provider -Winterrupt_provider')

> I would prefer not changing from DTC_FLAGS_testcases to DTC_FLAGS because
> the suppresses the warning for all unittest .dts files, not just the two
> that lead to the node_name_vs_property_name warning. These two cases can
> be covered with DTC_FLAGS_testcases and DTC_FLAGS_static_test_1.

Okay.

Rob