Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= <clement.leger@bootlin.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] net: ocelot: add support to get mac from device-tree
Thread-Topic: [PATCH 1/3] net: ocelot: add support to get mac from device-tree
Thread-Index: AQHXzALaBu1tOZHr/E6Z7NAaubhTaKvoceaA
Date:   Thu, 28 Oct 2021 14:06:12 +0000
Message-ID: <20211028140611.m7whuwrzqxp2t53f@skbuf>
References: <20211028134932.658167-1-clement.leger@bootlin.com>
 <20211028134932.658167-2-clement.leger@bootlin.com>
In-Reply-To: <20211028134932.658167-2-clement.leger@bootlin.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?rqL3Sjfw/GALzOltiYsQgJvBjZandhtT4b/avvYg3bGKeSjQ2bA5gmeJCS?=
 =?iso-8859-1?Q?UNPp9nL1i/EJGYs3cmYks7ApDUAjfGFYtNADLxCEZcKVmqh8a5+03L33MG?=
 =?iso-8859-1?Q?TvkE9NV5o/0P1rskO1wWhQqdtdAac2DYsmCjGAGnlNRQgUtvfXXK4neWqF?=
 =?iso-8859-1?Q?jgXVWeIo0XF8QSYSduJcFkNdMvJuGzycZecTWIOQ5H+n3fDmNWWRUmSh/c?=
 =?iso-8859-1?Q?g5G0fvXFxBettEEOGEYeEoSZsYNw4E3P8Pp+fZ+fH9HJbmY5BkRHAwcMfd?=
 =?iso-8859-1?Q?vLzTPZgrgNb89JLTbDNVGwU9HdugCerff1qSPW8CazbPlOYjusXdm9Tnwd?=
 =?iso-8859-1?Q?0Jp/8+xYYGHp7HyJML4arVP1iBVwCvDq1WGIJaPP31fm2Yc77Z41/02I5l?=
 =?iso-8859-1?Q?MHrznuHl1nJqpk8I6jGoZXiOCpWDAQWRybzkUF+GD3x9kuRuIPOqpfjprX?=
 =?iso-8859-1?Q?KW3Md6hBTChktC1/X8bTBEoBqS8nSQcCFEAoxxev20b+XPEltB3DIn9V+W?=
 =?iso-8859-1?Q?QM3y2A0i+PK8BkmOjG/cUGTEZl/ecp9X4zKE5yqInwmn7+IpjmhraeVr5+?=
 =?iso-8859-1?Q?nDwQYx0cswThT30gWUDC3g6uUBG12D/DgQgKTPGpVV2/Ku91qvIpBpKxDs?=
 =?iso-8859-1?Q?TOqUwwWEZ0PMnUkkun16n70KnLMZ3TiWz2SlkvH0LebgkhmMyib1p01ccd?=
 =?iso-8859-1?Q?+NVTp72MYjZc8CAlCrI2fXk3S7ZUYx0msS6/9W8uqhkzt2R2QDN/Mwaf6B?=
 =?iso-8859-1?Q?jP0G+S2SsxcFSSB6l3RDp7z0yAuJ1RJZhiugMY3jmhXTkTDNKRDhyLhZWt?=
 =?iso-8859-1?Q?utXq6TUHDW9w/IbwT3Dyc4f3tATcWlC5gETBJv8aOSdUH7jynVesk5SK6P?=
 =?iso-8859-1?Q?RY73hawhkj+cinMXjN2scQEtbSX2aKSr8S3cCJWP0ZJ6g/o0ew0zGf9VCQ?=
 =?iso-8859-1?Q?IupGsZFTsfhlR7OjNcxj5jA2L0dsJ1vTOA+JIAKDIdRi0KxymKFfz4g0lh?=
 =?iso-8859-1?Q?xgfe/A9x9YHo/VA7/b3aL7FJN0w40pcP22QEtmnW7ICfRR4hh0qE1jtKpR?=
 =?iso-8859-1?Q?WQbn7iKkeUhb0PaX3m9MppEHDhsJpkSU1Z9EfFdclJwBaao2CdhbdttN9b?=
 =?iso-8859-1?Q?9X3CuD2Wf5o3XOGZdZ/E3Um5TMo0j1rpvO1uuDE3Rd+ZrM7C5hmDdHdvbG?=
 =?iso-8859-1?Q?/SpvX7WU7kI0+EpxT9DHtk6K3v/Yx+whvDI2MD0uQ6o1nCmrRaO+i05U72?=
 =?iso-8859-1?Q?IsNX10w/hpIdeo9GIz6T4J2e0taXFJuwCcLrq/RL/vAWaphk6KYQvb/NTf?=
 =?iso-8859-1?Q?yBD9sZY3iL5UBgMSN2DZoxE3J8tEHu8ohfliMGU/1De5MvvZlqhcZzMFrF?=
 =?iso-8859-1?Q?KWK+fjd2CVhFmBAjuoWJr6OrmnsfZHHLNAlaBv3iI411fUDP5OOEM/wuk5?=
 =?iso-8859-1?Q?RAhziIviGBMnVsBPPWZ5FbFGuGZiDV4wQo/0mWSR1/0ojXMnaN9ewk6xRC?=
 =?iso-8859-1?Q?3rBncfpnXQ+l1ig9tgo/77LJwXPx5eFUvMuQ/gQx6ZSrh5qtwGRJOM3JrJ?=
 =?iso-8859-1?Q?sXnGLQ6y9tAZbNRmuFuDH+o5wJqRi2nONf8YNFbnFSiKmsJh2EXhWDOgYt?=
 =?iso-8859-1?Q?zpb8LCEGvdeVVmCjDKHMFz/JRI69OC4IYkHzBmIFyZLziIvJ26heVPPmJ6?=
 =?iso-8859-1?Q?QakCR3LZW8fVAgfDaZcnJRRDmNK3ocX2boKj3m3k?=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <335D6CED69CD424386C1B2A827223C99@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cff53e08-474f-46c8-00c3-08d99a1c1945
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 14:06:12.2040
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FVLtSm/yGFhqyNDde9RxMGMlDFR1PIXLgna6VW+OWx1iwu3vCwYy8UEtc5aGFw5vWYRss4ppVUWCBCsIReFzDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2301
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 28, 2021 at 03:49:30PM +0200, Cl=E9ment L=E9ger wrote:
> Add support to get mac from device-tree using of_get_mac_address.
>=20
> Signed-off-by: Cl=E9ment L=E9ger <clement.leger@bootlin.com>
> ---
>  drivers/net/ethernet/mscc/ocelot_vsc7514.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/mscc/ocelot_vsc7514.c b/drivers/net/eth=
ernet/mscc/ocelot_vsc7514.c
> index d51f799e4e86..c39118e5b3ee 100644
> --- a/drivers/net/ethernet/mscc/ocelot_vsc7514.c
> +++ b/drivers/net/ethernet/mscc/ocelot_vsc7514.c
> @@ -526,7 +526,10 @@ static int ocelot_chip_init(struct ocelot *ocelot, c=
onst struct ocelot_ops *ops)
> =20
>  	ocelot_pll5_init(ocelot);
> =20
> -	eth_random_addr(ocelot->base_mac);
> +	ret =3D of_get_mac_address(ocelot->dev->of_node, ocelot->base_mac);

Why not per port? This is pretty strange, I think.

> +	if (ret)
> +		eth_random_addr(ocelot->base_mac);
> +
>  	ocelot->base_mac[5] &=3D 0xf0;
> =20
>  	return 0;
> --=20
> 2.33.0
>=