Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= <clement.leger@bootlin.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] net: ocelot: add support to get mac from device-tree
Thread-Topic: [PATCH 1/3] net: ocelot: add support to get mac from device-tree
Thread-Index: AQHXzALaBu1tOZHr/E6Z7NAaubhTaKvoceaAgAACkQCAAAIaAA==
Date:   Thu, 28 Oct 2021 14:22:55 +0000
Message-ID: <20211028142254.mbm7gczhhb4h5g3n@skbuf>
References: <20211028134932.658167-1-clement.leger@bootlin.com>
 <20211028134932.658167-2-clement.leger@bootlin.com>
 <20211028140611.m7whuwrzqxp2t53f@skbuf> <20211028161522.6b711bb2@xps-bootlin>
In-Reply-To: <20211028161522.6b711bb2@xps-bootlin>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?MABjGHLz3A+2Hh45d9WwwHFrjxYptsOZthttsjyws0pwrbx2Sy+qzlEInl?=
 =?iso-8859-1?Q?i4EzxwqGOi0zxJsYpdhmgqHHltBixp3GvzdcM4KjwzZK9H2FTNLBBF7Otd?=
 =?iso-8859-1?Q?C5YLMfY2va+VQp9iFC86Iq5ioku6snAZzbrQdY6d/HV35iv+pC6q6TC+U3?=
 =?iso-8859-1?Q?/WmLWkxC0tuRoDTT7N0BobwxvZR06xzgTrXIAJa6K10Qj5zlbVGRuyBkbg?=
 =?iso-8859-1?Q?Czf/Rr0HbU2DCtl85Xbnl329bKviOjuFidCo2SQ5kGoGJHz1Tx1M+AY2+t?=
 =?iso-8859-1?Q?MC/AwWdhlWKiRQIk6cKtz/lMRKpqIxWHKgL97GqITxiL3SoGfSYu2PBWsn?=
 =?iso-8859-1?Q?BvG0zUHD27PahG+uTLjXX3fBObtqK3ZVtVuFKJZ7rFr8iM9vrDwCovcymo?=
 =?iso-8859-1?Q?l25Y1VbzffS4RGV/6qdo4oEnbN0BpSBkma0yQiXk5h2Hc8Ycg0c7OzWvTD?=
 =?iso-8859-1?Q?CeWXWllpfFRZpWYh/Wikw98jdNOO7nxW4/yrLlhepETuJl0HL0N37bR93X?=
 =?iso-8859-1?Q?d1orqfxFxKGCspcDwF+QTOp0QJTdXDzKcdtPPLABVmHfy1BFmjDZe/Gij8?=
 =?iso-8859-1?Q?DS2FK0Ma2ArjsknEZ9Hny/1Pl57kNC9t3tklQbB8u+IaZHSEldSetsHTIt?=
 =?iso-8859-1?Q?VXmFyQwL+5bSM5eX04n76h+pNLAGO5CDPE4pcH5QRZDvEu3peBx9Fd1WZc?=
 =?iso-8859-1?Q?kBR3OgV29PBiQjVSeKkF9lqWznQqm9ENLelQUktbavk/tD0MaLlumbGr38?=
 =?iso-8859-1?Q?Wc1+KKn64J3CA3NgfeLJWx/5yzWiULLiTsCnHIwLmxIMyiTmnKurMRhklm?=
 =?iso-8859-1?Q?M38TRqdyAbxsUkOJj7Eq0OEILTAdtS7hWFSlKDH+vzQ+QF5Mp37ZscQEQ9?=
 =?iso-8859-1?Q?B6TYAlK1J4OnADfgyXekz3jF3sE3D1A1JqxzULnoelt0fQmEzDtongCwhc?=
 =?iso-8859-1?Q?rcVRpc4ZCtkyvNRT49snGJyr9cTQz1tU1Nbrq2Xct+TEtDMoDUhuPJF+Af?=
 =?iso-8859-1?Q?y0p9THvExSFh/E5m2hb/QtjvqrDsHLSdlFEbyqZGcl7MCBtXzprILDF1Zl?=
 =?iso-8859-1?Q?Hgl+M3eHvS8sDj5nQguShyZsQMxqURkAFbqdt8uTsBzlpshhLyljT6jXRu?=
 =?iso-8859-1?Q?IxvaDuKQT0PZZHUo3vQZWblhSg0vH4NuHDILL9K+qqYe+iCcAPnyhp14CU?=
 =?iso-8859-1?Q?4j8XR7dihiy0TEixvZ8+ZJBoUBzUrAHPdh4Kgt1TD6B3QUgBPJ4mCjA4xk?=
 =?iso-8859-1?Q?Wp6I681tGr/7/t6EIiQF/DWhQPIDzGhwSMc1mQ2ABh1NWbKjkC6e5jO2Tw?=
 =?iso-8859-1?Q?alsFrfpefUBc1OKCqxDwXq1lBprYhcDuUhpPDBlH/XFAyHlxFJ+KUZjS2J?=
 =?iso-8859-1?Q?HwJASBc8izNzRBsutgNag3z7c+oJsLRvn0M9e164bFru6+zahdPYYs/yMg?=
 =?iso-8859-1?Q?mSmuMK7xHMn9hVH+t+6VEhHUyXhzeX5lJg+RxGIVagQU593JnAibT0l4y5?=
 =?iso-8859-1?Q?2Y1Vhdyb/XfOYgDZdCparASKxEwG9pHvWRA5Wr0O/uyn3nK41h9HFudIE0?=
 =?iso-8859-1?Q?bwQglv1R2oWhzJqK9j4GAFZO9InL2L1vLI6LHU3m12IWowghebTs4uCuW3?=
 =?iso-8859-1?Q?t+p4Psqkas1HDXUKqlpGtx0vkyG3Pc1UOosCkb3RDH1LuKcRve2giYSk13?=
 =?iso-8859-1?Q?FZTOoXHw9htBCuo2oFu3LsfqVNRxy+K7aKPnBInS?=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <3D4EAD2B20F1A249B4C9DF10B117E44A@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b1486f8-192c-4ea1-5c63-08d99a1e6f3d
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 14:22:55.4445
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8/yHIZg7r3VtMMjeeBMKGmcXyDUja7cZYJKL/OsQFSzlnjhzjstwrfyOrmd5V9c46il3paT9skuHwvCiP7OQYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5695
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 28, 2021 at 04:15:22PM +0200, Cl=E9ment L=E9ger wrote:
> Le Thu, 28 Oct 2021 14:06:12 +0000,
> Vladimir Oltean <vladimir.oltean@nxp.com> a =E9crit :
>=20
> > On Thu, Oct 28, 2021 at 03:49:30PM +0200, Cl=E9ment L=E9ger wrote:
> > > Add support to get mac from device-tree using of_get_mac_address.
> > >=20
> > > Signed-off-by: Cl=E9ment L=E9ger <clement.leger@bootlin.com>
> > > ---
> > >  drivers/net/ethernet/mscc/ocelot_vsc7514.c | 5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > >=20
> > > diff --git a/drivers/net/ethernet/mscc/ocelot_vsc7514.c
> > > b/drivers/net/ethernet/mscc/ocelot_vsc7514.c index
> > > d51f799e4e86..c39118e5b3ee 100644 ---
> > > a/drivers/net/ethernet/mscc/ocelot_vsc7514.c +++
> > > b/drivers/net/ethernet/mscc/ocelot_vsc7514.c @@ -526,7 +526,10 @@
> > > static int ocelot_chip_init(struct ocelot *ocelot, const struct
> > > ocelot_ops *ops) ocelot_pll5_init(ocelot);
> > > =20
> > > -	eth_random_addr(ocelot->base_mac);
> > > +	ret =3D of_get_mac_address(ocelot->dev->of_node,
> > > ocelot->base_mac); =20
> >=20
> > Why not per port? This is pretty strange, I think.
>=20
> Hi Vladimir,
>=20
> Currently, all ports share the same base mac address (5 first
> bytes). The final mac address per port is computed in ocelot_probe_port
> by adding the port number as the last byte of the mac_address provided.
>=20
> Cl=E9ment

Yes, I know that, but that's not my point.
Every switch port should be pretty much compliant with
ethernet-controller.yaml, if it could inherit that it would be even
better. And since mac-address is an ethernet-controller.yaml property,
it is pretty much non-obvious at all that you put the mac-address
property directly under the switch, and manually add 0, 1, 2, 3 etc to it.
My request was to parse the mac-address property of each port. Like
this:

base_mac =3D random;

for_each_port() {
	err =3D of_get_mac_address(port_dn, &port_mac);
	if (err)
		port_mac =3D base_mac + port;
}

> > > +	if (ret)
> > > +		eth_random_addr(ocelot->base_mac);
> > > +
> > >  	ocelot->base_mac[5] &=3D 0xf0;
> > > =20
> > >  	return 0;
> > > --=20
> > > 2.33.0
> >  =20
>=