Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     =?iso-8859-1?Q?Cl=E9ment_L=E9ger?= <clement.leger@bootlin.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        Andrew Lunn <andrew@lunn.ch>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] net: ocelot: add FDMA support
Thread-Topic: [PATCH 3/3] net: ocelot: add FDMA support
Thread-Index: AQHXzALbT9+TspAQqEqpFNd9PfUpi6voc5yAgAAFVICAAAaKgA==
Date:   Thu, 28 Oct 2021 14:54:48 +0000
Message-ID: <20211028145447.g37g5wb632nyta3p@skbuf>
References: <20211028134932.658167-1-clement.leger@bootlin.com>
 <20211028134932.658167-4-clement.leger@bootlin.com>
 <20211028141219.od5fdthkdqenpegx@skbuf> <20211028163123.76721f6b@xps-bootlin>
In-Reply-To: <20211028163123.76721f6b@xps-bootlin>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?oUzS3eS6NUqF57nYkxz7krvFWKgcrvQcgrNcoXRAK5Zu1RS4mYqcqDELac?=
 =?iso-8859-1?Q?vHX7b2xlqi1QvDrBdolYcO3V84omiNwaA4zRSVjEAmgp7rem+mH7kiaJ4X?=
 =?iso-8859-1?Q?O/3jO/wnrIea018eZR7nuyCNp9kKmEK8qjn2Ka4Nuo6Zot84TqaP6anrpD?=
 =?iso-8859-1?Q?TajwJ1Slu+144aOaXJzjkqtUljNDu9kXSM3ksFlIhJ+ZEZdG9cB/K6Rv5N?=
 =?iso-8859-1?Q?MepSgdIJIA34yU845apLAh2Rnnk5B6pIV/W8OGc4H90c5keprafwNnGbkw?=
 =?iso-8859-1?Q?byTAkwMH1Yc2fuUg7au5vUBUcH0GkONrlFcCHqAlVoTeViSsl011GmlEJ9?=
 =?iso-8859-1?Q?+peVPO42xjkS8RiNEngu42yK4l1oNYZ09WZkPMUFAcWppuM7ML/ouUm/2y?=
 =?iso-8859-1?Q?rIuvx9de4pImfYsI6ncDjVx/x72lOtZIRDh+Jc7SAG2O08i1M34vvDPL+p?=
 =?iso-8859-1?Q?fpr+oM3mZqxqQeSDwDxNcLZw4ImdUikgbg5tdKAbvLv+eFNm7dU4u4IrSw?=
 =?iso-8859-1?Q?+2sAzknUnU5eT7UUep9oVjpE5UPRDzJpqnDjV3TtzpDz1yCvEsjc+Da5ra?=
 =?iso-8859-1?Q?CbVFiMsvzEyvq7ufPTIF9OOCFWKeVCpkU5RXobca9pW/dcMhkepDvWdvxQ?=
 =?iso-8859-1?Q?VqFo2CetaldWs16Igph7qTWFKNs4DHIACjGW2yXziaarkXbA6VPrWe8u1q?=
 =?iso-8859-1?Q?LvPt2ytNeXXjNf0EZxqSNESdiNeWDQGimr7Jq69RjOttBU0z8yHiJAm8QO?=
 =?iso-8859-1?Q?ln3XF7MwDbQ5y7FZHMItnhuSd4fr0DSl2WHoaCWh2TxjOrs7iIlIWwvFjq?=
 =?iso-8859-1?Q?wxFDWFwkuQ6cJ8owBwhrUchMeAANy1e2tClB7TiVYTVZNDWCTABJFcOR9n?=
 =?iso-8859-1?Q?bC/7T14q/H6cVVnkSyKvW+WvW48TpxvPd9NE0zQ62Ves3P3mt+odbQXut7?=
 =?iso-8859-1?Q?qBXOCMocRAUQF27hIdrlBusMa7CnrzidCcyWMoSAkem655vspbTEpuHqJM?=
 =?iso-8859-1?Q?Y2wt+xqRubXwpiPQnmRHPLSOKt5+MBO6QCna/NCZ2KlSkHE+hqj9s6CdhL?=
 =?iso-8859-1?Q?OZoZAFyQ/gTJx4BZadqxme1RaGpVgVAI8BN/FCQNYeeC+pIGxRHpLu8ONi?=
 =?iso-8859-1?Q?18RXhyv13Ph+m0TdjuqxTm92HNmqTVORZvUqaltv8sUUL5M90IQG6ebqCl?=
 =?iso-8859-1?Q?x71MunJGWFoFEoV4jARnX6EHTQfnRoSHBqRca3DphFJ7yVBOu59BP7kf2Q?=
 =?iso-8859-1?Q?j9ay4e8KjnXIrwh25/2EcHQTcTEMmt7c5TVZrHBRjZeRm5EZ8rSjLZyYH/?=
 =?iso-8859-1?Q?uG7E83tcT6fTjs5dYauPxre10pmYEo5WyCwNGNNTuaDk1uTNfdzcjYxNKs?=
 =?iso-8859-1?Q?XCwbHAhM8xhSG9dhAIqndcvLtQrBOuLKObscWXBBXdPOMvmkvd4hq57BOh?=
 =?iso-8859-1?Q?2WTYuQSrs6+9QaiC6YzXWK/wUTHyRgxYRSLblIdHaZf6wsmtzrYjEhOhG0?=
 =?iso-8859-1?Q?9KhFXf77oQ4/WFiQtEAQbTMvJ8m3qbe9RooQ4JZjIzl+lDSGAwkQrlgBi4?=
 =?iso-8859-1?Q?B3skXqQaUTvTBwR2oh7owCZqJDAhn4T4WxiBtE24Nqg5TwuUqGZUJGdPrd?=
 =?iso-8859-1?Q?CFRtNJsG4bWSQs8aJlwFRyuAVTTWfyfEWKkWLmW7zjejwEu0JkiLR9/wAF?=
 =?iso-8859-1?Q?uH+wK6R1s0QVFQwJT1soRkzzY5By6Rzv40qg2tsm?=
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <0E79481D62E6884ABA8335ACBD04E369@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5533d7b-6b33-4b35-e24e-08d99a22e3a5
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2021 14:54:48.7131
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3m1YIEe5sCeMsSPcmx0uafeTUDK3omSd/HNLMVQfj4jexVG+JsV2na9h6HJt1FSp/VfFF/c2CPfGX8kQiiq6Cw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5854
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 28, 2021 at 04:31:23PM +0200, Cl=E9ment L=E9ger wrote:
> > Can't we make the FDMA and the manual injection/extraction registers
> > use the same endianness, instead of duplicating code? I can
> > regression-test the manual inj/xtr regs on LS1028A.
>=20
> I guess this would be possible by disabling byte swapping
> (INJ_GRP_CFG.BYTE_SWAP) when sending the IFH when in register based
> mode.
> BTW, while checking performances, I noticed that the CPU spent quite a
> long time in packing so I added precomputation of IFH. I could probably
> modify the register based inj/xtr to also use this.

packing() is not the most optimized thing in the world, so I wouldn't
mind if you changed it to some other API, but the ability to read,
understand and modify the XFH/IFH headers easily is something I care
about, so no weird macros that depend upon some particular endianness,
please.=