Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> <20211028141938.3530-13-lukas.bulwahn@gmail.com>
In-Reply-To: <20211028141938.3530-13-lukas.bulwahn@gmail.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Thu, 28 Oct 2021 16:58:09 +0200
Message-ID: <CAK8P3a0qjnVZqdO7HV+gMGOQN4N9nR1KbsxCYuAwpbDWvK16Vw@mail.gmail.com>
Subject: Re: [PATCH 12/13] arm: socfpga: always select PL310_ERRATA_753970
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc:     Russell King <linux@armlinux.org.uk>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        Sekhar Nori <nsekhar@ti.com>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Linus Walleij <linusw@kernel.org>,
        Imre Kaloz <kaloz@openwrt.org>,
        Krzysztof Halasa <khalasa@piap.pl>,
        Avi Fishman <avifishman70@gmail.com>,
        Tomer Maimon <tmaimon77@gmail.com>,
        Tali Perry <tali.perry1@gmail.com>,
        Patrick Venture <venture@google.com>,
        Nancy Yuen <yuenn@google.com>,
        Benjamin Fair <benjaminfair@google.com>,
        Dinh Nguyen <dinguyen@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        kernel-janitors@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> Commit fbc125afdc50 ("ARM: socfpga: Turn on ARM errata for L2 cache") adds
> some selects in ./arch/arm/mach-socfpga/Kconfig, with one select being
> conditionally selected on the non-existing Kconfig symbol PL310.
>
> Hence, ./scripts/checkkconfigsymbols.py warns:
>
> PL310
> Referencing files: arch/arm/mach-socfpga/Kconfig
>
> Assuming that this errata should actually be selected for
> ARCH_INTEL_SOCFPGA, simply select this config unconditionally.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

I think it has to be

       select PL310_ERRATA_753970 if CACHE_L2X0

otherwise you get a Kconfig warning when building a kernel without the
L2X0 driver.

         Arnd