Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1708214pxb; Thu, 28 Oct 2021 08:37:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBhSROu1CQDb5HyQkSJSk6f0d1+GQNARooPkMrGCCC+9SgJXuv5tCXzF6zYFk9zZx5Q6Tl X-Received: by 2002:a17:90a:fe8a:: with SMTP id co10mr5316876pjb.183.1635435459677; Thu, 28 Oct 2021 08:37:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635435459; cv=none; d=google.com; s=arc-20160816; b=ogl5Kw6QC4qO+m5TEDHcTDRxfbmqK/5VvoljzRJt61AYPsO7OhHtHb8ijd6tHbOCgp ACd/DUW885mKtBPnVjjDclNQPqAtU63+jXW6ZP3LXp7dEM4sMjrf42BFQPc2x5TgADFX v4cO/X3F+KgCSEd6iFkd9IKmscefjEOmEd6TCvs5FGnozjTNtjHhmfsvLvLshe7RXLFW ku9pgtVRRK86olmHBXZb+iZL4gc2u1wbF3C9Jg+fJ4B6M47qnBBIV7p6KYyV50mSxR2S TUTJxiTmBKPPU2Ehabcvno80egOvlRj8jG1dJT0SkOxlgIDDXrWbmMPGx/N67UwoxvmI 1X9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=obEVRh2SUyKsH6wuRZ+MmeBmZXXQKS44Jmrm2Q2wynI=; b=hG8qS69f1DI7kvWMbGF0SbJMr4V7P1aklhoXvVGqP7uiTBvHT92+6KCh7Tu7NOgOjJ Ke2JbWTM2ErhkkQGfOimUNKHKeR47hxi3A3mFn0czUABOMpK6PtZGUxe0waEo1EJ1sGI gp6zEToVxoZ+MvojtdNFjA3CvdVuVBAt1I7h6qgXly6ap+bK6svrB2cnp0Pftc06+r8O agm37hO7vpAF6WHHQhDE1BDgDdePOla57Dc4YW2SegWyNv2zZyTtW/AAmoSSLl9mgfSJ SrWznJ1V+ek2l80kYuYoeZDsph3qb+YFFidp7V6lOx1zOK+50q20PXU70hYJTvCFKCVH eZfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="U/Fj/4zS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g2si4235151pgl.634.2021.10.28.08.37.16; Thu, 28 Oct 2021 08:37:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="U/Fj/4zS"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230254AbhJ1Pie (ORCPT + 99 others); Thu, 28 Oct 2021 11:38:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230126AbhJ1Pid (ORCPT ); Thu, 28 Oct 2021 11:38:33 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64878C061570; Thu, 28 Oct 2021 08:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=obEVRh2SUyKsH6wuRZ+MmeBmZXXQKS44Jmrm2Q2wynI=; b=U/Fj/4zSFAfu3ihra5R0kzvttB XGcVAR8aLmLHPrjVzDXTsP7lZZEKYxdFievSQRbR5RMKbt8Yu/ZRuc8yYbAUBEzr/7oTN79aMIKXK rPEXXE09QDGjMZ1BM9zhfBnfKmg8nY00Zqzrm9m6lIDjIyymDCD0q0pwEEukI8ghiWm2zZy/HuIZT boGw9j9RAMlBkz00H0+8QIGhaKxLDDPF2XJildRKicdgzYTY7PXIMkiix1AsCt8eMN4ajOM5gGuEI JCbxWGa6C6y5Y2qPSHILdWzOXHAlaZaxtDy5TB7jIv/SkQFgurik7tg5FNImCmARI0g4Gu3MR5p9r gDq03WsA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55356) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mg7RQ-0007ix-SD; Thu, 28 Oct 2021 16:35:44 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mg7RM-0000Rz-JC; Thu, 28 Oct 2021 16:35:40 +0100 Date: Thu, 28 Oct 2021 16:35:40 +0100 From: "Russell King (Oracle)" To: Arnd Bergmann Cc: Lukas Bulwahn , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sekhar Nori , Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Dinh Nguyen , Linux ARM , OpenBMC Maillist , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH 04/13] arm: drop an obsolete ifdef with the removed config PCI_HOST_ITE8152 Message-ID: References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> <20211028141938.3530-5-lukas.bulwahn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 28, 2021 at 04:46:38PM +0200, Arnd Bergmann wrote: > On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn wrote: > > > > Commit 6da5238fa384 ("ARM: 8993/1: remove it8152 PCI controller driver") > > removes the config PCI_HOST_ITE8152, but left a dangling obsolete ifndef > > in ./arch/arm/kernel/bios32.c. > > > > Hence, ./scripts/checkkconfigsymbols.py warns: > > > > PCI_HOST_ITE8152 > > Referencing files: arch/arm/kernel/bios32.c > > > > Remove this obsolete ifndef. > > > > Signed-off-by: Lukas Bulwahn > > Reviewed-by: Arnd Bergmann > > I wonder if we should just remove this function and use the > (non-empty) default version instead. > > 96c5590058d7 ("PCI: Pull PCI 'latency timer' setup up into the core") > introduced that generic version, and I suspect the arm version > was left out by mistake, but it's not clear from that patch. That was because PCI_HOST_ITE8152 needed something different from the "do nothing" default (setting the PCI latency timer to default to 64 as the new generic code did.) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!