Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
        Olivier Moysan <olivier.moysan@foss.st.com>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        Ahmad Fatoum <a.fatoum@pengutronix.de>,
        Wan Jiabing <wanjiabing@vivo.com>, Xu Wang <vulab@iscas.ac.cn>,
        linux-iio@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     jiabing.wan@qq.com
Subject: [PATCH v3] iio: adc: stm32-adc: Fix of_node_put() issue in stm32-adc
Date:   Thu, 28 Oct 2021 23:42:02 +0800
Message-Id: <20211028154204.1263861-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yOzpt6Zw5/0Wl3j35cn3cAed4QS/HMcvoegzWAli668BEExpJMINuIq3iPFC?=
 =?us-ascii?Q?IDGeBxFL0xkB7cxwnAlAN5EvB26VOPOWizEWD/JYZTMhU3zg8m8qPtBkdmV5?=
 =?us-ascii?Q?w7AKJ/nUSuWOz8d5GW371EPCER8+XuqDjCkQnHMLAUbj+bDhpipIVbUePOE1?=
 =?us-ascii?Q?YVWGllIqwCZ+U9pulYfREBYY0TNxCN8Huy3XDveMbM2JvWNd7kNaTY3dFJ+y?=
 =?us-ascii?Q?p1NsVcn48n5G+FfunhNHLghYPJA3/H73F89eVs54sqorfy466TWE9a2seJax?=
 =?us-ascii?Q?hMbmlOrdB4uakSCK6ZZDvLEFnM2HAxAC9S5AlRDcQU3yPKGzh7a8mluHkVlg?=
 =?us-ascii?Q?GcGG2U/ZeAbOL+CwzTUAlErda+BPotBEX/O0AopO+wpOLETliY8VqRgOGKF+?=
 =?us-ascii?Q?0M2eTJuSTOQpAr/zjSBNxdcs7FcP0QzMgjbD3u8S0h/mPrNtSYFsKZtiwW04?=
 =?us-ascii?Q?vRClk2fxQqKhVbajNhklQ8di3ej3B0LqsZ9t7Pm9KyE4QOKNhmmMclvjy7Hh?=
 =?us-ascii?Q?ml5DNUnpWEoPxJqwe23Rp2QFysvQnxc3vB8sOMxjslsiT9o6Vwcq2YjtxVFC?=
 =?us-ascii?Q?2z6vh+10mWVjDU9cOkLN4EqViw5UFYZ4KLNcnWS+Wbj18hegmjXUOdLgvKqR?=
 =?us-ascii?Q?QX+Q/lZ2fLTxYpRKIRKUwe6jvctjHvLu/vwwlgM5jnOH9Qh1sRJebcVa3/Gx?=
 =?us-ascii?Q?tfEO87nVrg9P41oCVakbtdr52FlVOgrk+wFzMM4KoRjKIDxWma2LsBOrKfhV?=
 =?us-ascii?Q?nfu5i/UojZJGx5P7v9457G27upJFLZaCBVzuWVg+WH8Nl0cIkYFBLrOcrYea?=
 =?us-ascii?Q?XGCAkgwkVWf5hT7JnuJauw6P8T0lVYQMMD8F3hQg+O1jinpuysKkjyUFsP1I?=
 =?us-ascii?Q?X1XwUYhsvzXObNUfzlFMfwfQx+Z+oZWz5WuBcKx5d63eL8J1v3oYGqqtVbLZ?=
 =?us-ascii?Q?K51uJym8QScoayCksivsgMbGmGLkRTWsUhfhhQBq7SjKRysihufWNb1lT70B?=
 =?us-ascii?Q?2Uyykfmsd+rD3WGd7KoWRqyTbK7w2ikzTUTlryD8g3W2oOlEZNW0ByV+dCPY?=
 =?us-ascii?Q?86YOvCOmReFgJIkLges+zmrfuL+J3g9gQ314TvLtB6G2l541echGKDUytMzQ?=
 =?us-ascii?Q?yq87MnJs7DPU9uMEnQy1iWtVcHUbXreTzzReI/30RPO3jaRf2wVAObj2kRFE?=
 =?us-ascii?Q?bjtrqaCQOfETNhPznWe9nMZXXdsD7Es5BaMTZOzIOesSIToROZtYr8jOiIbM?=
 =?us-ascii?Q?uwNeVMKzsgvlxrbypsYZQbuEe4V88/PLN0jCMNIRmfhaiukJxA4C9+/jkkJm?=
 =?us-ascii?Q?ON3tGNRnNjTVDbMHsroXnPAwjCzLAu0PPNq6ZAdtmZvTny70b2k8eGzWiPyU?=
 =?us-ascii?Q?X2ds6l3JOq8Bj2AqormsCwTA5DLDu8a3yoHm3wfPaHyuEIlcOTvr6XZOTK01?=
 =?us-ascii?Q?jYbZk9m4wLGbzz+y308Fr9Ink+G0FVPOAP5fIfsHP/q+5Nmatq99uc6d7NUl?=
 =?us-ascii?Q?813aHB4dla1GtSqb41yYGtNJao9Yjo5ELs9TqZgcPBHA+Nm90Q73mOfA0u7/?=
 =?us-ascii?Q?5z/j3RI748dZhxAvZoGrhBQPYNDCJ+YMx1bEJQp0v9DCOzqTtn9jc7N9pDCG?=
 =?us-ascii?Q?iJp7ylBVvjnrolavzt5iVDk=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dcb21e28-c318-46be-c50b-08d99a298636
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 15:42:18.9606
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Npyl5/foiDQkrRfU/naCHolrJTqKJO08o7UvTCm59pyiojbzLMUgfdOpGelCX5DAvbeNbdR462ugLNxOho49sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB2857
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
./drivers/iio/adc/stm32-adc.c:2014:1-33: WARNING: Function
for_each_available_child_of_node should have of_node_put() before return.

Early exits from for_each_available_child_of_node should decrement the
node reference counter. Replace return by goto here.

Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
Changelog:
v2:
- Fix typo and add reviewed-by.
v3:
- Fix typo.
---
 drivers/iio/adc/stm32-adc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c
index 6245434f8377..7f1fb36c747c 100644
--- a/drivers/iio/adc/stm32-adc.c
+++ b/drivers/iio/adc/stm32-adc.c
@@ -2024,7 +2024,8 @@ static int stm32_adc_generic_chan_init(struct iio_dev *indio_dev,
 			if (strlen(name) >= STM32_ADC_CH_SZ) {
 				dev_err(&indio_dev->dev, "Label %s exceeds %d characters\n",
 					name, STM32_ADC_CH_SZ);
-				return -EINVAL;
+				ret = -EINVAL;
+				goto err;
 			}
 			strncpy(adc->chan_name[val], name, STM32_ADC_CH_SZ);
 			ret = stm32_adc_populate_int_ch(indio_dev, name, val);
-- 
2.33.1