Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <128db0c4-1d7e-27fa-0dae-3567a0913f1d@nvidia.com>
Date:   Thu, 28 Oct 2021 19:00:49 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH net v2] net: bridge: fix uninitialized variables when
 BRIDGE_CFM is disabled
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>, netdev@vger.kernel.org
Cc:     Henrik Bjoernlund <henrik.bjoernlund@microchip.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Horatiu Vultur <horatiu.vultur@microchip.com>,
        "moderated list:ETHERNET BRIDGE" <bridge@lists.linux-foundation.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20211028155835.2134753-1-ivecera@redhat.com>
From:   Nikolay Aleksandrov <nikolay@nvidia.com>
In-Reply-To: <20211028155835.2134753-1-ivecera@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXRnV28xbWMvbmV3MGJsb3VhbU9WWndNWGNFRFpjaGVmUXJLeXpIZEQ2MTZu?=
 =?utf-8?B?NVh3V0I2N00wWGd5RzFQcjFDa3c4NUFRZ1Vka1JGdy9FT0VLOGJ1SG5jVU5Z?=
 =?utf-8?B?NGh1UVY5eWkvVHRhUWZWYVVLbVVTTHMxS2pqMDhGUTdxc0pWQmgrUzVFYmcy?=
 =?utf-8?B?N3ZzcVYxYXlzYnBBRkhnZlRkR3I3U0ZEK3pXMXJQRlY3QUdIK2VHb2hTODFm?=
 =?utf-8?B?N0R1ZThOMXJKd0xWRXgvamRlSXdBaERpZU9jdDlmWUtKcXcySjd3cnppdTB1?=
 =?utf-8?B?d2ZoOTdNMy9MTUwzNVNPdndyWDFCcktnNEFBSlpxWUpEY0F0NWpIaGpDdkRH?=
 =?utf-8?B?RXd2UU5qNXRNMGhpdkdGNDJ4a3Z5b2wyV3gzVXBKeVRGU0djekRYdFJrM1VM?=
 =?utf-8?B?WXpZSWIvSHdBMlFqckxDWGQrQjhpT2dacGt1QzM5cnR6NWZUdFRZRDNrKzdK?=
 =?utf-8?B?WTBOUi9CNzdhdGF5elBzdldwVTJ4eXpseHpySm5xbDJVdUV4L090ZFEvckQv?=
 =?utf-8?B?OG02eFFndnRRUVZKMDJsMU1OU2ZGUGgyL1crdllPZzM2WGdnYlJUTzB4Q2hN?=
 =?utf-8?B?aFQzaW8zTjBVemRueW5CYWdBVS9WMk9rWUEvYnNaQVlaa2xtVENPNjc5Wjhx?=
 =?utf-8?B?anNIZHgwallTY2dIZkozMVFCL0xob2d1WmtxbEd4WlF0bVVXa3d2eVc2Zi9E?=
 =?utf-8?B?L2haRFZrUEdDZ2d4T3NacHBwcitaeVFFU09JUUlXM1psQlduMDNQK1F6cUtP?=
 =?utf-8?B?cGZac0llb0paT2k4UUVVN0dRUG5mK3BOWEpIamhLcXgwbFJMOVA5WlA1Tk5B?=
 =?utf-8?B?ODd3cGd0cXBScWdOMXZXOGs3TGhmdkJwQUZPdWMxUDZlcVlFbVM4ZnFTWmEv?=
 =?utf-8?B?N3Fpd2tuTDVrZUJFSXU2MzlRR1g0WVFIK25FeHJ3UE5IdnZ1UDgvVHRrZ1Y4?=
 =?utf-8?B?TXJaa3JCcVF4VnJYOE10dDRtbHl6SXJXblV5UGs1TmRnSVZiMUZUMFJpRDRm?=
 =?utf-8?B?emxUb0E0bTN2WEJKSnc0MWhlSzU3UzdDZTNMREpJK21GTTlWOVpYamlWNllV?=
 =?utf-8?B?bUtxZlFkSUs0VGU0Nm5acUlzREkxR1VtSy9LSk1iTXF0YmcxNjh2ZjFsL3NE?=
 =?utf-8?B?YjROU1RHbHljVnMyTHlPYTdXYm5GS0xHUlNjdWlWQlM0WWxMNmxMWHE5clhu?=
 =?utf-8?B?V3Rzd2phemgxOTJkYVdEeWVqbXpQMlZGdDJXbVpIeHZrUlRSdjZmaVZYbE5W?=
 =?utf-8?B?d3hDcW9zdm12b3o1UU4rRWVOSW1WYnRCbzBNcXVSZlNMcXZNd0hzUUZ0bTNJ?=
 =?utf-8?B?a1RwTEVNaGZzWGErV3FvNzFHT3U0WEJ4UjZTZzRGaDdTaW1GbVVxMWMvemNo?=
 =?utf-8?B?ZGpuV1pLei9DakJEVjRaOEhmUzFjYWtBTHp6NVdjdmVRbHVvWENQa2tPUjdL?=
 =?utf-8?B?QTFLOStwL1BDUDdmZUxVSTM3dS9aYU5DNFFTZndLNVNqSWhMTlV4d3hXSnRT?=
 =?utf-8?B?Mis4Y0RlbE55WE40RUd2NXJsYnQvZmFNbTBXOGc5UVR1SUlKZy9IRjNpcnNn?=
 =?utf-8?B?Uko4dDlUK2M1YkhPd0FaQ3owNThiSjZLdEdPL3hDVWd1Qk5UWXp5cXBYellE?=
 =?utf-8?B?TEVXREFKR0lhZmZXMmxLU1BJU21WakFaa3BEUzFZMTd2RXlvYktwbXVHT01a?=
 =?utf-8?B?Y2VPVFZJS29zbDFOMCswWEcyUDZGOUFaSjk5RzVoR1d3VS9GblJCRUFsdHA3?=
 =?utf-8?B?NXFMd1ZOWjQxWGZhbnVvSlhSNDF3Qk91bk5QZ1BDdVcwSlFuM3Z1YXV3L0h6?=
 =?utf-8?B?L0NvOFJnRkJjdWZodCtwZUM4Sm9CTkxlaml2SjRhOHZ3dHpkbGJUMlVLWUtI?=
 =?utf-8?B?QXdvUUZvSVBHVkdYMzQ0dXRQN2JCOWJxUkRFWUZDYU4rR21janlMQk12ZWxa?=
 =?utf-8?B?dUtnTStyYmVwV1dYS2duNjlpa3lEMmtqVHV0NzhWbDQ4M0hvb2ltS3JDeTM3?=
 =?utf-8?B?dzdCdzRYWDRvdkZkblJsTHBkTnNDUGRyZE05dnJwWEJLMGxmQmd0eDVjNTFx?=
 =?utf-8?B?TUhlQzJSY1NIcG5pd3N6OFhmaHFTUWczelZkWEFWczlaZVdpUVpCdkNIUGhX?=
 =?utf-8?B?YnJhVlRKNDhWWFVOTnlZcWJvaEJKUkRsTDhSNVI4VzBOMkRQL0c2aElacWoy?=
 =?utf-8?Q?w+1yJiXDR8q9zh9N1Lts19U=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd35e4ce-ed29-4b59-b8f1-08d99a2c2124
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5271.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 16:00:58.0564
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z7Xy6zQSPthQrgOIiMn+hzLeFqHZF0GgHlMw7kUwfx8tvoXTLN2V8/aiULFtLcFTuQiTmQZCn0NYaZFPUBwOcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5237
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 28/10/2021 18:58, Ivan Vecera wrote:
> Function br_get_link_af_size_filtered() calls br_cfm_{,peer}_mep_count()
> that return a count. When BRIDGE_CFM is not enabled these functions
> simply return -EOPNOTSUPP but do not modify count parameter and
> calling function then works with uninitialized variables.
> Modify these inline functions to return zero in count parameter.
> 
> Fixes: b6d0425b816e ("bridge: cfm: Netlink Notifications.")
> Cc: Henrik Bjoernlund <henrik.bjoernlund@microchip.com>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>  net/bridge/br_private.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
> index 37ca76406f1e..fd5e7e74573c 100644
> --- a/net/bridge/br_private.h
> +++ b/net/bridge/br_private.h
> @@ -1911,11 +1911,13 @@ static inline int br_cfm_status_fill_info(struct sk_buff *skb,
>  
>  static inline int br_cfm_mep_count(struct net_bridge *br, u32 *count)
>  {
> +	*count = 0;
>  	return -EOPNOTSUPP;
>  }
>  
>  static inline int br_cfm_peer_mep_count(struct net_bridge *br, u32 *count)
>  {
> +	*count = 0;
>  	return -EOPNOTSUPP;
>  }
>  #endif
> 

Thank you,
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>