Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1771576pxb; Thu, 28 Oct 2021 09:44:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwP3+Ian0+LtA2iejLxAA4p8xSbzlQ3Zu+O1zXhijpY8J2lWjjlDBRUF+h6kfz2DC+DEBMq X-Received: by 2002:a05:6a00:2486:b0:47e:4baf:edda with SMTP id c6-20020a056a00248600b0047e4bafeddamr4015388pfv.66.1635439444190; Thu, 28 Oct 2021 09:44:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635439444; cv=none; d=google.com; s=arc-20160816; b=xAwx/Ug2UsBfIgzjMTn9c4m+BJ3bnRkGF1Uxg9zznEJg8EJL1kHfN+PDNIuLcyrC7V MwhPEEyvk04WwJ99+Pkj6jRNTbt+55OdWTfkI3TNUxk5jAizRmHN1l0w57AQAn7PQovO KVUm8yepVTaoztFv2crMiTcMh8sjoE49ztAoG4AQkx8uiU0nUj9zJCtUtjojD/j0NZ+D Nt0tU5EJqHsXn9QTIGoPdICZ8JqusIhqUQF99iFgHiHOKY1li2tDH5bUSomVqVbFLIVz L5Il/RZ2Ski6WkdSBJkCeYFqSU+PU3MCAfzhNY5ghiyb1zGF1M1f7CSHrAEO2HUpTA24 Tnkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3gd7S7BkAoTQ7Cpi5IFW7OPnBanuF0lA5yd8ltODwjI=; b=Q36rImbjE6A2+xS3id93Zg+xnqeUtHP5ZE+n6TqNBv/ccvml/vfAs8d/8lt0eOH7Gp MW6KIskLsBS/VwFIdlPxuVkv3xnv0Tns1VqTl/8eNeHAUgWnnpy3k6rwx/KKzumVrGM2 APWMRlksFqcBmdIBjN6g2bvQ9UNnPAPYbXW/0P8GWF6P3ZKF+JxpbSY1zuf2N5u4lQ0e M9CyM4Rlvxc8iRokJ76xyNrRqMyxV4FQyvwUwFbhSm0KunmNZODIbxYHGEB31BFF+0ru LwQw2a0jBvIEBpKUhlovEgoIl/jdYTIDJuP9PcxhaToKKYi7XBXDPurDgp0dkbjnnHc5 +3dQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=m7N7VrJw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j9si5348187plh.39.2021.10.28.09.43.51; Thu, 28 Oct 2021 09:44:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=m7N7VrJw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230329AbhJ1QpJ (ORCPT + 99 others); Thu, 28 Oct 2021 12:45:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:56760 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231178AbhJ1QpA (ORCPT ); Thu, 28 Oct 2021 12:45:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2574060238; Thu, 28 Oct 2021 16:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1635439353; bh=nhnhDs6r4p5EaPCqcbb6JFQVDxWedPO0J85OCd8/7nQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=m7N7VrJw7X062UMMNUg4E0GnT97i81zY9kp/kHyi0LO46U2eNQQhuGRtl2zO29SWj soUlHlKwEORzy2NB4RekAYP2K22Zb9mDka3JQRWkXcmnKmYdSOgoKQcGGnIPe8Ra0/ RVyEnaYEL6M7bo4NacBNZlSKOjLT1/Tr5cxJ6ljM= Date: Thu, 28 Oct 2021 18:42:31 +0200 From: Greg KH To: Senthu Sivarajah Cc: vaibhav.sr@gmail.com, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: greybus: audio_codec: changed a void function to return 0 Message-ID: References: <20211028153808.9509-1-ssivaraj@stud.fra-uas.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211028153808.9509-1-ssivaraj@stud.fra-uas.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 28, 2021 at 05:38:08PM +0200, Senthu Sivarajah wrote: > From: Senthuran Sivarajah > > Fixed a coding style issue. What coding style exactly? > > Signed-off-by: Senthuran Sivarajah > > --- > drivers/staging/greybus/audio_codec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c > index b589cf6b1d03..9f99862791dc 100644 > --- a/drivers/staging/greybus/audio_codec.c > +++ b/drivers/staging/greybus/audio_codec.c > @@ -1028,7 +1028,7 @@ static int gbcodec_probe(struct snd_soc_component *comp) > static void gbcodec_remove(struct snd_soc_component *comp) > { > /* Empty function for now */ > - return; > + return 0; Did you build this change? Exactly what tool reported a problem with this code and what was the exact error? thanks, greg k-h