Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp1971293pxb; Thu, 28 Oct 2021 13:38:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSWrtHxmfDVL6LtpdbUg0bM2o6amBckA+3TcSLRfZ5YN5+oAZOm9i6/Z64Lqq0tGICsKTN X-Received: by 2002:a17:907:7ea8:: with SMTP id qb40mr8594945ejc.168.1635453502709; Thu, 28 Oct 2021 13:38:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635453502; cv=none; d=google.com; s=arc-20160816; b=FjSP5EddGWXDIF44z1MxegtOYA40hdKvHg4SJJJyVQd7WVEUrXbwhCzGZkKBJsq0F8 vVITtCLsaPTfutpbDUaxD0oS6WggSp0bWs41M+c6P0ZZeadlpT6smtykfApV3VzTm+2L MNbXSn4e3URgnH/UVmn+0BDlxeZjk7H3e+y3rV8i6j7Ho6f8P1BEqst0iLmzJ98B8JGF UM00r4QwHV3wQJkeYMU3PqYrNIkVIGIgi/TQud5V9lQSUK04C4WJA85++oI/Rhaw2d9N TlE84Hl19LXIhrstozpjv/fThiqz6u3qpNvi8ymES/GRXUTnNqKAmIzBoh16ABe6zjwm owGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=RJ/TZBmAjtBZEQ7SF9pt737iGPmZZZE1EbwprVB6+B8=; b=Syb2vSy4ciBFBy4voTVEN1OMe15iB8zftBmZaSwGlmifhjc1beIrulRAgJwEE2UjyE CPakLV7YmvdrYUE3O0alWsFAZZ2dk8psegn5MRCpucUm4gk5Yd2xilAX/AG4vZIW1y/v bxQ8YkpLIV2piSDbTPquc7aN+TKFr5Kdv7DZGS6v2A/bODFEG6WUiC21CkKcFeu3fn9x +JtxBExJdwYEZBIZea+u2ESRDDlPvLe7vI/ZTPDsO+FBT9XzXXlshBCkaDdzEZcP/cnI 9fIxC0qVtvowDy8X05w6v5tEVtx6Yg+2oKEgkjSkrgWCAC1cLipo6i7UCkyXdtrgIU3/ 46Xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=cuXtA5t1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o1si9186063ejy.319.2021.10.28.13.37.58; Thu, 28 Oct 2021 13:38:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=cuXtA5t1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231221AbhJ1UiH (ORCPT + 99 others); Thu, 28 Oct 2021 16:38:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230323AbhJ1UiF (ORCPT ); Thu, 28 Oct 2021 16:38:05 -0400 Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C01A9C061570; Thu, 28 Oct 2021 13:35:37 -0700 (PDT) Received: by mail-qk1-x72a.google.com with SMTP id ay10so2036758qkb.12; Thu, 28 Oct 2021 13:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=RJ/TZBmAjtBZEQ7SF9pt737iGPmZZZE1EbwprVB6+B8=; b=cuXtA5t15HjnPp7OPl35fJNotIP9gC4nBC9TPE9YctYbO5ObFZHbko0xoAiamkVypR fb3HPJxSC26+7bEhYxyhm4pk5v9Wb/X3mMz46/h6lc7Q6l5Nq7vTunKQHC6FqQu1jhE0 jKkbX9xeWuS+72ePM+SNTfgCTMialYZ8nDqW5UgN3E5dHX6uQjvHvoPHGAQAnIsV2Q+Y 6gcXwignr0+ziJuuiyiSwJhrOoWheNNlCDpMvEj51dMoK8gjnJwBVPGJpefRMfwzLawW IGdMQh+udMfdMxl1SJSSIiB6gltmAd46fNUTwxeichW9LFCCoXGevcfXtZFVNwr3Nl7V H55Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=RJ/TZBmAjtBZEQ7SF9pt737iGPmZZZE1EbwprVB6+B8=; b=f5IPjMXUd8tPkhtN+tAPdCs06LIAbjN24w8H2Hom2f2s5jkneUkozRQ21/00Jk+Qc3 7b81AD910t4d+PzFH6w3BZ3zwR6LbKTqcfj99zp7zWCgOBmNkNjDf10LYMTKtpkwNdRZ udmyJOcwjfvVLWLzxgptJiDTnBZRlXif18HTk3Kmf9e8MjgvQzhiAeH3F7zNwys9bJED x4UmGZIlMqzHvenIV47VG/LkNi9xuIBYDC8D17j9gM/jb1NDuisHDGAENsx6TgVgFRQR VhZDolVYxj7uAohg3nGSdQeFqfhDX0q/661hFM0u4HaruvUd6Oitm+PPUQQZiNsjviJM Hjwg== X-Gm-Message-State: AOAM533MfiHj2McP+XEHhkHjuqFJsb5r7Bwu69Zw0pg73UGaoNFw8TBQ LD7Vl9IOZcZeuyUkUJQjFR0= X-Received: by 2002:a05:620a:d85:: with SMTP id q5mr5502693qkl.64.1635453336806; Thu, 28 Oct 2021 13:35:36 -0700 (PDT) Received: from localhost.localdomain ([67.8.38.84]) by smtp.gmail.com with ESMTPSA id 9sm2593575qkn.84.2021.10.28.13.35.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 13:35:36 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: alim.akhtar@samsung.com, avri.altman@wdc.com, jejb@linux.ibm.com, martin.petersen@oracle.com, beanhuo@micron.com, rdunlap@infradead.org, daejun7.park@samsung.com Cc: fazilyildiran@gmail.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: ufs: fix unmet dependency on RESET_CONTROLLER for RESET_TI_SYSCON Date: Thu, 28 Oct 2021 16:35:35 -0400 Message-Id: <20211028203535.7771-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When RESET_TI_SYSCON is selected, and RESET_CONTROLLER is not selected, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for RESET_TI_SYSCON Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y] Selected by [y]: - SCSI_UFS_MEDIATEK [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] && SCSI_UFSHCD_PLATFORM [=y] && ARCH_MEDIATEK [=y] This is because RESET_TI_SYSCON is selected by SCSI_UFS_MEDIATEK, but SCSI_UFS_MEDIATEK does not select or depend on RESET_CONTROLLER, despite RESET_TI_SYSCON depending on RESET_CONTROLLER. These unmet dependency bugs were detected by Kismet, a static analysis tool for Kconfig. Please advise if this is not the appropriate solution. Signed-off-by: Julian Braha --- drivers/scsi/ufs/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index b2521b830be7..0427f8277a5d 100644 --- a/drivers/scsi/ufs/Kconfig +++ b/drivers/scsi/ufs/Kconfig @@ -115,6 +115,7 @@ config SCSI_UFS_MEDIATEK tristate "Mediatek specific hooks to UFS controller platform driver" depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK select PHY_MTK_UFS + select RESET_CONTROLLER select RESET_TI_SYSCON help This selects the Mediatek specific additions to UFSHCD platform driver. -- 2.30.2