Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932074AbXACULa (ORCPT ); Wed, 3 Jan 2007 15:11:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932076AbXACULa (ORCPT ); Wed, 3 Jan 2007 15:11:30 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:56216 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932074AbXACUL3 (ORCPT ); Wed, 3 Jan 2007 15:11:29 -0500 Date: Wed, 3 Jan 2007 20:11:23 +0000 From: Christoph Hellwig To: Andrew Morton Cc: Arjan van de Ven , Anton Altaparmakov , Linus Torvalds , linux-kernel@vger.kernel.org Subject: Re: [2.6 PATCH] Export invalidate_mapping_pages() to modules. Message-ID: <20070103201123.GA1097@infradead.org> Mail-Followup-To: Christoph Hellwig , Andrew Morton , Arjan van de Ven , Anton Altaparmakov , Linus Torvalds , linux-kernel@vger.kernel.org References: <1167830972.3095.3.camel@laptopd505.fenrus.org> <20070103110332.ba3d39a2.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070103110332.ba3d39a2.akpm@osdl.org> User-Agent: Mutt/1.4.2.2i X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 780 Lines: 16 On Wed, Jan 03, 2007 at 11:03:32AM -0800, Andrew Morton wrote: > It makes no sense to me to export invalidate_inode_pages() and not > invalidate_mapping_pages() and I actually need invalidate_mapping_pages() > because of its range specification ability... > > akpm: also remove the export of invalidate_inode_pages() by making it an > inlined wrapper. What about just killing invalidate_inode_pages()? It only has about a dozend callers, and it's already rather misnamed since it actually operates on an address_space, not an inode. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/