Received: by 2002:a05:6a10:5bc5:0:0:0:0 with SMTP id os5csp2047734pxb; Thu, 28 Oct 2021 15:09:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiNXL4AmBidyHG71bCY7wmZdYZRMeGsHWiaynILuIKO8tz3n3I0t9b0IhhYugZeU//GIS0 X-Received: by 2002:a17:907:d14:: with SMTP id gn20mr8762902ejc.152.1635458943801; Thu, 28 Oct 2021 15:09:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1635458943; cv=none; d=google.com; s=arc-20160816; b=IlJxnDL64CVspi2jXe2DAapChfRFBpYlTuzShXux78hTYywV95RO/FR+p9Bk8S9L+u 6LUQfidza+bgkmC8RqLwBGq3r+KjSa/uneIT75GfPpxXWeMWuY18W+Ehpj4Sves+Auzj fqWsJjrAHIuQ3wnDW95+ZmjpZ3zUVlyNztzNm7WWKJjbrLy3Z3BQtGNCihwKjdt/Qcr9 nUPUHR3PPxc6uaY1oUY91L5UtOjp1gI6uXO/t2ylELiEcy5AJv+a2EoQ7AxPgSiAW8RR gCWtWU661MqXto8yp3ld6WphEPaRSKDO08MqotpR0u+ZK+N2B7Z/sr33l1+2TE7f0VQr mT4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=C0URAtIqTgzQHryIDaXXjHNMTGhauwHVxMJmkYTTzcw=; b=keJNdPjLsSax2LzxcxYKX9VzBoa6nuRpUPRAtloXIE0qJqG73FYRy5oogYgXcee6L+ ewHx7UCZXmH9EoZLq+OFpXulIg6EnL26LNQIFCXmISvZWeHwYbBGleFWl3TMEgJPUKTY XD3fAjAiYvsH56r5bnBIsijO+6vGd5jSY/DIDv9MesQvexMAVnMCGFsqVeOWCcy+bIoN VwoyfTSJej2JPJV/pdYvcr9wuo2DxOadIcpTlThqf6nZErmSFCVQO5LnW1VavuSPTD5O t5cSYJe+x3c+scOyE7Iv6stjtQA5ICvJ6NC7HNSnWiIBMz101AW3Q3oirJpdVcbzG98i ESLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=I3xholVE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca20si5185139edb.455.2021.10.28.15.08.18; Thu, 28 Oct 2021 15:09:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=I3xholVE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231368AbhJ1WH1 (ORCPT + 99 others); Thu, 28 Oct 2021 18:07:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231290AbhJ1WH0 (ORCPT ); Thu, 28 Oct 2021 18:07:26 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26196C061570; Thu, 28 Oct 2021 15:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=C0URAtIqTgzQHryIDaXXjHNMTGhauwHVxMJmkYTTzcw=; b=I3xholVEQwOxRuk+KBgytIi7NE dMq2/VOKL87Gb1Z02gGctYBsEcSY3I/0ztJPKeD5K92k/tfLeikdTaARinMxo94EORTUUfXMZkwJr eVDv3lUE0pBekA3+62d8Ev1/d2mDaf8EQoaIwp9Abqbh+x9xz8wTVnx+h+8mzIXmGWFDEgUwbV4Jm 0unwxjYpsw11aL5gbJB3l9lF36CU80XzT3Rb984X2VS4iANDp6QNNRZqFcPePm8wfPBrjeiRUNy2j 2iHpCgdAj1PIBPpTEO8L+YBOA1e/RUJV+MZPAq0L1bOgzawtbDnct82/QWdm62E9RcvAwL3uKZFnp Yfi9E/hA==; Received: from [2601:1c0:6280:3f0::aa0b] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgDW0-009D9u-33; Thu, 28 Oct 2021 22:04:52 +0000 Subject: Re: [v2 10/10] iio: imu: add BNO055 I2C driver To: Andrea Merello , jic23@kernel.org, mchehab+huawei@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: lars@metafoo.de, robh+dt@kernel.org, andy.shevchenko@gmail.com, matt.ranostay@konsulko.com, ardeleanalex@gmail.com, jacopo@jmondi.org, Andrea Merello References: <20210715141742.15072-1-andrea.merello@gmail.com> <20211028101840.24632-1-andrea.merello@gmail.com> <20211028101840.24632-11-andrea.merello@gmail.com> From: Randy Dunlap Message-ID: <85ef90ad-0d3a-6cb7-529f-667562b2ad71@infradead.org> Date: Thu, 28 Oct 2021 15:04:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211028101840.24632-11-andrea.merello@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/28/21 3:18 AM, Andrea Merello wrote: > This path adds an I2C driver for communicating to a BNO055 IMU via I2C bus > and it enables the BNO055 core driver to work in this scenario. > > Signed-off-by: Andrea Merello > --- > drivers/iio/imu/bno055/Kconfig | 6 ++++ > drivers/iio/imu/bno055/Makefile | 1 + > drivers/iio/imu/bno055/bno055_i2c.c | 54 +++++++++++++++++++++++++++++ > 3 files changed, 61 insertions(+) > create mode 100644 drivers/iio/imu/bno055/bno055_i2c.c > > diff --git a/drivers/iio/imu/bno055/Kconfig b/drivers/iio/imu/bno055/Kconfig > index 941e43f0368d..87200787d548 100644 > --- a/drivers/iio/imu/bno055/Kconfig > +++ b/drivers/iio/imu/bno055/Kconfig > @@ -7,3 +7,9 @@ config BOSH_BNO055_SERIAL > tristate "Bosh BNO055 attached via serial bus" > depends on SERIAL_DEV_BUS > select BOSH_BNO055_IIO > + > +config BOSH_BNO055_I2C > + tristate "Bosh BNO055 attached via I2C bus" > + depends on I2C > + select REGMAP_I2C > + select BOSH_BNO055_IIO Hi, The config entries that have user prompt strings should also have help text. scripts/checkpatch.pl should have told you about that... -- ~Randy