Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 28 Oct 2021 15:46:53 -0700
From:   Martin KaFai Lau <kafai@fb.com>
To:     Florent Revest <revest@chromium.org>
CC:     <bpf@vger.kernel.org>, <ast@kernel.org>, <daniel@iogearbox.net>,
        <andrii@kernel.org>, <kpsingh@kernel.org>, <jackmanb@google.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: Allow bpf_d_path in perf_event_mmap
Message-ID: <20211028224653.qhuwkp75fridkzpw@kafai-mbp.dhcp.thefacebook.com>
References: <20211028164357.1439102-1-revest@chromium.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20211028164357.1439102-1-revest@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IAzhlQfSj9vsv2HiehA8BAFHeL/7QfSlbpfHSgWgrEjb5ciZckCgSh17R9JV?=
 =?us-ascii?Q?982QJEcllx8B5iZOEOzOUO8zqfZhEnIhgQJ86irPvWZ/f/xkvqSAe7G20Ikh?=
 =?us-ascii?Q?EYDcsU9OMwG8jUbMb35o8amOmQcnRQxcMa8UJ8g9+g7QzKuKubcz+UFSEsoT?=
 =?us-ascii?Q?C44wFC/UxNJXIzz9DZa9MThBvXuOxqZb7x+6pbwxUGfgjGub9dwTaZ0f3y5T?=
 =?us-ascii?Q?HOQQOkUAB3DDSkqAvG5n0pNgiwBicllYDH9khUXZIo8+poveUTwwQ6j8x+1X?=
 =?us-ascii?Q?7niHDdcuxNj5sAhbby4uo+4r2bsY3Qn4uUCd1Z9GcPqd+L7B1DqhbUH8cevl?=
 =?us-ascii?Q?n2QWgd1YuuAXNbZMAvTQ8Ds2ZZzr0lEGXRx/nddOP14Y+R9BN/vh9ErX5z7J?=
 =?us-ascii?Q?g4OXhmSH537k3V8Vto8+yNhOk40RWLTJ0oqCjKKCQ+mkh/UwtbNZLZ0hHjHh?=
 =?us-ascii?Q?yYM10G+hR08bSN9q8ilgV1gBs98ZgRj8eEpxzViHlP5SfedMT8gif5drAKzs?=
 =?us-ascii?Q?iOq34A1b6ezLsohquxHLlGtvT+szO7O6sn1+HcGC6DDN+z9Wt4inMDGWpy7W?=
 =?us-ascii?Q?xW+doqGFWW1TDfQvMJyG8Lrjj4mkcarLWPB18PYYc5l151OIozPUFvvYsrqv?=
 =?us-ascii?Q?KPet36tBc+mlrGdiVE+uI75/VUjrFOpNrHT07RVmJ7thYgr2F8KY4uUFK+ZG?=
 =?us-ascii?Q?3RI5AsZbOs/u+5POtywie/wAg67+jnamKI4lGH8+Mpk78whcdihh03VqSYca?=
 =?us-ascii?Q?M+E/r0ABmXzGaED9RPbTMtMRky1GNsuN1H0zHVHTY8e6REEUD5hPds+bwqVN?=
 =?us-ascii?Q?tyr5SiJIhwPZnX2f/38O1LM2ph3WV2F4vk2Lj1wkYgODoI8Y+lW4+ZBVB3hn?=
 =?us-ascii?Q?abPHRV1HJwhD7SuUsBZ/ZhzIzKQwP0HQ5Pkk+gxh0pRGe1ZUrzj64hoEPeHy?=
 =?us-ascii?Q?Sk6vKQBJpT8jylAkowV9Yzuwf8D1Wyas/k77yBGDDJ2y+MwZhbS9yGcKfUg9?=
 =?us-ascii?Q?qcU3m2bDfPM9T7V3sFfn5xdp90X2bnUiVZFFt6WIc6Rj+lgXWxlaed+aTE1s?=
 =?us-ascii?Q?mFfXqdgHKq7DhGJJ9R6zajA9W/ZEpthh/WKbNQQ2TMWZ1TT2LkbZVi71VZ19?=
 =?us-ascii?Q?DpWM26i8DAtpP6JmVqC1Gef1gdS4pbqayenrsdNvDF0HS8PV41x8ZeIXdVnA?=
 =?us-ascii?Q?mdI7W+b26nNWqkp/hE5xOmvqhM3lyttYUuXuF6ZHg+AfffixuExuJOxH2PBR?=
 =?us-ascii?Q?xVexHs6riV7YTvMhaJmheQsGwADM3MWAtsgi9hE2bR2nMTyTDvuF9TW8h1iS?=
 =?us-ascii?Q?jcc1xjhuYq6ca9E3tYvSre1G0Zd2hWVAJdcu6HP1E1URQ0xkFOzj9o1Kobrp?=
 =?us-ascii?Q?J0xAGIN/hPs4G4TLRY95gdZWChiljqQiZqvJx8OmrKgfPb3sfvs01h0+y+ye?=
 =?us-ascii?Q?diHHP0r9RVV4mg7u4qVBaAR0bLfgc+YCF9AwenWVU4bxdEBAxUZdhVnkuUEZ?=
 =?us-ascii?Q?l5EV+x2//hIqm4P2IpI5GAaJzlqjQuc2GvyYOQ26IFf3AddsQrQVPpx0DTMp?=
 =?us-ascii?Q?4PSRbfATRnfZSkFnVtYlmZ73h0cbpwGP+nz6AyvmoZ0n/xadhCdrhxS3hdrq?=
 =?us-ascii?Q?Ag=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0dab10b6-1183-4721-122f-08d99a64d87b
X-MS-Exchange-CrossTenant-AuthSource: SA1PR15MB5016.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2021 22:46:57.0281
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8nOlyGuOpxe8YemfOuBONYt/4vOnkdsINdwreweaP+cvtUXAxUncrewmtbEviuZS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR15MB4174
X-OriginatorOrg: fb.com
X-Proofpoint-ORIG-GUID: ln47yWow61BVtn8zRf_rsOBpGUgDQ89V
X-Proofpoint-GUID: ln47yWow61BVtn8zRf_rsOBpGUgDQ89V
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475
 definitions=2021-10-28_06,2021-10-26_01,2020-04-07_01
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 priorityscore=1501
 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 clxscore=1011
 impostorscore=0 mlxlogscore=983 mlxscore=0 lowpriorityscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2110150000 definitions=main-2110280120
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Oct 28, 2021 at 06:43:57PM +0200, Florent Revest wrote:
> Allow the helper to be called from the perf_event_mmap hook. This is
> convenient to lookup vma->vm_file and implement a similar logic as
> perf_event_mmap_event in BPF.
From struct vm_area_struct:
	struct file * vm_file;          /* File we map to (can be NULL). */

Under perf_event_mmap, vm_file won't be NULL or bpf_d_path can handle it?

> 
> Signed-off-by: Florent Revest <revest@chromium.org>
> ---
>  kernel/trace/bpf_trace.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
> index cbcd0d6fca7c..f6e301c775a5 100644
> --- a/kernel/trace/bpf_trace.c
> +++ b/kernel/trace/bpf_trace.c
> @@ -922,6 +922,9 @@ BTF_ID(func, vfs_fallocate)
>  BTF_ID(func, dentry_open)
>  BTF_ID(func, vfs_getattr)
>  BTF_ID(func, filp_close)
> +#ifdef CONFIG_PERF_EVENTS
> +BTF_ID(func, perf_event_mmap)
> +#endif
>  BTF_SET_END(btf_allowlist_d_path)
>  
>  static bool bpf_d_path_allowed(const struct bpf_prog *prog)
> -- 
> 2.33.0.1079.g6e70778dc9-goog
>