Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20211020095926.735938-1-flokli@flokli.de> <20211020095926.735938-2-flokli@flokli.de>
In-Reply-To: <20211020095926.735938-2-flokli@flokli.de>
From:   Dennis Gilmore <dgilmore@redhat.com>
Date:   Thu, 28 Oct 2021 19:08:03 -0500
Message-ID: <CAJesf3Oenzbtm09YbgfMowWSkJ0OBCVkNq4Fh3rDqN7pW9SCJg@mail.gmail.com>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: fix poweroff
To:     Florian Klink <flokli@flokli.de>
Cc:     Heiko Stuebner <heiko@sntech.de>, Aditya Prayoga <aditya@kobol.io>,
        Rob Herring <robh+dt@kernel.org>,
        =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= <uwe@kleine-koenig.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/Rockchip SoC support" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-rockchip@lists.infradead.org,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Tested-by: Dennis Gilmore <dgilmore@redhat.com>


On Thu, Oct 28, 2021 at 11:37 AM Florian Klink <flokli@flokli.de> wrote:
>
> Adding the rockchip,system-power-controller property here will use the
> rk808 to power off the system.
>
> Signed-off-by: Florian Klink <flokli@flokli.de>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> index 93745dcc2af6..af3bf7800dba 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts
> @@ -293,6 +293,7 @@ rk808: pmic@1b {
>                 clock-output-names = "xin32k", "rk808-clkout2";
>                 pinctrl-names = "default";
>                 pinctrl-0 = <&pmic_int_l>;
> +               rockchip,system-power-controller;
>                 vcc1-supply = <&vcc5v0_sys>;
>                 vcc2-supply = <&vcc5v0_sys>;
>                 vcc3-supply = <&vcc5v0_sys>;
> --
> 2.33.0
>


-- 
Dennis Gilmore
Multiple Architecture Portfolio Enablement
T: +1-312-660-3523