Message-ID: <459C1AB7.9070901@drzeus.cx>
Date: Wed, 03 Jan 2007 22:05:59 +0100
From: Pierre Ossman <drzeus-list@drzeus.cx>
User-Agent: Thunderbird 1.5.0.9 (X11/20061223)
MIME-Version: 1.0
To: Philip Langdale <philipl@overt.org>
CC: linux-kernel@vger.kernel.org, John Gilmore <gnu@toad.com>
Subject: Re: [PATCH 2.6.19] mmc: Add support for SDHC cards
References: <458C22C0.1080307@vmware.com> <4597A327.8030408@drzeus.cx> <459926B5.60505@overt.org>
In-Reply-To: <459926B5.60505@overt.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1029
Lines: 32

Philip Langdale wrote:
> Heh. I forget that you don't want to manually alter the email. Will do.
>
>   

I'm rather reluctant to change anything once someone has put a
signed-off-by line to it. Different people have different limits as to
what they regard a trivial modification.

> Done. I thought we needed it before both SD_APP_SEND_OP_COND calls but
> it's only needed before the second one so I've moved it inline into
> mmc_setup.
>
>   

The spec says we need it at both (even though it might not be so in
practice). We should follow the spec first and foremost.

Rgds

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/